Skip to content

update#3

Merged
viral28 merged 30 commits intoviral28:developfrom
MDAnalysis:develop
Oct 22, 2020
Merged

update#3
viral28 merged 30 commits intoviral28:developfrom
MDAnalysis:develop

Conversation

@viral28
Copy link
Copy Markdown
Owner

@viral28 viral28 commented Oct 22, 2020

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

lilyminium and others added 30 commits September 10, 2020 00:31
Fixes issue #2939 

## Work done in this PR
- Adds missing file types of testsuite/setup.py
  (*top, *in, *sdf, and the contents of data/gromacs/gromos54a7_edited.ff/*).
- fix #2934
- use unistd.h in ENCORE's spe.c when not WIN32 (e.g.  __unix__ or __APPLE__ but to be consistent
  with other uses in the code base we do not specifically test for __unix__ ||
  __APPLE__)
- update CHANGELOG
ensure that unistd.h is included on recent clang
Towards #2739 

## Work done in this PR
Removes the old helanal code in favour of helix_analysis
* assigns empty string for missing elements
* PEP8 fixes
* Update README.rst
* Remove bolding from tutorials (does not work as a reST link)
* invalid escape sequences in `str/bytes` are deprecated
in newer versions of Python: https://bugs.python.org/issue27364

* fix the various `DeprecationWarning: invalid escape sequence \..`
warnings emitted by our full test suite, mostly by using raw strings
`r'...'` to allow use of internal `\`

* full test suite warning count drops slightly from 30,298 to
30,276
* invalid escape sequence usage is now treated
as an error in our full test suite to prevent
regressions

* CHANGELOG update
- mostly convert strings to raw strings
- removed a number of embedded newlines from raw strings
  (because they do not work in raw strins as expected)
- fixed heading of MDAnalysis/core/topologyattrs.py
- fixed reST in Janin
 - Copies the latest release to https://docs.mdanalysis.org/stable/
 - Copies latest dev docs to https://docs.mdanalysis.org/dev
 - Allows docs to be intersphinxed at above URLs
Fixes issue #2951 

## Work done in this PR

- Restores the parmed intersphinx link.
Fixes #2979

## Work done in this PR

The file test_bat_IO.npy was created in one test and used in
another one. This leads to the second test possibly failing
when the tests are run in parallel. This commit moves creating
the file into a fixture that the two tests depends.

The new fixture also uses the tmpdir fixture to avoid the file
created during the tests to remain in the test directory.
Not an issue targetted fix.

## Overview

mamba is a dropin replacement for the conda CLI but faster

## Work done in this PR

Enabled the `MAMBA` environment variable keyword for the CI helper.
* Fixes #2990
* Update indexing in Charges and Masses get_residues: 
   Avoid indexing a numpy array with a list of arrays, use a tuple of array
   instead. Multidimensional indexing of arrays with a non-tuple argument
   is deprecated.
* Turn warnings into errors to avoid regression over #2990
* Update CHANGELOG
* TST, CI: add ARM64 Graviton 2 to CI

* start testing MDAnalysis on ARM64 using
new AWS Graviton 2 architecture available
in Travis CI

* testing on my fork shows only two failures
in the MDAnalysis test suite using a fairly
minimal set of dependencies; we can probably
either fix those or skip them and open an issue

* the test failures are:
`test_written_remarks_property`
`TestEncoreClustering.test_clustering_three_ensembles_two_identical`

* run time for this CI entry is about
23 minutes, which is solid for ARM; we save a lot
of time using experimental upstream wheels in some
cases and excluding (source builds of) dependencies
where possible until the ARM64 binary wheel ecosystem
matures a bit more

* MAINT: ARM64 shims

* adjust `CAffinityPropagation()` C-level function to use `double`
instead of `float` in some strategic locations that allow the
`test_clustering_three_ensembles_two_identical()` test to pass
on gcc115 ARM64 machine

* mark `test_written_remarks_property()` as a known failure on
ARM64; it fails in Travis CI on that platform, but not on gcc115
ARM64 machine; that said, this test is already known to be flaky
on Windows 32-bit (may depend on character settings on machine?)

* MAINT: MR 2956 revisions

* reduce optimization level of MDAnalysis builds on
ARM64 to avoid problems with `ap.c` causing test failures
on that architecture

* revert any source changes to `ap.c`
Fixes issue #1989, completes PR #2956

## Work done in this PR

* Switches CI to using recently released SciPy `1.5.3` with "official" Linux ARM64 wheels
over the weekend, instead of the previous "special"/unreleased wheels
* Add a `CHANGELOG` entry to reflect preliminary MDAnalysis support
for the Linux ARM64 platform (minimal dependencies)
Fixes #2993

Redirect URLs in stable/sitemap.xml and dev/sitemap.xml to correct locations
* Add a reindex argument to the PDBWritter

* Tests for PDB reindex

* Remove extra print

* Test PDB CONECT with reindex=False

* Update CHANGELOG

* More precise version change for PDB reindex

* Fix long lines

* Increase test coverage for #2886

Also silence some warnings for the tests in the PR.

* Remove useless branch in PDB.py

There was a test in PDBWriter._write_pdb_bonds about writing the bonds
for an atomgroup that does not have AG.ids but asking to not reindex.
The test was silencing the problem and would lead to the bonds not being
written. However, that part of the code would never be reached because
writing the atoms would have raised an exception before that method is
called.

This commit removes this test. Now, if that part of the code is called
(which should not happen), an exception is raised when the method tries
to access AG.ids.
- Fixes #1845 
- Adds dummy method with documentation of original method
- Dummy method gets replaced by actual method on instantiation
@viral28 viral28 merged commit 3053bb2 into viral28:develop Oct 22, 2020
@pep8speaks
Copy link
Copy Markdown

Hello @viral28! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 118:80: E501 line too long (87 > 79 characters)
Line 119:80: E501 line too long (92 > 79 characters)

Line 79:29: E261 at least two spaces before inline comment
Line 79:80: E501 line too long (81 > 79 characters)

Line 807:80: E501 line too long (81 > 79 characters)

Line 203:80: E501 line too long (102 > 79 characters)
Line 416:80: E501 line too long (102 > 79 characters)
Line 785:80: E501 line too long (83 > 79 characters)

Line 1087:80: E501 line too long (91 > 79 characters)

Line 606:80: E501 line too long (100 > 79 characters)
Line 608:80: E501 line too long (100 > 79 characters)
Line 610:80: E501 line too long (100 > 79 characters)
Line 612:80: E501 line too long (100 > 79 characters)
Line 614:80: E501 line too long (100 > 79 characters)
Line 616:80: E501 line too long (100 > 79 characters)
Line 618:80: E501 line too long (100 > 79 characters)
Line 620:80: E501 line too long (100 > 79 characters)
Line 622:80: E501 line too long (100 > 79 characters)
Line 624:80: E501 line too long (100 > 79 characters)
Line 626:80: E501 line too long (100 > 79 characters)
Line 628:1: W293 blank line contains whitespace

Line 412:80: E501 line too long (80 > 79 characters)

Line 1091:80: E501 line too long (81 > 79 characters)

Line 268:80: E501 line too long (81 > 79 characters)
Line 271:80: E501 line too long (81 > 79 characters)
Line 619:80: E501 line too long (81 > 79 characters)

Line 45:80: E501 line too long (82 > 79 characters)
Line 235:80: E501 line too long (81 > 79 characters)

Line 121:80: E501 line too long (81 > 79 characters)
Line 143:80: E501 line too long (81 > 79 characters)

Line 1024:31: E201 whitespace after '['
Line 1027:31: E201 whitespace after '['
Line 1067:80: E501 line too long (84 > 79 characters)
Line 1068:80: E501 line too long (133 > 79 characters)
Line 1069:80: E501 line too long (129 > 79 characters)
Line 1070:80: E501 line too long (132 > 79 characters)
Line 1071:80: E501 line too long (127 > 79 characters)
Line 1303:39: E127 continuation line over-indented for visual indent
Line 1315:39: E127 continuation line over-indented for visual indent
Line 1344:39: E127 continuation line over-indented for visual indent
Line 1358:39: E127 continuation line over-indented for visual indent

Line 357:21: E127 continuation line over-indented for visual indent

Line 47:80: E501 line too long (87 > 79 characters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants