587 unit test for prernadsutil

[manamittal]

Description

Unit tests for prerna.ds.util

Changes Made

Wrote unit tests for the prerna.ds.util package.

close #587

[github-actions]

@CodiumAI-Agent /describe

[github-actions]

@CodiumAI-Agent /review

[QodoAI-Agent]

Title

587 unit test for prernadsutil

---

User description

Description

Unit tests for prerna.ds.util

Changes Made

Wrote unit tests for the prerna.ds.util package.

close #587

---

PR Type

• Tests

---

Description

• Added comprehensive unit tests for util package methods

• Validated flatfile iterators: CSV and Parquet

• Covered SQL query building and file handling functions

• Ensured proper exception and invalid selector handling

---

Changes walkthrough 📝

Relevant files

Tests

IFileIteratorUnitTests.java Add IFileIterator unit tests                                                          test/prerna/ds/util/IFileIteratorUnitTests.java Add unit test for getNumRecordsOverSize method using mocks Verify method invocation and assert expected boolean result +35/-0    QueryStructConverterUnitTests.java Add QueryStructConverter unit tests                                            test/prerna/ds/util/QueryStructConverterUnitTests.java Test conversion from old QueryStruct to new query structure Validate selectors, groupBy, and orderBy conversion accuracy +80/-0    RdbmsQueryBuilderUnitTests.java Add RdbmsQueryBuilder unit tests                                                  test/prerna/ds/util/RdbmsQueryBuilderUnitTests.java Validate SQL escaping and merge query generation Test table creation from file with and without IO exceptions Ensure proper file deletion behavior under different scenarios +221/-0  AbstractFileIteratorUnitTests.java Add AbstractFileIterator unit tests                                            test/prerna/ds/util/flatfile/AbstractFileIteratorUnitTests.java Verify iterator behavior (hasNext, next) and row cleaning Validate exception handling and file deletion functionality +288/-0  CsvFileIteratorUnitTests.java Add CsvFileIterator unit tests                                                      test/prerna/ds/util/flatfile/CsvFileIteratorUnitTests.java Test CSV file iterator constructor and header updates Check reset, close operations and invalid selector exceptions +141/-0  ParquetFileIteratorUnitTests.java Add ParquetFileIterator unit tests                                              test/prerna/ds/util/flatfile/ParquetFileIteratorUnitTests.java Verify initialization and header modification for Parquet files Test selectors handling, reset and close functionalities +188/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

@CodiumAI-Agent /improve

[QodoAI-Agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 587 - Partially compliant Compliant requirements: Unit tests for IFileIterator, QueryStructConverter, RdbmsQueryBuilder, and various flatfile iterators have been implemented. Non-compliant requirements: None Requires further human verification: Run tests in an integrated environment to ensure that all edge cases and file I/O behaviors are as expected.

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review SQL Query Assertion Verify that the expected SQL query string assertions are robust against minor formatting or conversion changes. String expectedQuery = "DROP TABLE IF EXISTS column1; CREATE TABLE column1 (column1 VARCHAR, column2 INTEGER) AS SELECT column1, CONVERT(column2, Int) from CSVREAD('test.csv');"; String actualQuery = RdbmsQueryBuilder.createTableFromFile(fileName, conceptTypes); assertEquals(expectedQuery, actualQuery); } } Dependency Mocking Check that the mocked construction of ParquetFileHelper correctly intercepts header modifications and that the user-defined header changes are fully validated. void testModifyCleanedHeaders_withUserDefinedHeaders() { Map<String, String> userDefinedHeaders = new HashMap<>(); userDefinedHeaders.put("new_name", "name"); userDefinedHeaders.put("new_age", "age"); when(mockQueryStruct.getNewHeaderNames()).thenReturn(userDefinedHeaders); try (MockedConstruction<ParquetFileHelper> mocked = Mockito.mockConstruction(ParquetFileHelper.class, (mock, context) -> { when(mock.getHeaders()).thenReturn(new String[]{"name", "age"}); })) { iterator = new ParquetFileIterator(mockQueryStruct); ParquetFileHelper helperInstance = mocked.constructed().get(0); Mockito.verify(helperInstance).modifyCleanedHeaders(userDefinedHeaders); }

[QodoAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Correct error message text Revise the error message to reflect the correct file import type instead of referencing "csv" for parquet tests. test/prerna/ds/util/flatfile/ParquetFileIteratorUnitTests.java [100] -assertEquals("Cannot perform math on a csv import", thrown.getMessage()); +assertEquals("Cannot perform math on a parquet import", thrown.getMessage()); Suggestion importance[1-10]: 8 __ Why: The suggestion addresses a correctness issue in the test error message by replacing "csv" with "parquet", which aligns the message with the file type being tested.	Medium

[EJV20]

Good Job!

[github-actions]

@CodiumAI-Agent /update_changelog

[QodoAI-Agent]

Changelog updates: 🔄

2025-05-01 *

Added

• Unit tests for the prerna.ds.util package.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'