Skip to content

adding push condition - change to pyproject toml file; adding event i…#790

Merged
kunal0137 merged 1 commit intodevfrom
python-builder-toml-file-change
May 7, 2025
Merged

adding push condition - change to pyproject toml file; adding event i…#790
kunal0137 merged 1 commit intodevfrom
python-builder-toml-file-change

Conversation

@radkalyan
Copy link
Copy Markdown
Contributor

…nput vars to env vars

Description

Adding push condition change to python builder - change to pyproject toml file

Changes Made

  • Adding push condition change - any change to pyproject toml will trigger python builder
  • Fixing the environment variables - passing in workflow dispatch variables dynamically

How to Test

  1. Check in changes to dev branch - this should trigger the build
  2. Or, can trigger the workflow manually

Notes

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 7, 2025

@CodiumAI-Agent /describe

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 7, 2025

@CodiumAI-Agent /review

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 7, 2025

@CodiumAI-Agent /improve

@QodoAI-Agent
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Incorrect context syntax

The workflow references github.events.input which is incorrect; the proper context is github.event.inputs. This typo can cause syntax errors and undefined values.

PYTHON_VERSION: ${{ github.events.input.python_version }}
COMPUTE_TYPE: ${{ github.events.input.compute_type }}
BASE_REGISTRY: ${{ github.events.input.base_registry }}
BASE_IMAGE: ${{ github.events.input.base_image }}
BASE_TAG: ${{ github.events.input.base_tag }}
Undefined env on push

Environment variables sourced from workflow_dispatch inputs will be undefined when the workflow is triggered by a push event. Consider providing defaults or conditionally setting these variables.

PYTHON_VERSION: ${{ github.events.input.python_version }}
COMPUTE_TYPE: ${{ github.events.input.compute_type }}
BASE_REGISTRY: ${{ github.events.input.base_registry }}
BASE_IMAGE: ${{ github.events.input.base_image }}
BASE_TAG: ${{ github.events.input.base_tag }}

@QodoAI-Agent
Copy link
Copy Markdown

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
Possible issue
Correct input context reference

Use the correct context for workflow_dispatch inputs: the github.event.inputs
attribute (plural inputs on github.event) instead of github.events.input.

.github/workflows/python-builder.yml [49-53]

-PYTHON_VERSION: ${{ github.events.input.python_version }}
-COMPUTE_TYPE: ${{ github.events.input.compute_type }}
-BASE_REGISTRY: ${{ github.events.input.base_registry }}
-BASE_IMAGE: ${{ github.events.input.base_image }}
-BASE_TAG: ${{ github.events.input.base_tag }}
+PYTHON_VERSION: ${{ github.event.inputs.python_version }}
+COMPUTE_TYPE: ${{ github.event.inputs.compute_type }}
+BASE_REGISTRY: ${{ github.event.inputs.base_registry }}
+BASE_IMAGE: ${{ github.event.inputs.base_image }}
+BASE_TAG: ${{ github.event.inputs.base_tag }}
Suggestion importance[1-10]: 9

__

Why: The suggestion fixes the incorrect GitHub Actions context github.events.input to the correct github.event.inputs, which would otherwise prevent the workflow from picking up the inputs.

High
General
Separate push conditions

Split the push trigger into two entries to OR‐combine branch updates and path
changes, since branches+paths are AND‐filtered by default.

.github/workflows/python-builder.yml [31-36]

-push:
-  branches: [ "dev", "main"]
-  paths:
-    - 'docker/Dockerfile.python'
-    - 'py/install_config/pyproject.toml'
-    - '.github/workflows/python-builder.yml'
+on:
+  push:
+    - branches: [ "dev", "main"]
+      paths:
+        - 'docker/Dockerfile.python'
+        - '.github/workflows/python-builder.yml'
+    - paths:
+        - 'py/install_config/pyproject.toml'
Suggestion importance[1-10]: 6

__

Why: Splitting the push trigger into multiple mappings correctly implements OR semantics between branches and paths, improving trigger flexibility and aligning with GitHub Actions behavior.

Low

@radkalyan radkalyan requested review from kunal0137 and resmas-tx May 7, 2025 16:46
@kunal0137 kunal0137 merged commit 3a0cdc6 into dev May 7, 2025
4 checks passed
@kunal0137 kunal0137 deleted the python-builder-toml-file-change branch May 7, 2025 16:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 7, 2025

@CodiumAI-Agent /update_changelog

@QodoAI-Agent
Copy link
Copy Markdown

Changelog updates: 🔄

2025-05-07 #790

Changed

  • Trigger python-builder workflow on pyproject.toml changes
  • Pass environment variables from workflow dispatch inputs

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

manamittal added a commit that referenced this pull request May 20, 2025
* fix(python): handle eval when it is a single line execution but there is string input with space (#756)

* Update Dockerfile.tomcat (#757)

* fix: tomcat builder setting env var

* fix: updating tomcat to 9.0.104

* Update Dockerfile.ubuntu22.04

* Update Dockerfile.ubuntu22.04

* Update Dockerfile.ubuntu22.04

* feat: creating KubernetesModelScaler class (#763)

* Update Dockerfile.ubuntu22.04

* feat: adding ability to attach a file to a vector db source (#736)

* Added AttachSourceToVectorDbReactor for uploading pdf file to an existing csv file and modified VectorFileDownloadReactor

* fix: proper return for the download and matching the reactor name

* fix: error for downloading single file vs multiple; error for copyToDirectory instead of copyFile

* chore: renaming so reactor matches VectorFileDownload

---------

Co-authored-by: Maher Khalil <themaherkhalil@gmail.com>

* Update Dockerfile.ubuntu22.04

* Update ubuntu2204.yml

* Update ubuntu2204.yml

* Update ubuntu2204_cuda.yml

* Update Dockerfile.nvidia.cuda.12.5.1.ubuntu22.04

* Update ubuntu2204_cuda.yml

* Update ubuntu2204.yml

* feat: exposing tools calling through models (#764)

* 587 unit test for prernadsutil (#654)

* test(unit): unit tests for the prerna.util.ds package

* test(unit): unit tests for the prerna.util.ds.flatfile package

* test(unit): removed reflections, added paraquet tests

* test(unit): unit tests for the prerna.util.ds package

* test(unit): unit tests for the prerna.util.ds.flatfile package

* test(unit): removed reflections, added paraquet tests

* Update ubuntu2204.yml

* Update ubuntu2204.yml

* Update ubuntu2204.yml

* fix: update pipeline docker buildx version

* fix: ignore buildx

* fix: adjusting pipeline for cuda

* feat: switching dynamic sas to default false (#766)

* fix: changes to account for version 2.0.0 of pyjarowinkler (#769)

* chore: using 'Py' instead of 'py' to be consistent (#770)

* feat: full ast parsing of code to return evaluation of the last expression (#771)

* Python Deterministic Token Trimming for Message Truncation (#765)

* feat: deterministic-token-trimming

* feat: modifying logic such that system prompt is second to last message for truncation

---------

Co-authored-by: Maher Khalil <themaherkhalil@gmail.com>

* fix: added date added column to enginepermission table (#768)

* fix: add docker-in-docker container to run on sef-hosted runner (#773)

Co-authored-by: Raul Esquivel <resmas.work@gmail.com>

* fix: properly passing in the parameters from kwargs/smss into model limits calculation (#774)

* fix: removing legacy param from arguments (#777)

* fix: Fix docker cache build issue (#778)

* adding no cache

* adding no cache

* feat: Adding Semantic Text Splitting & Token Text Splitting (#720)

* [696] - build - Add chonky semantic text splitting - Added the function for chonky semantic text splitting and integrated with existing flow.

* [696] - build - Add chonky semantic text splitting - Updated the code

* [696] - build - Add chonky semantic text splitting - Updated the code comments

* feat: adding reactor support through java

* feat: updating pyproject.toml with chonky package

* feat: check for default chunking method in smss

* [696] - feat - Add chonku semantic text splitting - Resolved the conflicts

* [696] - feat - Add chonky semantic text splitting - Organized the code.

* feat: adding chunking by tokens and setting as default

* updating comments on chunking strategies

---------

Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com>
Co-authored-by: kunal0137 <kunal0137@gmail.com>

* feat: allowing for tools message in full prompt (#780)

* UPDATE ::: Add docker in docker Dockerfiler (#784)

* add docker in docker Dockerfile

* Update Dockerfile.dind

Remove python and tomcat arguments from Dockerfile

* fix: remove-paddle-ocr (#786)

* [#595] test(unit): adds unit test for prerna.engine.impl.model.kserve

Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* feat: Tag semoss image (#789)

* adding changes for non-release docker build

* adding non-release build logic to cuda-semoss builder

* updating push branches

* fix: branch names on docker builds

* fix: branch names on docker builds cuda

* fix: adding push condition - change to pyproject toml file; adding event input vars to env vars (#790)

* fix: python builder toml file change (#792)

* fix: Catch errors when calling pixels from Python (#787)

Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com>

* Creating db links between engines and default apps (#693)

* create db links between engine and default app

* Rename column APPID to TOOL_APP

* feat: add database_tool_app to getUserEngineList

---------

Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com>

* Adding sort options to the myengines reactor (#479)

* added sort feature to MyEnginesReactor and genericized reactor imports

* formatting

* overloading method

* validate sortList

---------

Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* feat: cleaning up unused imports in MyEngine reactor (#793)

* feat: Create Enum projectTemplate and update CreateAppFromTemplateReactor to accept existing appID for cloning applications (#621)

Co-authored-by: kunal0137 <kunal0137@gmail.com>

* Update GetEngineUsageReactor.java (#417)

Co-authored-by: Maher Khalil <themaherkhalil@gmail.com>
Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* Issue 596: Adds Unit Tests for prerna/engine/impl/model/responses and workers (#727)

* [#596] test(unit): adds unit tests

* fix: implements ai-agents suggestions

---------

Co-authored-by: Jeff Vitunac <jvitunac@gmail.com>
Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* 609 implement native blob storage for azure gcp and aws (#674)

* Initial commit : implementation for azure blob storage

* added dependency for azure in pom.xml

* update logic to fetch the metadata from list details

* changed functionality from listing containers to listing files within a selected container

* initial commit for google cloud storage implementation

* added field contant in enum class and removed unused method

* add methods to parse comma-separated local and cloud paths

* add methods to parse comma-separated local and cloud paths

* implementation for aws s3 bucket

* normalize container prefix path

* merged all: implementation for azure, aws and gcp

* refactor(storage): replace manual path normalization with normalizePath from Utility class

---------

Co-authored-by: pvijayaraghavareddy <pvijayaraghavareddy@WORKSPA-6QV71G7.us.deloitte.com>
Co-authored-by: Parth <parthpatel3@deloitte.com>
Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* Get Node Pool Information for Remote Models (#806)

* 590 unit test for prernaengineimpl (#808)

* test(unit): update to filesystems hijacking for testing files

* test: start of unit tests for abstract database engine

* test(unit): added unit test for prerna.engine.impl

* test(unit): finsihed tests for prerna.engine.impl

* test(unit): adding back unused assignment

---------

Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* Creating WordCountTokenizer Class (#802)

* feat: creating word count tokenizer class && falling back to word count tokenizer if tiktok fails

* feat: updating comment

* feat: setting default chunking method as recursive (#810)

* Unit tests fixes and Unit test Class file location updates (#812)

* test(unit): moved tests to correct packages

* test(unit): fixed a couple of unit tests

* VectorDatabaseQueryReactor: output divider value for word doc chunks always 1 (#804)

* Code implementation for #733

* feat: Added code to resolve Divider page issue

* Console output replaced by LOGGERs as per review comments

* feat: replaced Console with Loggers

---------

Co-authored-by: Varaham <katchabi50@gmail.com>
Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* GetCurrentUserReactor (#818)

Adding GetCurrentUserReactor to return user info including if user is an admin.

* Python User Class (#819)

* fix: trimming properties read from smss; fix: logging commands before executing (#821)

* Updating getNodePoolsInfo() to parse and return zk info and models active actual (#822)

* feat: update get node pool information for zk info and models active actual

* feat: get remote model configs

* Add unit tests for package prerna\engine\impl\vector (#728)

* Create ChromaVectorDatabaseEngineUnitTests.java

* completed tests for ChromaVectorDatabaseEngine class

* [#604] test(unit): Created ChromaVectorDatabaseEngine unit tests

* [604] tests(unit) : Completed test cases for ChromaVectorDatabaseEngine; update File operations to nio operations in ChromaVectorDatabaseEngine.java

* [#604] tests(unit): added unit tests for all vector database engines and util classes in the prerna\engine\impl\vector package

* [604] test(unit): replaced creating file paths with string literals with java.nio Paths.resolve/Paths.get methods

---------

Co-authored-by: Maher Khalil <themaherkhalil@gmail.com>
Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* feat: adding to the return of getenginemetadata (#813)

* feat: adding to the return of getenginemetadata

* fix: removing throws

---------

Co-authored-by: Arash Afghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>

* 718 create a single reactor to search both engines and apps (#794)

* feat(engineProject): Initial commit

* chore: 718 create a single reactor to search both engines and apps

* chore: 718 create a single reactor to search both engines and apps

---------

Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>
Co-authored-by: Vijayaraghavareddy <pvijayaraghavareddy@deloitte.com>

* feat: update openai wrapper to handle multiple images (#832)

* feat: adding user room map (#840)

* feat: hiding side menu bar for non admins (#833)

* Side menu changes

* Review Comments fixed

* Flag is renamed in  Constants.java

* Review Comment fixed in Utility.java

* fix: cleaning up defaults and comments

---------

Co-authored-by: kunal0137 <kunal0137@gmail.com>

---------

Co-authored-by: Maher Khalil <themaherkhalil@gmail.com>
Co-authored-by: kunal0137 <kunal0137@gmail.com>
Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com>
Co-authored-by: ManjariYadav2310 <manjayadav@deloitte.com>
Co-authored-by: dpartika <dpartika@deloitte.com>
Co-authored-by: Raul Esquivel <resmas.work@gmail.com>
Co-authored-by: Pasupathi Muniyappan <pasupathi.muniyappan@kanini.com>
Co-authored-by: resmas-tx <131498457+resmas-tx@users.noreply.github.com>
Co-authored-by: AndrewRodddd <62724891+AndrewRodddd@users.noreply.github.com>
Co-authored-by: radkalyan <107957324+radkalyan@users.noreply.github.com>
Co-authored-by: samarthKharote <samarth.kharote@kanini.com>
Co-authored-by: Shubham Mahure <shubham.mahure@kanini.com>
Co-authored-by: rithvik-doshi <81876806+rithvik-doshi@users.noreply.github.com>
Co-authored-by: Mogillapalli Manoj kumar <86736340+Khumar23@users.noreply.github.com>
Co-authored-by: Jeff Vitunac <jvitunac@gmail.com>
Co-authored-by: pvijayaraghavareddy <pvijayaraghavareddy@WORKSPA-6QV71G7.us.deloitte.com>
Co-authored-by: Parth <parthpatel3@deloitte.com>
Co-authored-by: KT Space <119169984+Varaham@users.noreply.github.com>
Co-authored-by: Varaham <katchabi50@gmail.com>
Co-authored-by: ericgonzal8 <ericgonzalez8@deloitte.com>
Co-authored-by: Arash Afghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Vijayaraghavareddy <pvijayaraghavareddy@deloitte.com>
Co-authored-by: ammb-123 <ammb@deloitte.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants