Add unit tests for package prerna\engine\impl\vector

[ericgonzal8]

Description

created a unit test file for each file under the vector package

Changes Made

Unit tests added:

• AbstractVectorDatabaseUnitTests.java
• ChromaVectorDatabaseEngineUnitTests.java
• ElasticSearchRestVectorDatasbeEngineUnitTests.java
• FaissDatabaseEngineUnitTests.java
• MilvusVectorDatabaseEngineUnitTests.java
• MilvusVectorQueryFilterTranslationHelperUnitTests.java
• OpenSearchRestVectorDatabaseEngineUnitTests.java
• PGVectorDatabaseEngineUnitTests.java
• PGVectorQueryFilterTranslationHelperUnitTests.java
• PGVectorQueryMetaFilterTranslationHelperUnitTests.java
• PineConeVectorDatabaseEngineUnitTests.java
• RestVectorQueryFilterTranslationHelperUnitTests.java
• VectorDatabaseCSVRowUnitTests.java
• VectorDatabaseCSVTableUnitTests.java
• VectorDatabaseCSVWriterUnitTests.java
• VectorDatabaseUtilsUnitTests.java
• WeaviateVectorDatabaseEngineUnitTests.java

How to Test

• right click prerna.engine.impl.vector package in project explorer
• select Run As -> Junit Test

Notes

[github-actions]

@CodiumAI-Agent /describe

[github-actions]

@CodiumAI-Agent /review

[QodoAI-Agent]

Title

Add unit tests for package prerna\engine\impl\vector

---

User description

Description

created a unit test file for each file under the vector package

Changes Made

Unit tests added:

• AbstractVectorDatabaseUnitTests.java
• ChromaVectorDatabaseEngineUnitTests.java
• ElasticSearchRestVectorDatasbeEngineUnitTests.java
• FaissDatabaseEngineUnitTests.java
• MilvusVectorDatabaseEngineUnitTests.java
• MilvusVectorQueryFilterTranslationHelperUnitTests.java
• OpenSearchRestVectorDatabaseEngineUnitTests.java
• PGVectorDatabaseEngineUnitTests.java
• PGVectorQueryFilterTranslationHelperUnitTests.java
• PGVectorQueryMetaFilterTranslationHelperUnitTests.java
• PineConeVectorDatabaseEngineUnitTests.java
• RestVectorQueryFilterTranslationHelperUnitTests.java
• VectorDatabaseCSVRowUnitTests.java
• VectorDatabaseCSVTableUnitTests.java
• VectorDatabaseCSVWriterUnitTests.java
• VectorDatabaseUtilsUnitTests.java
• WeaviateVectorDatabaseEngineUnitTests.java

How to Test

• right click prerna.engine.impl.vector package in project explorer
• select Run As -> Junit Test

Notes

---

PR Type

Tests

---

Description

Add PGVectorDatabaseEngine unit tests
Add MilvusVectorDatabaseEngine unit tests
Add CSV table functionality tests
Add RestVectorQueryFilterTranslationHelper tests

---

Changes walkthrough 📝

	Relevant files
Tests	4 files PGVectorDatabaseEngineUnitTests.java Comprehensive PGVector engine tests                                            +1181/-0 MilvusVectorDatabaseEngineUnitTests.java Comprehensive Milvus engine tests                                                +942/-0  RestVectorQueryFilterTranslationHelperUnitTests.java REST vector query filter helper tests                                        +210/-0  VectorDatabaseCSVTableUnitTests.java CSV table logic unit tests                                                              +195/-0
Formatting	1 files ChromaVectorDatabaseEngine.java Add missing newline at EOF                                                              +1/-1
Additional files	13 files AbstractVectorDatabaseUnitTests.java +852/-0  ChromaVectorDatabaseEngineUnitTests.java +548/-0  ElasticSearchRestVectorDatasbeEngineUnitTests.java +899/-0  FaissDatabaseEngineUnitTests.java +757/-0  MilvusVectorQueryFilterTranslationHelperUnitTests.java +106/-0  OpenSearchRestVectorDatabaseEngineUnitTests.java +599/-0  PGVectorQueryFilterTranslationHelperUnitTests.java +109/-0  PGVectorQueryMetaFilterTranslationHelperUnitTests.java +77/-0    PineConeVectorDatabaseEngineUnitTests.java +662/-0  VectorDatabaseCSVRowUnitTests.java +68/-0    VectorDatabaseCSVWriterUnitTests.java +74/-0    VectorDatabaseUtilsUnitTests.java +59/-0    WeaviateVectorDatabaseEngineUnitTests.java +654/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

@CodiumAI-Agent /improve

[QodoAI-Agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Extra Brace There appears to be an extra closing brace at the end of the class, which may cause compilation errors or affect class structure. return VectorDatabaseTypeEnum.CHROMA; } } Typo in Class Name The helper class is referenced as MilvusVectorQueryFitlerTranslationHelper (typo "Fitler")—verify the class name matches the implementation. private MilvusVectorQueryFitlerTranslationHelper helper; private String tableName; @BeforeEach void setUp() { helper = new MilvusVectorQueryFitlerTranslationHelper(); tableName = "MILVUS_TABLE_NAME"; } Console Logging printDirContents method prints directory contents to stdout in tests, which may clutter test output—consider removing or replacing with proper assertions. private void printDirContents(Path path) { System.out.println(path.toAbsolutePath()); if (Files.isDirectory(path)) { try (DirectoryStream<Path> stream = Files.newDirectoryStream(path)) { for (Path entry : stream) { printDirContents(entry); } } catch (IOException e) { e.printStackTrace();

[QodoAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Provide correct mock type Provide the class argument to mock() so Mockito knows which type to create. test/prerna/engine/impl/vector/AbstractVectorDatabaseUnitTests.java [321] -VectorDatabaseCSVTable vectorCsvTableMock = mock(); +VectorDatabaseCSVTable vectorCsvTableMock = mock(VectorDatabaseCSVTable.class); Suggestion importance[1-10]: 8 __ Why: This ensures Mockito can create a mock of the correct type and prevents compilation errors.	Medium
	Write properties with proper delimiter Write the properties file using a standard delimiter or Properties.store(...) so the engine can load it reliably. test/prerna/engine/impl/vector/AbstractVectorDatabaseUnitTests.java [146-148] for (Entry<Object, Object> entry : testProps.entrySet()) { - lines.add(entry.getKey().toString() + " " + entry.getValue().toString()); + lines.add(entry.getKey() + "=" + entry.getValue()); } Suggestion importance[1-10]: 7 __ Why: Using '=' as a delimiter aligns with Properties.load expectations, ensuring the engine reads the file reliably.	Medium
	Use Path API for path building Use Path.resolve instead of manual string concatenation to build file paths for cross-platform compatibility test/prerna/engine/impl/vector/ElasticSearchRestVectorDatasbeEngineUnitTests.java [87-90] -String engineFolder = tempDir.toString() + "/" + Constants.VECTOR_FOLDER + "/" + SmssUtilities.getUniqueName(testEngineAlias, testEngine); -String schemaDir = engineFolder + "/schema"; -Path shemaDirPath = Paths.get(schemaDir); +Path engineBasePath = tempDir.resolve(Constants.VECTOR_FOLDER) + .resolve(SmssUtilities.getUniqueName(testEngineAlias, testEngine)); +String engineFolder = engineBasePath.toString(); +Path shemaDirPath = engineBasePath.resolve("schema"); Suggestion importance[1-10]: 5 __ Why: Using Path.resolve improves cross-platform compatibility and readability for building file paths.	Low
	Use generic matchers for embedding stub Stub the embeddings call with generic argument matchers (e.g. anyList()) instead of a specific new Vector instance to ensure the mock is invoked regardless of how the list is constructed test/prerna/engine/impl/vector/ElasticSearchRestVectorDatasbeEngineUnitTests.java [353] -when(modelEmbedder.embeddings(new Vector<String>(), insight, null)).thenReturn(outputMocked); +when(modelEmbedder.embeddings(anyList(), eq(insight), isNull())).thenReturn(outputMocked); Suggestion importance[1-10]: 5 __ Why: Replacing a concrete Vector instance with anyList matcher makes the mock more flexible and robust against implementation changes.	Low
	Use anyList() for neighbor stub Replace the exact Arrays.asList stub with a more flexible matcher (e.g. anyList()) so the mock triggers regardless of list implementation test/prerna/engine/impl/vector/ElasticSearchRestVectorDatasbeEngineUnitTests.java [563] -when(modelEmbedder.embeddings(Arrays.asList(new String[] {searchStatement}), insight, null)).thenReturn(responseMocked); +when(modelEmbedder.embeddings(anyList(), eq(insight), isNull())).thenReturn(responseMocked); Suggestion importance[1-10]: 5 __ Why: Using anyList matcher instead of concrete Arrays.asList streamlines the stub and avoids brittleness if list instantiation changes.	Low
General	Use ArrayList instead of Vector Replace usage of the legacy Vector class with ArrayList for better performance and readability. test/prerna/engine/impl/vector/AbstractVectorDatabaseUnitTests.java [145] -List<String> lines = new Vector<>(); +List<String> lines = new ArrayList<>(); Suggestion importance[1-10]: 3 __ Why: Replacing Vector with ArrayList improves performance and readability, although it has minimal impact on functionality.	Low

[EJV20]

What are you mocking here?

[ericgonzal8]

This is mocking a static method in VectorDatabaseCSVTable class that returns a new object of the same class. By returning a mock, all methods invoked on the mocked object have no effect, as desired.

[EJV20]

Please use Path to resolve location. The file separator "/" can change from windows to linux.

[ericgonzal8]

Updated all file path string literals to java.nio.Paths methods for file path creation

[EJV20]

good to go

[github-actions]

@CodiumAI-Agent /update_changelog

[QodoAI-Agent]

Changelog updates: 🔄

2025-05-19 *

Added

• Unit tests for all vector database engines and utility classes in the prerna.engine.impl.vector package.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'