Side menu changes by ammb-123 · Pull Request #833 · SEMOSS/Semoss

ammb-123 · 2025-05-19T14:05:39Z

Description

Flag is added to on/off the side menu in the AI CORE app

Changes Made

ADMIN_ONLY_VIEW_MENU_BAR flag added

How to Test

Login to the AI core app ,user can able to view the ai core page without side menu bar and catalog items .
Config api has the adminOnlyViewMenuBarFlag : true
Uploading AdminUser_updated.docx…

Notes

Monolith : SEMOSS/Monolith#129
Uploading AdminUser_updated.docx…

github-actions · 2025-05-19T14:05:51Z

@CodiumAI-Agent /describe

QodoAI-Agent · 2025-05-19T14:06:18Z

Title

Side menu changes

User description

Description

Flag is added to on/off the side menu in the AI CORE app

Changes Made

ADMIN_ONLY_VIEW_MENU_BAR flag added

How to Test

Login to the AI core app ,user can able to view the ai core page without side menu bar and catalog items .
Config api has the adminOnlyViewMenuBarFlag : true
Uploading AdminUser_updated.docx…

Notes

Monolith : SEMOSS/Monolith#129
Uploading AdminUser_updated.docx…

PR Type

Enhancement

Description

Add admin-only view menu bar flag
Add admin-only non-approved catalog item flag
Implement utility getters for new flags
Set default true values in configuration

Changes walkthrough 📝

Relevant files

Configuration changes

Constants.java `Introduce new admin-only constants` src/prerna/util/Constants.java Added `ADMIN_ONLY_VIEW_MENU_BAR` constant Added `ADMIN_ONLY_NON_APPROVED_PRODITEM` constant	+5/-1
RDF_Map.prop `Configure default admin flag properties` RDF_Map.prop Defined `ADMIN_ONLY_VIEW_MENU_BAR` default true Defined `ADMIN_ONLY_NON_APPROVED_PRODITEM` default true	+2/-0

Enhancement

Utility.java `Add utility methods for admin flags` src/prerna/util/Utility.java Added `getAdminOnlyViewMenuBarFlag()` method Added `getAdminOnlyNonAprrovedFlag()` method Default behavior returns true when unset	+28/-0

Need help?
Type /help how to ... in the comments thread for any questions about PR-Agent usage.
Check out the documentation for more information.

github-actions · 2025-05-19T14:06:37Z

@CodiumAI-Agent /review

QodoAI-Agent · 2025-05-19T14:07:21Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Inconsistent Formatting Comment and constant declarations around the new flags have inconsistent indentation and alignment. Align comments and fields to match existing style. // default AdminFlag public static final String ADMIN_ONLY_VIEW_MENU_BAR = "ADMIN_ONLY_VIEW_MENU_BAR"; // default AdminFlag nonapproved catalog public static final String ADMIN_ONLY_NON_APPROVED_PRODITEM = "ADMIN_ONLY_NON_APPROVED_PRODITEM"; Typo in Method Name The method `getAdminOnlyNonAprrovedFlag` contains a typo ("Aprroved") and the constant `ADMIN_ONLY_NON_APPROVED_PRODITEM` may be misspelled. Rename to `getAdminOnlyNonApprovedFlag` and verify constant naming. public static boolean getAdminOnlyNonAprrovedFlag() { String nonApprovedFlag = Utility.getDIHelperProperty(Constants.ADMIN_ONLY_NON_APPROVED_PRODITEM); if(nonApprovedFlag == null) { // default option is true return true; } return Boolean.parseBoolean(nonApprovedFlag); } Default Flag Behavior Both flag methods default to `true` when the property is null. Confirm this default enables the desired behavior and document it clearly in Javadoc. public static boolean getAdminOnlyViewMenuBarFlag() { String coreFlag = Utility.getDIHelperProperty(Constants.ADMIN_ONLY_VIEW_MENU_BAR); if(coreFlag == null) { // default option is true return true; } return Boolean.parseBoolean(coreFlag); }

github-actions · 2025-05-19T14:07:23Z

@CodiumAI-Agent /improve

QodoAI-Agent · 2025-05-19T14:08:42Z

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Trim whitespace before parsing Trim whitespace from `coreFlag` before parsing to prevent false negatives due to leading/trailing spaces. Apply `trim()` on the string before `Boolean.parseBoolean`. src/prerna/util/Utility.java [6151] -return Boolean.parseBoolean(coreFlag); +return Boolean.parseBoolean(coreFlag.trim()); Suggestion importance[1-10]: 5 __ Why: Trimming whitespace prevents `Boolean.parseBoolean` from misinterpreting values with leading or trailing spaces, improving reliability.	Low
General	Fix method name typo Correct the typo in the method name `getAdminOnlyNonAprrovedFlag` to `getAdminOnlyNonApprovedFlag` for consistent spelling and better clarity, and update all references accordingly. src/prerna/util/Utility.java [6159] -public static boolean getAdminOnlyNonAprrovedFlag() { +public static boolean getAdminOnlyNonApprovedFlag() { Suggestion importance[1-10]: 5 __ Why: Correcting the misspelling in `getAdminOnlyNonAprrovedFlag` enhances clarity and consistency with the constant naming.	Low

github-actions · 2025-05-20T18:05:55Z

@CodiumAI-Agent /update_changelog

QodoAI-Agent · 2025-05-20T18:06:23Z

Changelog updates: 🔄

2025-05-20 *

Added

ADMIN_ONLY_VIEW_MENU_BAR flag and utility for admin-only side menu toggle

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

* fix(python): handle eval when it is a single line execution but there is string input with space (#756) * Update Dockerfile.tomcat (#757) * fix: tomcat builder setting env var * fix: updating tomcat to 9.0.104 * Update Dockerfile.ubuntu22.04 * Update Dockerfile.ubuntu22.04 * Update Dockerfile.ubuntu22.04 * feat: creating KubernetesModelScaler class (#763) * Update Dockerfile.ubuntu22.04 * feat: adding ability to attach a file to a vector db source (#736) * Added AttachSourceToVectorDbReactor for uploading pdf file to an existing csv file and modified VectorFileDownloadReactor * fix: proper return for the download and matching the reactor name * fix: error for downloading single file vs multiple; error for copyToDirectory instead of copyFile * chore: renaming so reactor matches VectorFileDownload --------- Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> * Update Dockerfile.ubuntu22.04 * Update ubuntu2204.yml * Update ubuntu2204.yml * Update ubuntu2204_cuda.yml * Update Dockerfile.nvidia.cuda.12.5.1.ubuntu22.04 * Update ubuntu2204_cuda.yml * Update ubuntu2204.yml * feat: exposing tools calling through models (#764) * 587 unit test for prernadsutil (#654) * test(unit): unit tests for the prerna.util.ds package * test(unit): unit tests for the prerna.util.ds.flatfile package * test(unit): removed reflections, added paraquet tests * test(unit): unit tests for the prerna.util.ds package * test(unit): unit tests for the prerna.util.ds.flatfile package * test(unit): removed reflections, added paraquet tests * Update ubuntu2204.yml * Update ubuntu2204.yml * Update ubuntu2204.yml * fix: update pipeline docker buildx version * fix: ignore buildx * fix: adjusting pipeline for cuda * feat: switching dynamic sas to default false (#766) * fix: changes to account for version 2.0.0 of pyjarowinkler (#769) * chore: using 'Py' instead of 'py' to be consistent (#770) * feat: full ast parsing of code to return evaluation of the last expression (#771) * Python Deterministic Token Trimming for Message Truncation (#765) * feat: deterministic-token-trimming * feat: modifying logic such that system prompt is second to last message for truncation --------- Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> * fix: added date added column to enginepermission table (#768) * fix: add docker-in-docker container to run on sef-hosted runner (#773) Co-authored-by: Raul Esquivel <resmas.work@gmail.com> * fix: properly passing in the parameters from kwargs/smss into model limits calculation (#774) * fix: removing legacy param from arguments (#777) * fix: Fix docker cache build issue (#778) * adding no cache * adding no cache * feat: Adding Semantic Text Splitting & Token Text Splitting (#720) * [696] - build - Add chonky semantic text splitting - Added the function for chonky semantic text splitting and integrated with existing flow. * [696] - build - Add chonky semantic text splitting - Updated the code * [696] - build - Add chonky semantic text splitting - Updated the code comments * feat: adding reactor support through java * feat: updating pyproject.toml with chonky package * feat: check for default chunking method in smss * [696] - feat - Add chonku semantic text splitting - Resolved the conflicts * [696] - feat - Add chonky semantic text splitting - Organized the code. * feat: adding chunking by tokens and setting as default * updating comments on chunking strategies --------- Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com> Co-authored-by: kunal0137 <kunal0137@gmail.com> * feat: allowing for tools message in full prompt (#780) * UPDATE ::: Add docker in docker Dockerfiler (#784) * add docker in docker Dockerfile * Update Dockerfile.dind Remove python and tomcat arguments from Dockerfile * fix: remove-paddle-ocr (#786) * [#595] test(unit): adds unit test for prerna.engine.impl.model.kserve Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * feat: Tag semoss image (#789) * adding changes for non-release docker build * adding non-release build logic to cuda-semoss builder * updating push branches * fix: branch names on docker builds * fix: branch names on docker builds cuda * fix: adding push condition - change to pyproject toml file; adding event input vars to env vars (#790) * fix: python builder toml file change (#792) * fix: Catch errors when calling pixels from Python (#787) Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com> * Creating db links between engines and default apps (#693) * create db links between engine and default app * Rename column APPID to TOOL_APP * feat: add database_tool_app to getUserEngineList --------- Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com> * Adding sort options to the myengines reactor (#479) * added sort feature to MyEnginesReactor and genericized reactor imports * formatting * overloading method * validate sortList --------- Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * feat: cleaning up unused imports in MyEngine reactor (#793) * feat: Create Enum projectTemplate and update CreateAppFromTemplateReactor to accept existing appID for cloning applications (#621) Co-authored-by: kunal0137 <kunal0137@gmail.com> * Update GetEngineUsageReactor.java (#417) Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * Issue 596: Adds Unit Tests for prerna/engine/impl/model/responses and workers (#727) * [#596] test(unit): adds unit tests * fix: implements ai-agents suggestions --------- Co-authored-by: Jeff Vitunac <jvitunac@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * 609 implement native blob storage for azure gcp and aws (#674) * Initial commit : implementation for azure blob storage * added dependency for azure in pom.xml * update logic to fetch the metadata from list details * changed functionality from listing containers to listing files within a selected container * initial commit for google cloud storage implementation * added field contant in enum class and removed unused method * add methods to parse comma-separated local and cloud paths * add methods to parse comma-separated local and cloud paths * implementation for aws s3 bucket * normalize container prefix path * merged all: implementation for azure, aws and gcp * refactor(storage): replace manual path normalization with normalizePath from Utility class --------- Co-authored-by: pvijayaraghavareddy <pvijayaraghavareddy@WORKSPA-6QV71G7.us.deloitte.com> Co-authored-by: Parth <parthpatel3@deloitte.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * Get Node Pool Information for Remote Models (#806) * 590 unit test for prernaengineimpl (#808) * test(unit): update to filesystems hijacking for testing files * test: start of unit tests for abstract database engine * test(unit): added unit test for prerna.engine.impl * test(unit): finsihed tests for prerna.engine.impl * test(unit): adding back unused assignment --------- Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * Creating WordCountTokenizer Class (#802) * feat: creating word count tokenizer class && falling back to word count tokenizer if tiktok fails * feat: updating comment * feat: setting default chunking method as recursive (#810) * Unit tests fixes and Unit test Class file location updates (#812) * test(unit): moved tests to correct packages * test(unit): fixed a couple of unit tests * VectorDatabaseQueryReactor: output divider value for word doc chunks always 1 (#804) * Code implementation for #733 * feat: Added code to resolve Divider page issue * Console output replaced by LOGGERs as per review comments * feat: replaced Console with Loggers --------- Co-authored-by: Varaham <katchabi50@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * GetCurrentUserReactor (#818) Adding GetCurrentUserReactor to return user info including if user is an admin. * Python User Class (#819) * fix: trimming properties read from smss; fix: logging commands before executing (#821) * Updating getNodePoolsInfo() to parse and return zk info and models active actual (#822) * feat: update get node pool information for zk info and models active actual * feat: get remote model configs * Add unit tests for package prerna\engine\impl\vector (#728) * Create ChromaVectorDatabaseEngineUnitTests.java * completed tests for ChromaVectorDatabaseEngine class * [#604] test(unit): Created ChromaVectorDatabaseEngine unit tests * [604] tests(unit) : Completed test cases for ChromaVectorDatabaseEngine; update File operations to nio operations in ChromaVectorDatabaseEngine.java * [#604] tests(unit): added unit tests for all vector database engines and util classes in the prerna\engine\impl\vector package * [604] test(unit): replaced creating file paths with string literals with java.nio Paths.resolve/Paths.get methods --------- Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * feat: adding to the return of getenginemetadata (#813) * feat: adding to the return of getenginemetadata * fix: removing throws --------- Co-authored-by: Arash Afghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * 718 create a single reactor to search both engines and apps (#794) * feat(engineProject): Initial commit * chore: 718 create a single reactor to search both engines and apps * chore: 718 create a single reactor to search both engines and apps --------- Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> Co-authored-by: Vijayaraghavareddy <pvijayaraghavareddy@deloitte.com> * feat: update openai wrapper to handle multiple images (#832) * feat: adding user room map (#840) * feat: hiding side menu bar for non admins (#833) * Side menu changes * Review Comments fixed * Flag is renamed in Constants.java * Review Comment fixed in Utility.java * fix: cleaning up defaults and comments --------- Co-authored-by: kunal0137 <kunal0137@gmail.com> --------- Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> Co-authored-by: kunal0137 <kunal0137@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> Co-authored-by: ManjariYadav2310 <manjayadav@deloitte.com> Co-authored-by: dpartika <dpartika@deloitte.com> Co-authored-by: Raul Esquivel <resmas.work@gmail.com> Co-authored-by: Pasupathi Muniyappan <pasupathi.muniyappan@kanini.com> Co-authored-by: resmas-tx <131498457+resmas-tx@users.noreply.github.com> Co-authored-by: AndrewRodddd <62724891+AndrewRodddd@users.noreply.github.com> Co-authored-by: radkalyan <107957324+radkalyan@users.noreply.github.com> Co-authored-by: samarthKharote <samarth.kharote@kanini.com> Co-authored-by: Shubham Mahure <shubham.mahure@kanini.com> Co-authored-by: rithvik-doshi <81876806+rithvik-doshi@users.noreply.github.com> Co-authored-by: Mogillapalli Manoj kumar <86736340+Khumar23@users.noreply.github.com> Co-authored-by: Jeff Vitunac <jvitunac@gmail.com> Co-authored-by: pvijayaraghavareddy <pvijayaraghavareddy@WORKSPA-6QV71G7.us.deloitte.com> Co-authored-by: Parth <parthpatel3@deloitte.com> Co-authored-by: KT Space <119169984+Varaham@users.noreply.github.com> Co-authored-by: Varaham <katchabi50@gmail.com> Co-authored-by: ericgonzal8 <ericgonzalez8@deloitte.com> Co-authored-by: Arash Afghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Vijayaraghavareddy <pvijayaraghavareddy@deloitte.com> Co-authored-by: ammb-123 <ammb@deloitte.com>

Side menu changes

75bf402

ammb-123 and others added 6 commits May 20, 2025 12:25

Review Comments fixed

d82a55a

Flag is renamed in Constants.java

bef3b39

Review Comment fixed in Utility.java

73d0698

Merge branch 'dev' into ammu_side_menu_change

0ae451e

fix: cleaning up defaults and comments

80f091f

Merge branch 'dev' into ammu_side_menu_change

7d15f18

kunal0137 merged commit 5e17561 into dev May 20, 2025
3 checks passed

kunal0137 deleted the ammu_side_menu_change branch May 20, 2025 18:05

anurag91jain mentioned this pull request Jun 9, 2025

side menu changes #816

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Side menu changes#833

Side menu changes#833
kunal0137 merged 7 commits intodevfrom
ammu_side_menu_change

ammb-123 commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

QodoAI-Agent commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

QodoAI-Agent commented May 19, 2025

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

QodoAI-Agent commented May 19, 2025

Uh oh!

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

QodoAI-Agent commented May 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ammb-123 commented May 19, 2025

Description

Changes Made

How to Test

Notes

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

QodoAI-Agent commented May 19, 2025

Title

User description

Description

Changes Made

How to Test

Notes

PR Type

Description

Changes walkthrough 📝

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

QodoAI-Agent commented May 19, 2025

PR Reviewer Guide 🔍

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

QodoAI-Agent commented May 19, 2025

PR Code Suggestions ✨

Uh oh!

Uh oh!

github-actions bot commented May 20, 2025

Uh oh!

QodoAI-Agent commented May 20, 2025

2025-05-20 *

Added

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants