590 unit test for prernaengineimpl

[EJV20]

Unit tests for prerna.engine.impl package.

[github-actions]

@CodiumAI-Agent /describe

[github-actions]

@CodiumAI-Agent /review

[QodoAI-Agent]

Title

590 unit test for prernaengineimpl

---

User description

Unit tests for prerna.engine.impl package.

---

PR Type

Tests, Enhancement

---

Description

• Consolidate exception handling in DatabaseEngine.

• Fix database zone id log typo.

• Cleanup exception message spacing in SmssUtilities.

• Add extensive unit tests for engine implementations.

---

Changes walkthrough 📝

	Relevant files
Enhancement	1 files AbstractDatabaseEngine.java Consolidate exception handling and fix zone id typo            +4/-11
Formatting	1 files SmssUtilities.java Cleanup exception message formatting in SmssUtilities        +1/-1
Tests	7 files AbstractDatabaseEngineUnitTests.java Add unit tests for AbstractDatabaseEngine                                +1342/-0 CaseInsensitivePropertiesUnitTests.java Add tests for CaseInsensitiveProperties                                    +90/-0    InsightAdministratorUnitTests.java Add unit tests for InsightAdministrator                                    +423/-0  InsightCacherUnitTests.java Add tests for InsightCacher behavior                                          +141/-0  SaveInsightIntoWorkspaceUnitTests.java Add tests for SaveInsightIntoWorkspace                                      +107/-0  SmssUtilitiesUnitTests.java Add comprehensive tests for SmssUtilities                                +509/-0  AdminGetEngineSMSSReactorUnitTests.java Update imports and Jimfs usage in reactor tests                    +9/-20

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

@CodiumAI-Agent /improve

[QodoAI-Agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Reflection Error Handling Consolidating multiple exception types in doAction may swallow underlying invocation failures and return null silently. Consider rethrowing or handling InvocationTargetException explicitly to avoid silent errors when the reflected method fails. try { method = this.getClass().getMethod(methodName, args.getClass()); ret = method.invoke(this, params); } catch (SecurityException | NoSuchMethodException | IllegalArgumentException | IllegalAccessException | InvocationTargetException e) { classLogger.error(Constants.STACKTRACE, e); } return ret; } Missing Mock Setup The reactor unit tests mock FileSystems.getDefault and create directories in Jimfs, but do not mock Utility.normalizePath. This may cause path resolution mismatches. Ensure the normalization step is handled in the test setup. MockedStatic<FileSystems> fss = Mockito.mockStatic(FileSystems.class)) { SecurityAdminUtils s = mock(SecurityAdminUtils.class); sau.when(() -> SecurityAdminUtils.getInstance(user)).thenReturn(s); IEngine engine = mock(IEngine.class); utility.when(() -> Utility.getEngine("id")).thenReturn(engine); when(engine.getSmssFilePath()).thenReturn("dir"); fss.when(FileSystems::getDefault).thenReturn(fs); Files.createDirectory(fs.getPath("dir"));

[QodoAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Use fully-qualified DATA_FILE constant Avoid relying on an unimported class constant by using its fully-qualified name. This change prevents a compilation error without adding an import. test/prerna/engine/impl/SmssUtilitiesUnitTests.java [213] -prop.setProperty(AbstractDatabaseEngine.DATA_FILE, "@BaseFolder@/db/@ENGINE@/data.txt"); +prop.setProperty(prerna.engine.impl.AbstractDatabaseEngine.DATA_FILE, "@BaseFolder@/db/@ENGINE@/data.txt"); Suggestion importance[1-10]: 4 __ Why: The code references AbstractDatabaseEngine.DATA_FILE without importing AbstractDatabaseEngine, causing a compile error; fully qualifying the class fixes this with minimal impact.	Low
	Fully-qualify Utility in mockStatic Reference the Utility class by its full package path to avoid missing import errors. This lets the mockStatic call compile without adding a new import. test/prerna/unit/auth/utils/reactors/admin/AdminGetEngineSMSSReactorUnitTests.java [117] -MockedStatic<Utility> utility = Mockito.mockStatic(Utility.class); +MockedStatic<prerna.util.Utility> utility = Mockito.mockStatic(prerna.util.Utility.class); Suggestion importance[1-10]: 4 __ Why: The test mocks Utility but lacks its import, so using prerna.util.Utility prevents missing import errors with a low-impact change.	Low

[github-actions]

@CodiumAI-Agent /update_changelog