Issue 596: Adds Unit Tests for prerna/engine/impl/model/responses and workers by AndrewRodddd · Pull Request #727 · SEMOSS/Semoss

AndrewRodddd · 2025-04-23T19:47:44Z

Description

Changes Made

How to Test

Steps to reproduce/test the behavior
Expected outcomes

Notes

…s-issue-596

github-actions · 2025-04-23T19:47:53Z

@CodiumAI-Agent /describe

QodoAI-Agent · 2025-04-23T19:48:32Z

Title

Issue 596: Adds Unit Tests for prerna/engine/impl/model/responses and workers

User description

Description

Changes Made

How to Test

Steps to reproduce/test the behavior
Expected outcomes

Notes

PR Type

Tests

Description

Add unit tests for various response models parsing
Cover JSON scenarios, error handling, toMap methods
Validate token counts across all response classes
Add worker logging flow tests in ModelEngineInferenceLogsWorker

Changes walkthrough 📝

Relevant files

Tests

9 files

AbstractModelEngineResponseUnitTests.java `Test AbstractModelEngineResponse getters and mapping`	+54/-0
AskImageModelEngineResponseUnitTests.java `Test AskImageModelEngineResponse parsing logic`	+143/-0
AskModelEngineResponseUnitTests.java `Test AskModelEngineResponse message handling`	+171/-0
AskStringModelEngineResponseUnitTests.java `Test AskStringModelEngineResponse JSON parsing`	+65/-0
AskToolModelEngineResponseUnitTests.java `Test AskToolModelEngineResponse formatting and args`	+93/-0
EmbeddingsModelEngineResponseUnitTests.java `Test EmbeddingsModelEngineResponse parsing and errors`	+158/-0
InstructModelEngineResponseUnitTests.java `Test InstructModelEngineResponse mapping and errors`	+74/-0
NerModelEngineResponseUnitTests.java `Test NerModelEngineResponse JSON handling`	+80/-0
ModelEngineInferenceLogsWorkerUnitTests.java `Test ModelEngineInferenceLogsWorker logging logic`	+540/-0

Need help?
Type /help how to ... in the comments thread for any questions about PR-Agent usage.
Check out the documentation for more information.

github-actions · 2025-04-23T19:48:39Z

@CodiumAI-Agent /review

github-actions · 2025-04-23T19:49:24Z

@CodiumAI-Agent /improve

QodoAI-Agent · 2025-04-23T19:49:31Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Assertion Key Mismatch The test compares toMap() entries using key "getNumberOfTokensInPrompt" instead of the likely correct "numberOfTokensInPrompt", which will cause assertion failures. assertEquals(map.get("response"), abs.toMap().get("response")); assertEquals(map.get("numberOfTokensInPrompt"), abs.toMap().get("getNumberOfTokensInPrompt")); assertEquals(map.get("numberOfTokensInResponse"), abs.toMap().get("numberOfTokensInResponse")); Uninitialized Reactor The tests invoke reactor.getKServeImageResponse(...) but `reactor` is never instantiated or mocked in setUp, leading to NullPointerExceptions. AskImageModelEngineResponse obj = reactor.getKServeImageResponse(jsonObj); Raw Type Usage Collections are created using raw types (e.g., new HashMap()), which generates unchecked warnings and reduces type safety. Use parameterized types with diamond operators instead. Map<String, Object> map = new HashMap();

QodoAI-Agent · 2025-04-23T19:50:36Z

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Fix incorrect map key in assertion Use the correct map key for the prompt token count instead of "getNumberOfTokensInPrompt" test/prerna/engine/impl/model/responses/AbstractModelEngineResponseUnitTests.java [50] -assertEquals(map.get("numberOfTokensInPrompt"), abs.toMap().get("getNumberOfTokensInPrompt")); +assertEquals(map.get("numberOfTokensInPrompt"), abs.toMap().get("numberOfTokensInPrompt")); Suggestion importance[1-10]: 8 __ Why: The test uses the wrong key "getNumberOfTokensInPrompt" when the toMap() likely uses "numberOfTokensInPrompt", so correcting this is necessary for the assertion to pass.	Medium
Possible issue	Prevent NullPointerException on reactor Initialize `reactor` or call `fromJson` statically so `reactor` is not null when invoking the method test/prerna/engine/impl/model/responses/AskStringModelEngineResponseUnitTests.java [25] +reactor = new AskStringModelEngineResponse("", 0, 0); AskStringModelEngineResponse ans = reactor.fromJson(null); Suggestion importance[1-10]: 7 __ Why: Instantiating reactor before calling fromJson(null) avoids a NullPointerException in the test and aligns with the class’s available constructors.	Medium

test/prerna/engine/impl/model/responses/AbstractModelEngineResponseUnitTests.java

test/prerna/engine/impl/model/responses/AskModelEngineResponseUnitTests.java

github-actions · 2025-05-09T12:05:04Z

@CodiumAI-Agent /update_changelog

QodoAI-Agent · 2025-05-09T12:05:38Z

Changelog updates: 🔄

2025-05-09

Added

Comprehensive unit tests for model response implementations
Unit tests for inference logs worker functionality

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

* fix(python): handle eval when it is a single line execution but there is string input with space (#756) * Update Dockerfile.tomcat (#757) * fix: tomcat builder setting env var * fix: updating tomcat to 9.0.104 * Update Dockerfile.ubuntu22.04 * Update Dockerfile.ubuntu22.04 * Update Dockerfile.ubuntu22.04 * feat: creating KubernetesModelScaler class (#763) * Update Dockerfile.ubuntu22.04 * feat: adding ability to attach a file to a vector db source (#736) * Added AttachSourceToVectorDbReactor for uploading pdf file to an existing csv file and modified VectorFileDownloadReactor * fix: proper return for the download and matching the reactor name * fix: error for downloading single file vs multiple; error for copyToDirectory instead of copyFile * chore: renaming so reactor matches VectorFileDownload --------- Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> * Update Dockerfile.ubuntu22.04 * Update ubuntu2204.yml * Update ubuntu2204.yml * Update ubuntu2204_cuda.yml * Update Dockerfile.nvidia.cuda.12.5.1.ubuntu22.04 * Update ubuntu2204_cuda.yml * Update ubuntu2204.yml * feat: exposing tools calling through models (#764) * 587 unit test for prernadsutil (#654) * test(unit): unit tests for the prerna.util.ds package * test(unit): unit tests for the prerna.util.ds.flatfile package * test(unit): removed reflections, added paraquet tests * test(unit): unit tests for the prerna.util.ds package * test(unit): unit tests for the prerna.util.ds.flatfile package * test(unit): removed reflections, added paraquet tests * Update ubuntu2204.yml * Update ubuntu2204.yml * Update ubuntu2204.yml * fix: update pipeline docker buildx version * fix: ignore buildx * fix: adjusting pipeline for cuda * feat: switching dynamic sas to default false (#766) * fix: changes to account for version 2.0.0 of pyjarowinkler (#769) * chore: using 'Py' instead of 'py' to be consistent (#770) * feat: full ast parsing of code to return evaluation of the last expression (#771) * Python Deterministic Token Trimming for Message Truncation (#765) * feat: deterministic-token-trimming * feat: modifying logic such that system prompt is second to last message for truncation --------- Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> * fix: added date added column to enginepermission table (#768) * fix: add docker-in-docker container to run on sef-hosted runner (#773) Co-authored-by: Raul Esquivel <resmas.work@gmail.com> * fix: properly passing in the parameters from kwargs/smss into model limits calculation (#774) * fix: removing legacy param from arguments (#777) * fix: Fix docker cache build issue (#778) * adding no cache * adding no cache * feat: Adding Semantic Text Splitting & Token Text Splitting (#720) * [696] - build - Add chonky semantic text splitting - Added the function for chonky semantic text splitting and integrated with existing flow. * [696] - build - Add chonky semantic text splitting - Updated the code * [696] - build - Add chonky semantic text splitting - Updated the code comments * feat: adding reactor support through java * feat: updating pyproject.toml with chonky package * feat: check for default chunking method in smss * [696] - feat - Add chonku semantic text splitting - Resolved the conflicts * [696] - feat - Add chonky semantic text splitting - Organized the code. * feat: adding chunking by tokens and setting as default * updating comments on chunking strategies --------- Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com> Co-authored-by: kunal0137 <kunal0137@gmail.com> * feat: allowing for tools message in full prompt (#780) * UPDATE ::: Add docker in docker Dockerfiler (#784) * add docker in docker Dockerfile * Update Dockerfile.dind Remove python and tomcat arguments from Dockerfile * fix: remove-paddle-ocr (#786) * [#595] test(unit): adds unit test for prerna.engine.impl.model.kserve Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * feat: Tag semoss image (#789) * adding changes for non-release docker build * adding non-release build logic to cuda-semoss builder * updating push branches * fix: branch names on docker builds * fix: branch names on docker builds cuda * fix: adding push condition - change to pyproject toml file; adding event input vars to env vars (#790) * fix: python builder toml file change (#792) * fix: Catch errors when calling pixels from Python (#787) Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com> * Creating db links between engines and default apps (#693) * create db links between engine and default app * Rename column APPID to TOOL_APP * feat: add database_tool_app to getUserEngineList --------- Co-authored-by: Weiler, Ryan <ryanweiler92@gmail.com> * Adding sort options to the myengines reactor (#479) * added sort feature to MyEnginesReactor and genericized reactor imports * formatting * overloading method * validate sortList --------- Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * feat: cleaning up unused imports in MyEngine reactor (#793) * feat: Create Enum projectTemplate and update CreateAppFromTemplateReactor to accept existing appID for cloning applications (#621) Co-authored-by: kunal0137 <kunal0137@gmail.com> * Update GetEngineUsageReactor.java (#417) Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * Issue 596: Adds Unit Tests for prerna/engine/impl/model/responses and workers (#727) * [#596] test(unit): adds unit tests * fix: implements ai-agents suggestions --------- Co-authored-by: Jeff Vitunac <jvitunac@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * 609 implement native blob storage for azure gcp and aws (#674) * Initial commit : implementation for azure blob storage * added dependency for azure in pom.xml * update logic to fetch the metadata from list details * changed functionality from listing containers to listing files within a selected container * initial commit for google cloud storage implementation * added field contant in enum class and removed unused method * add methods to parse comma-separated local and cloud paths * add methods to parse comma-separated local and cloud paths * implementation for aws s3 bucket * normalize container prefix path * merged all: implementation for azure, aws and gcp * refactor(storage): replace manual path normalization with normalizePath from Utility class --------- Co-authored-by: pvijayaraghavareddy <pvijayaraghavareddy@WORKSPA-6QV71G7.us.deloitte.com> Co-authored-by: Parth <parthpatel3@deloitte.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * Get Node Pool Information for Remote Models (#806) * 590 unit test for prernaengineimpl (#808) * test(unit): update to filesystems hijacking for testing files * test: start of unit tests for abstract database engine * test(unit): added unit test for prerna.engine.impl * test(unit): finsihed tests for prerna.engine.impl * test(unit): adding back unused assignment --------- Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * Creating WordCountTokenizer Class (#802) * feat: creating word count tokenizer class && falling back to word count tokenizer if tiktok fails * feat: updating comment * feat: setting default chunking method as recursive (#810) * Unit tests fixes and Unit test Class file location updates (#812) * test(unit): moved tests to correct packages * test(unit): fixed a couple of unit tests * VectorDatabaseQueryReactor: output divider value for word doc chunks always 1 (#804) * Code implementation for #733 * feat: Added code to resolve Divider page issue * Console output replaced by LOGGERs as per review comments * feat: replaced Console with Loggers --------- Co-authored-by: Varaham <katchabi50@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * GetCurrentUserReactor (#818) Adding GetCurrentUserReactor to return user info including if user is an admin. * Python User Class (#819) * fix: trimming properties read from smss; fix: logging commands before executing (#821) * Updating getNodePoolsInfo() to parse and return zk info and models active actual (#822) * feat: update get node pool information for zk info and models active actual * feat: get remote model configs * Add unit tests for package prerna\engine\impl\vector (#728) * Create ChromaVectorDatabaseEngineUnitTests.java * completed tests for ChromaVectorDatabaseEngine class * [#604] test(unit): Created ChromaVectorDatabaseEngine unit tests * [604] tests(unit) : Completed test cases for ChromaVectorDatabaseEngine; update File operations to nio operations in ChromaVectorDatabaseEngine.java * [#604] tests(unit): added unit tests for all vector database engines and util classes in the prerna\engine\impl\vector package * [604] test(unit): replaced creating file paths with string literals with java.nio Paths.resolve/Paths.get methods --------- Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * feat: adding to the return of getenginemetadata (#813) * feat: adding to the return of getenginemetadata * fix: removing throws --------- Co-authored-by: Arash Afghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> * 718 create a single reactor to search both engines and apps (#794) * feat(engineProject): Initial commit * chore: 718 create a single reactor to search both engines and apps * chore: 718 create a single reactor to search both engines and apps --------- Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> Co-authored-by: Vijayaraghavareddy <pvijayaraghavareddy@deloitte.com> * feat: update openai wrapper to handle multiple images (#832) * feat: adding user room map (#840) * feat: hiding side menu bar for non admins (#833) * Side menu changes * Review Comments fixed * Flag is renamed in Constants.java * Review Comment fixed in Utility.java * fix: cleaning up defaults and comments --------- Co-authored-by: kunal0137 <kunal0137@gmail.com> --------- Co-authored-by: Maher Khalil <themaherkhalil@gmail.com> Co-authored-by: kunal0137 <kunal0137@gmail.com> Co-authored-by: Ryan Weiler <ryanweiler92@gmail.com> Co-authored-by: ManjariYadav2310 <manjayadav@deloitte.com> Co-authored-by: dpartika <dpartika@deloitte.com> Co-authored-by: Raul Esquivel <resmas.work@gmail.com> Co-authored-by: Pasupathi Muniyappan <pasupathi.muniyappan@kanini.com> Co-authored-by: resmas-tx <131498457+resmas-tx@users.noreply.github.com> Co-authored-by: AndrewRodddd <62724891+AndrewRodddd@users.noreply.github.com> Co-authored-by: radkalyan <107957324+radkalyan@users.noreply.github.com> Co-authored-by: samarthKharote <samarth.kharote@kanini.com> Co-authored-by: Shubham Mahure <shubham.mahure@kanini.com> Co-authored-by: rithvik-doshi <81876806+rithvik-doshi@users.noreply.github.com> Co-authored-by: Mogillapalli Manoj kumar <86736340+Khumar23@users.noreply.github.com> Co-authored-by: Jeff Vitunac <jvitunac@gmail.com> Co-authored-by: pvijayaraghavareddy <pvijayaraghavareddy@WORKSPA-6QV71G7.us.deloitte.com> Co-authored-by: Parth <parthpatel3@deloitte.com> Co-authored-by: KT Space <119169984+Varaham@users.noreply.github.com> Co-authored-by: Varaham <katchabi50@gmail.com> Co-authored-by: ericgonzal8 <ericgonzalez8@deloitte.com> Co-authored-by: Arash Afghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Vijayaraghavareddy <pvijayaraghavareddy@deloitte.com> Co-authored-by: ammb-123 <ammb@deloitte.com>

AndrewRodddd added 2 commits April 23, 2025 15:39

[#596] test(unit): adds unit tests

7339943

Merge branch 'dev' of https://github.com/SEMOSS/Semoss into unit-test…

4b97eb4

…s-issue-596

AndrewRodddd requested a review from EJV20 April 23, 2025 19:47

AndrewRodddd self-assigned this Apr 23, 2025

AndrewRodddd linked an issue Apr 23, 2025 that may be closed by this pull request

Unit test for prerna.engine.impl.model.responses and prerna.engine.impl.model.workers #596

Closed

fix: implements ai-agents suggestions

6e9209d

EJV20 requested changes May 8, 2025

View reviewed changes

test/prerna/engine/impl/model/responses/AbstractModelEngineResponseUnitTests.java Show resolved Hide resolved

test/prerna/engine/impl/model/responses/AskModelEngineResponseUnitTests.java Show resolved Hide resolved

EJV20 approved these changes May 8, 2025

View reviewed changes

EJV20 and others added 2 commits May 8, 2025 13:50

Merge branch 'dev' into unit-tests-issue-596

1f77917

Merge branch 'dev' into unit-tests-issue-596

e7269e0

ryanweiler92 merged commit 71fd50e into dev May 9, 2025
3 checks passed

ryanweiler92 deleted the unit-tests-issue-596 branch May 9, 2025 12:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 596: Adds Unit Tests for prerna/engine/impl/model/responses and workers#727

Issue 596: Adds Unit Tests for prerna/engine/impl/model/responses and workers#727
ryanweiler92 merged 5 commits intodevfrom
unit-tests-issue-596

AndrewRodddd commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

QodoAI-Agent commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

QodoAI-Agent commented Apr 23, 2025

Uh oh!

QodoAI-Agent commented Apr 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

QodoAI-Agent commented May 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AndrewRodddd commented Apr 23, 2025

Description

Changes Made

How to Test

Notes

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

QodoAI-Agent commented Apr 23, 2025

Title

User description

Description

Changes Made

How to Test

Notes

PR Type

Description

Changes walkthrough 📝

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

QodoAI-Agent commented Apr 23, 2025

PR Reviewer Guide 🔍

Uh oh!

QodoAI-Agent commented Apr 23, 2025

PR Code Suggestions ✨

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 9, 2025

Uh oh!

QodoAI-Agent commented May 9, 2025

2025-05-09

Added

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants