fix: Catch errors when calling pixels from Python

[samarthKharote]

Description

This PR fixes an issue of operationType, so now, when we run a reactor that does not exist, it returns operationType as "ERROR". not "CODE_EXECUTION".

Changes Made

-Made changes in Java class before sending the result.
-In NativePySocketClient.Class detected pixel operation as error in JSON, so evaluated "ERROR" presence via JMESPath expression and threw IllegalArgumentException on getting error.
-JMESPath library is used for JMESPath expression and Jackson is used to parse pixel output JSON.

How to Test

1. Create a drag and drop app and run Python pixel calls in the notebook cells.
2. Mention reactor that does not exist and press Run All.
   Bad pixel call example to test-

from semoss import Insight
insight = Insight()
insight.run_pixel(pixel="vLLM ( engine = [ '4801422a-5c62-421e-a00c-05c6a9e15de8' ] , command = [ '<encode>What is the capital of Connecticut</encode>' ] )", insight_id = '${i}')

4. In network tab, the response is visible with the given operationType.

Notes

[github-actions]

@CodiumAI-Agent /describe

[QodoAI-Agent]

Title

fix: Catch errors when calling pixels from Python

---

User description

Description

Changes Made

How to Test

1. Steps to reproduce/test the behavior
2. Expected outcomes

Notes

---

PR Type

Bug fix

---

Description

• Detect pixel operation errors in JSON

• Add Jackson and JMESPath parsing

• Throw exception on error operations

---

Changes walkthrough 📝

	Relevant files
Error handling	NativePySocketClient.java Add JSON error detection for pixels                                            src/prerna/tcp/client/NativePySocketClient.java Imported Jackson and JMESPath libraries Parsed pixel output JSON with ObjectMapper Evaluated ERROR presence via JMESPath expression Threw IllegalArgumentException on errors +20/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

@CodiumAI-Agent /review

[github-actions]

@CodiumAI-Agent /improve

[QodoAI-Agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Duplicate JSON parsing The code parses the same output twice using Jackson and Gson, which may impact performance and increase memory usage; consider reusing the parsed JsonNode or converting it directly into a JsonElement to avoid redundant work. String jsonOutputString = new String(output.toByteArray(),"UTF-8"); ObjectMapper mapper = new ObjectMapper(); JsonNode jsonNode = mapper.readTree(jsonOutputString); //JMESPath to check for any ERROR in operationType JmesPath<JsonNode> jmespath = new JacksonRuntime(); Expression<JsonNode> expression = jmespath.compile("length(pixelReturn[?contains(operationType, 'ERROR')]) > `0`"); JsonNode result = expression.search(jsonNode); if(result.asBoolean()) { throw new IllegalArgumentException("Pixel execution returned ERROR operationType"); } JsonElement json = JsonParser.parseString(jsonOutputString); Null-safety for JMESPath query The JMESPath expression assumes the pixelReturn array exists and contains objects with operationType; if the JSON structure differs or the field is missing, this could throw runtime errors. Add checks to validate the JSON structure before executing the query. JsonNode jsonNode = mapper.readTree(jsonOutputString); //JMESPath to check for any ERROR in operationType JmesPath<JsonNode> jmespath = new JacksonRuntime(); Expression<JsonNode> expression = jmespath.compile("length(pixelReturn[?contains(operationType, 'ERROR')]) > `0`"); JsonNode result = expression.search(jsonNode);

[QodoAI-Agent]

PR Code Suggestions ✨

Latest suggestions up to bc2f71e

Category	Suggestion	Impact
Possible issue	Validate pixelReturn presence Guard against a missing pixelReturn field before running the JMESPath expression to avoid a runtime error. Check jsonNode.has("pixelReturn") and handle the missing case explicitly. src/prerna/tcp/client/NativePySocketClient.java [359-363] +if (!jsonNode.has("pixelReturn")) { + throw new IllegalStateException("Missing pixelReturn field in JSON output"); +} JsonNode result = expression.search(jsonNode); -if(result.asBoolean()) { - throw new IllegalArgumentException("Pixel execution returned ERROR operationType"); +if (result.asBoolean()) { + throw new IllegalArgumentException("Pixel execution returned ERROR operationType: " + result.toString()); } Suggestion importance[1-10]: 7 __ Why: Explicitly checking for a missing pixelReturn field prevents potential runtime errors and improves robustness by handling invalid JSON responses early.	Medium
General	Extract parsers to static fields Instantiate and compile the JSON/JMESPath processors once as static finals to avoid recreating them on every call. Move the ObjectMapper, JacksonRuntime, and compiled Expression to class‐level constants and reference them here. src/prerna/tcp/client/NativePySocketClient.java [353-359] -ObjectMapper mapper = new ObjectMapper(); -JsonNode jsonNode = mapper.readTree(jsonOutputString); -JmesPath<JsonNode> jmespath = new JacksonRuntime(); -Expression<JsonNode> expression = jmespath.compile("length(pixelReturn[?contains(operationType, 'ERROR')]) > `0`"); -JsonNode result = expression.search(jsonNode); +JsonNode jsonNode = MAPPER.readTree(jsonOutputString); +JsonNode result = ERROR_EXPR.search(jsonNode); Suggestion importance[1-10]: 6 __ Why: Moving ObjectMapper, JacksonRuntime, and the compiled Expression to static fields avoids expensive re-instantiation on every invocation and improves performance.	Low
	Use StandardCharsets.UTF_8 Use the StandardCharsets.UTF_8 constant to avoid relying on the charset name string and eliminate potential UnsupportedEncodingException. src/prerna/tcp/client/NativePySocketClient.java [352] -String jsonOutputString = new String(output.toByteArray(),"UTF-8"); +String jsonOutputString = new String(output.toByteArray(), java.nio.charset.StandardCharsets.UTF_8); Suggestion importance[1-10]: 4 __ Why: Using StandardCharsets.UTF_8 is a minor improvement that eliminates the need to specify a charset name string and avoids possible UnsupportedEncodingException.	Low
	Add error details to exception Include the actual error details in the exception message to aid debugging. Append result.toString() so the thrown exception carries the failing operation details. src/prerna/tcp/client/NativePySocketClient.java [361-363] -if(result.asBoolean()) { - throw new IllegalArgumentException("Pixel execution returned ERROR operationType"); +if (result.asBoolean()) { + throw new IllegalArgumentException("Pixel execution returned ERROR operationType: " + result.toString()); } Suggestion importance[1-10]: 4 __ Why: Appending result.toString() to the IllegalArgumentException message provides additional context for debugging but is a relatively small enhancement.	Low

---

Previous suggestions

Suggestions up to commit bc2f71e

Category	Suggestion	Impact
Possible issue	Fix JMESPath numeric literal syntax Correct the JMESPath numeric literal by removing backticks to ensure proper parsing of the comparison. src/prerna/tcp/client/NativePySocketClient.java [358] -Expression<JsonNode> expression = jmespath.compile("length(pixelReturn[?contains(operationType, 'ERROR')]) > `0`"); +Expression<JsonNode> expression = jmespath.compile("length(pixelReturn[?contains(operationType, 'ERROR')]) > 0"); Suggestion importance[1-10]: 9 __ Why: Backticks around the number in the JMESPath expression are invalid and will break the comparison; removing them ensures proper numeric literal parsing.	High
General	Reuse JSON and JMESPath instances Move the ObjectMapper, JmesPath, and compiled Expression to static final fields to avoid repeated instantiation and JMESPath compilation on each invocation. src/prerna/tcp/client/NativePySocketClient.java [353-359] -ObjectMapper mapper = new ObjectMapper(); -JmesPath<JsonNode> jmespath = new JacksonRuntime(); -Expression<JsonNode> expression = jmespath.compile("length(pixelReturn[?contains(operationType, 'ERROR')]) > `0`"); -JsonNode result = expression.search(jsonNode); +// class-level fields +private static final ObjectMapper JSON_MAPPER = new ObjectMapper(); +private static final Expression<JsonNode> PIXEL_ERROR_EXPR = + new JacksonRuntime().compile("length(pixelReturn[?contains(operationType, 'ERROR')]) > 0"); +// inside method +JsonNode jsonNode = JSON_MAPPER.readTree(jsonOutputString); +JsonNode result = PIXEL_ERROR_EXPR.search(jsonNode); + Suggestion importance[1-10]: 6 __ Why: Using static final fields for ObjectMapper and the compiled JMESPath Expression avoids repeated instantiation and compilation, improving performance and memory usage.	Low
	Eliminate redundant JSON parsing Use the already parsed JsonNode instead of reparsing with JsonParser to avoid redundant parsing and mixing JSON libraries. src/prerna/tcp/client/NativePySocketClient.java [365-366] -JsonElement json = JsonParser.parseString(jsonOutputString); -finalPs.payload = new Object[] {json}; +finalPs.payload = new Object[] {jsonNode}; Suggestion importance[1-10]: 5 __ Why: The code reparses the same JSON string with JsonParser even though a JsonNode is already available, which is inefficient and mixes Jackson and Gson libraries unnecessarily.	Low

[ryanweiler92]

@samarthKharote Can you please add a description and how to test your changes to the PR description?

[samarthKharote]

@ryanweiler92 I added the description and how to test part in the PR

[github-actions]

@CodiumAI-Agent /update_changelog

[QodoAI-Agent]

Changelog updates: 🔄

2025-05-07 [*][https://github.com//pull/787]

Fixed

• Catch errors in Python pixel calls and report operationType as “ERROR” instead of “CODE_EXECUTION”

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'