Added AttachSourceToVectorDbReactor for uploading pdf file to an exis…

[ManjariYadav2310]

…ting csv file and modified VectorFileDownloadReactor

Description

Changes Made

How to Test

1. Steps to reproduce/test the behavior
2. Expected outcomes

Notes

[github-actions]

@CodiumAI-Agent /describe

[QodoAI-Agent]

Title

Added AttachSourceToVectorDbReactor for uploading pdf file to an exis…

---

User description

…ting csv file and modified VectorFileDownloadReactor

Description

Changes Made

How to Test

1. Steps to reproduce/test the behavior
2. Expected outcomes

Notes

---

PR Type

Enhancement, Bug fix

---

Description

• Add reactor for attaching source files to vector DB

• Move and copy uploaded files into DB directory

• Enhance download reactor with zip and single-file logic

• Improve error handling and logging messages

---

Changes walkthrough 📝

	Relevant files
Enhancement	AttachSourceToVectorDbReactor.java Add reactor for attaching sources                                                src/prerna/reactor/vector/AttachSourceToVectorDbReactor.java Introduce new AttachSourceToVectorDbReactor class Validate engine access via SecurityEngineUtils Create insight folder and normalize paths Copy source file into vector DB directory +80/-0
Bug fix	VectorFileDownloadReactor.java Enhance download reactor with zip support                                src/prerna/reactor/vector/VectorFileDownloadReactor.java Streamline single-file download with buffer improvements Add multi-file zipping via ZipOutputStream Validate file existence and count missing files Refine exception messages and logging +37/-31

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

@CodiumAI-Agent /review

[QodoAI-Agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 Security concerns Path traversal: File names from fileNameList are used directly to build file paths without sanitization, allowing potential directory traversal if user-supplied names include ../ sequences.

⚡ Recommended focus areas for review NullPointer Risk fileLocationNew is initialized to null and used in a comparison and Paths.get without null checks, which can lead to NullPointerException if the input path key is missing. String fileLocationNew = null; // if the file location is not defined generate a random path and set // location so that the front end will download String insightFolder = null; if (fileLocation != null) { insightFolder = this.insight.getInsightFolder(); { File f = new File(Utility.normalizePath(insightFolder)); if (!f.exists()) { f.mkdirs(); } } fileLocation = fileLocation.replace("\\", ""); fileName = fileName.replace("\\", ""); fileLocation = insightFolder + DIR_SEPARATOR + fileName; fileLocationNew = insightFolder + DIR_SEPARATOR + this.keyValue.get(ReactorKeysEnum.FILE_PATH.getKey()).replace("\\", ""); } if (!fileLocation.equals(fileLocationNew)) { Exception Handling The catch block for file move prints stack trace directly (e.printStackTrace()) instead of using the logger and does not propagate the error, potentially hiding failures. try { Files.move(oldSourcePath, oldSourcePath.resolveSibling(this.keyValue.get(ReactorKeysEnum.FILE_NAME.getKey()).replace("\\", ""))); } catch (IOException e) { // TODO Auto-generated catch block e.printStackTrace(); } Resource Leak File streams (FileInputStream, FileOutputStream, ZipOutputStream) opened during download are not closed in all code paths, leading to potential resource leaks. if (fileNameList != null && fileNameList.size() > 0) { int fileExistsCount = 0; if (fileNameList.size() == 1) { String filepath = thisEngineDir + DIR_SEPARATOR + fileNameList.get(0); File fileToCheck = new File(filepath); if (fileToCheck.exists()) { fileExistsCount++; FileInputStream fis = new FileInputStream(fileToCheck); outFilePath = outputDir + DIR_SEPARATOR + fileNameList.get(0); fileoutStream = new FileOutputStream(outFilePath); byte[] buffer = new byte[2048]; int bytesRead; while ((bytesRead = fis.read(buffer)) >= 0) { fileoutStream.write(buffer, 0, bytesRead); } }

[github-actions]

@CodiumAI-Agent /improve

[QodoAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Add null safety to file comparison Add null checks for fileLocation and fileLocationNew before comparison and handle missing values to prevent NullPointerException. src/prerna/reactor/vector/AttachSourceToVectorDbReactor.java [61-68] -if (!fileLocation.equals(fileLocationNew)) { +if (fileLocation != null && fileLocationNew != null && !fileLocation.equals(fileLocationNew)) { Path oldSourcePath = Paths.get(fileLocationNew); try { Files.move(oldSourcePath, oldSourcePath.resolveSibling(this.keyValue.get(ReactorKeysEnum.FILE_NAME.getKey()).replace("\\", ""))); } catch (IOException e) { - // TODO Auto-generated catch block - e.printStackTrace(); + classLogger.error("Error moving file from {} to {}: {}", fileLocationNew, fileName, e); + throw new IllegalArgumentException("Failed to move source file", e); } } Suggestion importance[1-10]: 8 __ Why: This prevents a potential NullPointerException when comparing paths and adds logging with a clear exception for better failure handling.	Medium
	Use try-with-resources for streams Use try-with-resources for FileInputStream, FileOutputStream, and ZipOutputStream to ensure all streams are closed properly. src/prerna/reactor/vector/VectorFileDownloadReactor.java [86-93] -FileInputStream fis = new FileInputStream(fileToCheck); -outFilePath = outputDir + DIR_SEPARATOR + fileNameList.get(0); -fileoutStream = new FileOutputStream(outFilePath); -byte[] buffer = new byte[2048]; -int bytesRead; -while ((bytesRead = fis.read(buffer)) >= 0) { - fileoutStream.write(buffer, 0, bytesRead); +try (FileInputStream fis = new FileInputStream(fileToCheck); + FileOutputStream fileoutStream = new FileOutputStream(outFilePath)) { + byte[] buffer = new byte[2048]; + int bytesRead; + while ((bytesRead = fis.read(buffer)) >= 0) { + fileoutStream.write(buffer, 0, bytesRead); + } } Suggestion importance[1-10]: 6 __ Why: Applying try-with-resources guarantees streams are closed automatically, preventing resource leaks and simplifying the cleanup logic.	Low
General	Improve exception handling Replace e.printStackTrace() with proper logging and throw a descriptive exception to ensure upstream handlers can react. src/prerna/reactor/vector/AttachSourceToVectorDbReactor.java [65-68] catch (IOException e) { - // TODO Auto-generated catch block - e.printStackTrace(); + classLogger.error("Failed to move file from {}: {}", fileLocationNew, e); + throw new SemossPixelException("Unable to move source file: " + e.getMessage(), e); } Suggestion importance[1-10]: 7 __ Why: Replacing printStackTrace with structured logging and a custom exception ensures errors are propagated properly and are easier to diagnose.	Medium

[github-actions]

@CodiumAI-Agent /update_changelog

[QodoAI-Agent]

Changelog updates: 🔄

2025-05-01 [*][https://github.com//pull/736]

Added

• VectorAttachFileToSourceReactor to attach source files to vector DB entries

Changed

• VectorFileDownloadReactor: renamed download key, added multi-file support, warnings and improved error handling

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'