Optimize the Count CombineFn #88

robertwb · 2016-03-29T19:40:38Z

Previously the accumulator was stored as a Long. This uses
a singleton long[] to avoid the boxing and unboxing on every
increment.

This required changing the Coder (the format actually remains
the same, but we have no way of declaring that) so is not
backwards compatible with reload.

Previously the accumulator was stored as a Long. This uses a singleton long[] to avoid the boxing and unboxing on every increment. This required changing the Coder (the format actually remains the same, but we have no way of declaring that) so is not backwards compatible with reload.

kennknowles · 2016-03-29T20:53:36Z

sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/transforms/Count.java

   * A {@link CombineFn} that counts elements.
   */
-  private static class CountFn<T> extends CombineFn<T, Long, Long> {
+  private static class CountFn<T> extends CombineFn<T, long[], Long> {


Worth a comment explaining that the accumulator is always size 1, and is used as a mutable box for the long.

kennknowles · 2016-03-29T20:54:00Z

R: @kennknowles

kennknowles · 2016-03-29T20:55:13Z

Jenkins failure is a known breakage not related to this PR.

davorbonaci · 2016-03-30T04:23:09Z

Also, @peihe might want to take a look.

peihe · 2016-03-30T04:49:47Z

sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/transforms/Count.java

    @Override
-    public Long mergeAccumulators(Iterable<Long> accumulators) {
+    public long[] mergeAccumulators(Iterable<long[]> accumulators) {
      long result = 0L;


Consider using the following pattern (similar as BinaryCombineFn):
Iterator<long[]> iter = accumulators.iterator();
if (!iter.hasNext()) {
return createAccumulator();
}
long[] running = iter.next();
while (iter.hasNext()) {
running[0] += iter.next()[0];
}
return running;

Optimize for the case of few accumulators.

robertwb · 2016-03-30T23:46:33Z

@peihe Incorporated your suggestion. For a large number of accumulators, this happens to be worse due to the indexing, but I suppose a small number of accumulators is more common. The difference is in the nanosecond-per-element range either way...

kennknowles · 2016-03-31T04:17:46Z

sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/transforms/Count.java

-      for (Long accum : accumulators) {
-        result += accum;
+    public long[] mergeAccumulators(Iterable<long[]> accumulators) {
+      Iterator<long[]> iter = accumulators.iterator();


Forgot to import Iterator.

Oops. Done.

dhalperi · 2016-03-31T20:30:05Z

[Just noting that there should be no backport.]

apache#77 Import trends benchmarks

…s on Playground Backend * [BEAM-13251][Playground] fix all staticcheck issues * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13251][Playground] merge with master Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com>

…of MustParse with Parse for all API methods * [BEAM-13177][Playground] change uuid.MustParse() to uuid.Parse() * [BEAM-13177][Playground] fix typos * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com>

…eaming output on the frontend * [BEAM-13120] update playground statuses * [BEAM-13210]: add missing statuses * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13210]: add task to generate config using gradle properties * [BEAM-13210]: add licence to gradle.properties * [BEAM-13210]: update generated config * [BEAM-13210]: update generate config gradle task * [BEAM-13210]: rewrite createconfig to groovy Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>

…xamples api * Add reading of precompiled objects from public bucket * Change the enum PrecompiledObjectType * RAT for pb.dart * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Add info about meta file Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>

…o send found tagged file to the backend * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Add client to send found tagged file to the backend; Add python proto files; Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com>

…on and metadata * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13281]: playground - update favicon and metadata Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>

…arch & filter logic * [BEAM-12967]: Created Examples Component * [BEAM-12967]: Wrapped CategoryBubble and ExpansionPanelItem in MouseRegion * [BEAM-13064]: Implemented Search field and Filter by type components logic * [BEAM-13064]: Fixed names to clarify code, refactored Category model (added const keyword) * [BEAM-13064]: Increased test coverage of Example Dropdown module * [BEAM-12967] Added generated files * [BEAM-12967]: Added license to generated files * [BEAM-13064]: Fixed sorting functionality, updated tests & mocks * [BEAM-13064]: Refactored code * [BEAM-12967]: Deleted duplicate files * [BEAM-13064] Fixes after merge * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13064] Fixed analyze issues * [BEAM-13064] Fixed example selector state test Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com>

…toring LifeCycle * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Rename LF executable -> source * Reanme LF compile -> executables Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com>

…e redundant code from controller * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Remove redundant methods from controller, move precompiled objects method to separate package * fix RAT Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com>

…ructure to find and validate tagged files * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13129][Playground] Added base structure to find and verify beam examples Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com>

…eaming output for the run code logs * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13156][Playground] implementation of streaming output for run code output Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com>

…s using the api * [BEAM-12967]: Created Examples Component * [BEAM-12967]: Wrapped CategoryBubble and ExpansionPanelItem in MouseRegion * [BEAM-13064]: Implemented Search field and Filter by type components logic * [BEAM-13064]: Fixed names to clarify code, refactored Category model (added const keyword) * [BEAM-13064]: Increased test coverage of Example Dropdown module * [BEAM-12967] Added generated files * [BEAM-12967]: Added license to generated files * [BEAM-13064]: Fixed sorting functionality, updated tests & mocks * [BEAM-13064]: Refactored code * [BEAM-12967]: Deleted duplicate files * [BEAM-13101]: Implementing new Example structure * [BEAM-13101] Added getPrecompiledOutputs method * [BEAM-13101]: Added default examples request, changed RunCode function to use precompiled Outputs * [BEAM-13101]: Fixed use of precompiledOutputs * [BEAM-13101]: Auto-formatted files, fixed unit tests * Change protobuf * [BEAM-13101] generate proto * [BEAM-13101] revert generate proto * [BEAM-13101] Reworked examples structure * [BEAM-13101] Changed example structure, regenerate proto * [BEAM-13101] Fixes after merge request * [BEAM-13101] Example structure fixes, added licenses * [BEAM-13101] Removed unnecessary file and comment * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13101]: fix tests and refactor examples api * [BEAM-13101]: fix linter issues * [BEAM-13101]: add licence * [BEAM-13101]: format code * [BEAM-13101]: add missing mock file * [BEAM-13101] Updated .proto file, regenerated proto * [BEAM-13101] Fixed import in grpc example client Co-authored-by: Alexander Zhuravlev <stimbai@mail.ru> Co-authored-by: daria-malkova <daria.malkova@akvelon.com> Co-authored-by: Alexander <alexander.zhuravlev@akvelon.com> Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com>

…oundPrecommit to run on GitHub Actions for pull requests * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Create precommit tasks for backend and frontend, replaced separate tests in actions to running precommit * Added linter to preCommit, updated install terraform via github actions * Fix typos and install of terraform Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>

…lement copying a prepared go.mod * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Implement copying a prepared go.mod and go.sum Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com>

… example verification method * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Implement an example verification method; Setup logger; Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com>

…rr from stdout for code processing steps * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13208][Playground] separated stdErr and stdOut for compile step Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com>

…CI checks * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13323][Playground] added processing of err case for utils.SetToCache() method in GetRunOutput() api method Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

…n SDK * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * draft * Rename LF executable -> source * Reanme LF compile -> executables * working python sdk * Update playground/backend/internal/fs_tool/python_fs_test.go Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> * Update playground/backend/internal/fs_tool/python_fs_test.go Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> * refactoring + adding dockerfile * add preparators array (will be filled later) * fix indentation * [BEAM-13307][Playground] Fix tests; Update processing of the compile step for python sdk; Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

…Preparators * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13306][Playground] Add using of preparators for code processing * [BEAM-13306][Playground] Add python preparators Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

…to find all tagged files * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13135][Playground] implemented method to find all tagged files; added categories.yaml file; added requirements.txt file; * [BEAM-13135][Playground] updated categories Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

…end doesn't send correct status when use Redis cache instead of local cache * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13347][Playground] Fix to use redis cache Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

…_statuses method * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13267][Playground] implemented a method to send examples to the backend to verify them Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

…utor builder * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Refactor usage of executors * Merge conflict Co-authored-by: Ilya <ilya.kozyrev@akvelon.com>

…ting * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * [BEAM-13241] Added routing by sdk * [BEAM-13241] Moved urls to config.g.dart, changed tests * [BEAM-13241] Changed grpc_example_client route to backend JAVA route * [BEAM-13241] Fixed routing, added workaround channel * [BEAM-13241] fix linter issues * [BEAM-13241] add licences to mocks Co-authored-by: Sergey Kalinin <91209855+snkalinin@users.noreply.github.com> Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

… precompiled examples * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * implement cd step * [BEAM-13135][Playground] implemented method to find all tagged files; added categories.yaml file; added requirements.txt file; * [BEAM-13267][Playground] implemented a method to send examples to the backend to verify them * CD step * Fix merge conflict Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: AydarZaynutdinov <aydar.zaynutdinov@akvelon.com>

…e CI/CD To Remove Github Actions That Are Not Permitted To Use In Beam Repo * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Replace actions that are not permitted to be used in Apache repo Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

@test

…Unit-tests * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Add java unit tests support * Added @test for java unit-tests * Fix rebase conflicts * Fix concurrent write to map * Fix unit-test with pipeline options Co-authored-by: Ilya <ilya.kozyrev@akvelon.com>

…s With Installing Flutter On GitHub Actions * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Fix locations of flutter executables Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

…it tests * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Add go unit tests support * unit tests fixes * Update playground/backend/internal/executors/executor_test.go Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> * Added verbose flag for go unit tests Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: Artur Khanin <artur.khanin@akvelon.com>

…n unit tests * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Add go unit tests support * Add go unit tests support * Merge conflicts * support Python unit tests * bugfix * Add go unit tests support * unit tests fixes * Update playground/backend/internal/executors/executor_test.go Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> * code processing small refactoring * Add processing of an error Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>

…configuration to enable embedding iframes * [Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks * Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground applications (#83)" (#88) This reverts commit b73f5f7. * Added support for embedded iframe and also gzip compression of assets * Add gzip_static config to nginx Co-authored-by: Ilya <ilya.kozyrev@akvelon.com> Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com> Co-authored-by: daria.malkova <daria.malkova@akvelon.com> Co-authored-by: Pavel Avilov <pavel.avilov@akvelon.com> Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>

* Added integration test for change stream transaction boundaries. * Added some small fixes * Removed Thread.sleep * Removed some debugging statements * Changed TransactionBoundaries code to flush data change records based on number of records received, rather than watermark timer. The function changed would be TransactionBoundaryFn. * Test: Converted integration test to use prod Spanner endpoint * test: change to use logger * test: remove logger level import

* test: add imports into test_collections systest * Revert "test: add imports into test_collections systest" This reverts commit beaefa51c695ef27fab77e9145bfa861e0f8bcea. * move the test into a separate case Co-authored-by: Gurov Ilya <ilya.faer@mail.ru>

kennknowles reviewed Mar 29, 2016
View reviewed changes

Add comment about CountFn's accumulator

41abfb5

peihe reviewed Mar 30, 2016
View reviewed changes

Update Count.java

2bbc44e

Optimize for the case of few accumulators.

kennknowles reviewed Mar 31, 2016
View reviewed changes

Add Iterator import

dd6792b

asfgit closed this in cab0c57 Mar 31, 2016

iemejia referenced this pull request in iemejia/beam Jan 12, 2018

This closes #88

cb975b4

mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018

Merge pull request apache#88 from seznam/pete/import-benmarks

0fddf45

apache#77 Import trends benchmarks

becketqin pushed a commit to becketqin/beam that referenced this pull request May 4, 2023

Flink version update (apache#88)

30488c6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize the Count CombineFn #88

Optimize the Count CombineFn #88

Uh oh!

robertwb commented Mar 29, 2016

Uh oh!

kennknowles Mar 29, 2016

Uh oh!

robertwb Mar 29, 2016

Uh oh!

kennknowles commented Mar 29, 2016

Uh oh!

kennknowles commented Mar 29, 2016

Uh oh!

davorbonaci commented Mar 30, 2016

Uh oh!

peihe Mar 30, 2016

Uh oh!

robertwb commented Mar 30, 2016

Uh oh!

kennknowles Mar 31, 2016

Uh oh!

robertwb Mar 31, 2016

Uh oh!

dhalperi commented Mar 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Optimize the Count CombineFn #88

Optimize the Count CombineFn #88

Uh oh!

Conversation

robertwb commented Mar 29, 2016

Uh oh!

kennknowles Mar 29, 2016

Choose a reason for hiding this comment

Uh oh!

robertwb Mar 29, 2016

Choose a reason for hiding this comment

Uh oh!

kennknowles commented Mar 29, 2016

Uh oh!

kennknowles commented Mar 29, 2016

Uh oh!

davorbonaci commented Mar 30, 2016

Uh oh!

peihe Mar 30, 2016

Choose a reason for hiding this comment

Uh oh!

robertwb commented Mar 30, 2016

Uh oh!

kennknowles Mar 31, 2016

Choose a reason for hiding this comment

Uh oh!

robertwb Mar 31, 2016

Choose a reason for hiding this comment

Uh oh!

dhalperi commented Mar 31, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants