Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Use new TrillianMapWrite API#1304

Merged
gdbelvin merged 3 commits intogoogle:masterfrom
gdbelvin:mapwrite
Jul 2, 2019
Merged

Use new TrillianMapWrite API#1304
gdbelvin merged 3 commits intogoogle:masterfrom
gdbelvin:mapwrite

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Jul 1, 2019

The new TrillianMapWrite API separates writing to Trillian
from generating verifiable responses.

@gdbelvin gdbelvin requested a review from a team as a code owner July 1, 2019 11:33
@gdbelvin gdbelvin requested review from AlCutter and pav-kv July 2, 2019 09:51
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #1304 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
- Coverage   30.64%   30.43%   -0.21%     
==========================================
  Files          45       45              
  Lines        3740     3765      +25     
==========================================
  Hits         1146     1146              
- Misses       2418     2443      +25     
  Partials      176      176
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 0% <0%> (ø) ⬆️
impl/integration/env.go 0% <0%> (ø) ⬆️
core/sequencer/server.go 39.57% <0%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca16bec...e643ec9. Read the comment docs.

@gdbelvin gdbelvin merged commit f73ff70 into google:master Jul 2, 2019
@gdbelvin gdbelvin deleted the mapwrite branch July 2, 2019 10:43
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2019
* master: (106 commits)
  Remove unused logVerifier (google#1324)
  Verify Revisions in StreamRevisions (google#1323)
  Pair verifier functions (google#1322)
  Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318)
  Make Previous hash check optional (google#1307)
  Remove VerifySignedMapRoot from VerifierInterface (google#1320)
  Remove trailing whitespace (google#1321)
  Encapsulate Client Verifier State in test vectors (google#1316)
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
  New test vector transcript format (google#1315)
  Track map revision inside mutation (google#1310)
  Move verifier to its own package (google#1312)
  go generate ./... (google#1306)
  Fix proto copying in revisions and paginator tests. (google#1309)
  Fix proto copying in server_test. (google#1308)
  go mod tidy (google#1305)
  Use new TrillianMapWrite API (google#1304)
  Configurable maximum queue depth for metric reporting. (google#1303)
  Proposal to refine docker deployment (google#1302)
  ...
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2019
* master: (95 commits)
  Remove unused logVerifier (google#1324)
  Verify Revisions in StreamRevisions (google#1323)
  Pair verifier functions (google#1322)
  Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318)
  Make Previous hash check optional (google#1307)
  Remove VerifySignedMapRoot from VerifierInterface (google#1320)
  Remove trailing whitespace (google#1321)
  Encapsulate Client Verifier State in test vectors (google#1316)
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
  New test vector transcript format (google#1315)
  Track map revision inside mutation (google#1310)
  Move verifier to its own package (google#1312)
  go generate ./... (google#1306)
  Fix proto copying in revisions and paginator tests. (google#1309)
  Fix proto copying in server_test. (google#1308)
  go mod tidy (google#1305)
  Use new TrillianMapWrite API (google#1304)
  Configurable maximum queue depth for metric reporting. (google#1303)
  Proposal to refine docker deployment (google#1302)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants