This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
==========================================
+ Coverage 30.06% 30.09% +0.03%
==========================================
Files 47 47
Lines 3829 3825 -4
==========================================
Hits 1151 1151
+ Misses 2500 2496 -4
Partials 178 178
Continue to review full report at Codecov.
|
RJPercival
approved these changes
Jul 17, 2019
Contributor
RJPercival
left a comment
RJPercival
left a comment
There was a problem hiding this comment.
You could do with better test coverage for this file (the Monitor struct appears to have no test coverage at all).
Contributor
Author
|
Indeed. Though it's not quite as bad as it looks.
The monitor does have integration tests.
…On Wed, Jul 17, 2019 at 11:22 AM Rob Percival ***@***.***> wrote:
***@***.**** approved this pull request.
You could do with better test coverage for this file (the Monitor struct
appears to have no test coverage at all).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1324?email_source=notifications&email_token=AABQOTVDG5VWURJSJRHIRRTP73XIBA5CNFSM4IEDKQE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6WBB3Q#pullrequestreview-262934766>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABQOTVNOXVTNZYIRGZF4PDP73XIBANCNFSM4IEDKQEQ>
.
|
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2019
* master: (106 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2019
* master: (95 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.