This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Make check-set mutation semantics optional#1307
Merged
gdbelvin merged 1 commit intogoogle:masterfrom Jul 15, 2019
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
mhutchinson
reviewed
Jul 8, 2019
Contributor
mhutchinson
left a comment
mhutchinson
left a comment
There was a problem hiding this comment.
I'm happy with this from an implementation perspective. Will leave for someone on KT client side to determine whether the approach of removing the backchain is inline with expected direction.
Contributor
Author
|
After discussion in the "Rubber Duck Club™", we realized that preserving "Check Set" semantics is still important for clients that want to do "Fetch Modify Push". I'll modify this CL to make "Check Set" optional rather than removed. |
gdbelvin
force-pushed
the
rm_previous
branch
2 times, most recently
from
ae70868 to
03e5d50
Compare
gdbelvin
changed the title
Contributor
Author
|
This PR should greatly reduce the production error rate. PTAL |
mhutchinson
approved these changes
Jul 15, 2019
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2019
* master: (106 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2019
* master: (95 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash chain in user entries is not currently being used.
Entry.Previouswas intended to help make account history verification efficient, but it did
not meet that goal.
In the meantime,
Entry.Previousenforces quite a tight sequence of get,modify, update. Any delay in Key Transparency sequencing causes these updates
to fail, and continuously retrying exacerbates the issue.