Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Pair verifier functions#1322

Merged
gdbelvin merged 2 commits intogoogle:masterfrom
gdbelvin:pair
Jul 16, 2019
Merged

Pair verifier functions#1322
gdbelvin merged 2 commits intogoogle:masterfrom
gdbelvin:pair

Conversation

@gdbelvin
Copy link
Contributor

Remove duplicate code by creating RPC pair verification functions

@gdbelvin gdbelvin requested a review from a team as a code owner July 16, 2019 15:02
@gdbelvin gdbelvin requested a review from pav-kv July 16, 2019 15:05
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #1322 into master will increase coverage by 0.16%.
The diff coverage is 9.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
+ Coverage    29.8%   29.96%   +0.16%     
==========================================
  Files          46       47       +1     
  Lines        3845     3841       -4     
==========================================
+ Hits         1146     1151       +5     
+ Misses       2523     2512      -11     
- Partials      176      178       +2
Impacted Files Coverage Δ
core/client/client.go 30.18% <ø> (+0.62%) ⬆️
core/integration/client_tests.go 0% <0%> (ø) ⬆️
core/client/get_and_verify.go 23.59% <0%> (ø) ⬆️
core/client/verifier/pairs.go 21.05% <21.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df7449...b61e4bc. Read the comment docs.

@gdbelvin gdbelvin merged commit d5aba9b into google:master Jul 16, 2019
@gdbelvin gdbelvin deleted the pair branch July 16, 2019 16:12
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 16, 2019
* master:
  Pair verifier functions (google#1322)
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2019
* master: (106 commits)
  Remove unused logVerifier (google#1324)
  Verify Revisions in StreamRevisions (google#1323)
  Pair verifier functions (google#1322)
  Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318)
  Make Previous hash check optional (google#1307)
  Remove VerifySignedMapRoot from VerifierInterface (google#1320)
  Remove trailing whitespace (google#1321)
  Encapsulate Client Verifier State in test vectors (google#1316)
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
  New test vector transcript format (google#1315)
  Track map revision inside mutation (google#1310)
  Move verifier to its own package (google#1312)
  go generate ./... (google#1306)
  Fix proto copying in revisions and paginator tests. (google#1309)
  Fix proto copying in server_test. (google#1308)
  go mod tidy (google#1305)
  Use new TrillianMapWrite API (google#1304)
  Configurable maximum queue depth for metric reporting. (google#1303)
  Proposal to refine docker deployment (google#1302)
  ...
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2019
* master: (95 commits)
  Remove unused logVerifier (google#1324)
  Verify Revisions in StreamRevisions (google#1323)
  Pair verifier functions (google#1322)
  Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318)
  Make Previous hash check optional (google#1307)
  Remove VerifySignedMapRoot from VerifierInterface (google#1320)
  Remove trailing whitespace (google#1321)
  Encapsulate Client Verifier State in test vectors (google#1316)
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
  New test vector transcript format (google#1315)
  Track map revision inside mutation (google#1310)
  Move verifier to its own package (google#1312)
  go generate ./... (google#1306)
  Fix proto copying in revisions and paginator tests. (google#1309)
  Fix proto copying in server_test. (google#1308)
  go mod tidy (google#1305)
  Use new TrillianMapWrite API (google#1304)
  Configurable maximum queue depth for metric reporting. (google#1303)
  Proposal to refine docker deployment (google#1302)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants