This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Remove VerifySignedMapRoot from VerifierInterface#1320
Merged
gdbelvin merged 2 commits intogoogle:masterfrom Jul 15, 2019
Merged
Remove VerifySignedMapRoot from VerifierInterface#1320gdbelvin merged 2 commits intogoogle:masterfrom
gdbelvin merged 2 commits intogoogle:masterfrom
Conversation
All verifications should be rooted in the last verified log root
gdbelvin
force-pushed
the
rm_signedmaproot
branch
from
fcfe334 to
726bbaf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
+ Coverage 29.96% 30.01% +0.04%
==========================================
Files 46 46
Lines 3828 3825 -3
==========================================
+ Hits 1147 1148 +1
+ Misses 2505 2501 -4
Partials 176 176
Continue to review full report at Codecov.
|
pav-kv
reviewed
Jul 15, 2019
pav-kv
approved these changes
Jul 15, 2019
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2019
* master: (106 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2019
* master: (95 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All verifications should be rooted in the last verified log root.
Pass already verified
mapRoottoRevisionMutations. There's no need to re-verify it without the context of a last verified log root.