New test vector transcript format by gdbelvin · Pull Request #1315 · google/keytransparency

gdbelvin · 2019-07-11T07:29:48Z

This PR makes the test vector file format self contained.

Previously public verification keys and the contents they were verifying were contained in separate files.

codecov · 2019-07-11T07:36:59Z

Codecov Report

Merging #1315 into master will decrease coverage by 0.39%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #1315     +/-   ##
=========================================
- Coverage   30.45%   30.06%   -0.4%     
=========================================
  Files          45       46      +1     
  Lines        3769     3815     +46     
=========================================
- Hits         1148     1147      -1     
- Misses       2445     2492     +47     
  Partials      176      176

Impacted Files	Coverage Δ
core/testdata/io.go	`0% <0%> (ø)`
core/integration/client_tests.go	`0% <0%> (ø)`	⬆️
core/integration/monitor_tests.go	`0% <0%> (ø)`	⬆️
core/client/client.go	`29.55% <0%> (-0.63%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d34ad...18355a4. Read the comment docs.

core/testdata/transcript_go_proto/transcript.proto

core/testdata/transcript_go_proto/gen.go

core/testdata/io.go

pav-kv · 2019-07-11T11:51:12Z

core/testdata/transcript_go_proto/transcript.proto

@@ -0,0 +1,53 @@
+// Copyright 2019 Google Inc. All Rights Reserved.


Is transcript_go_proto a canonical name for this folder? Technically, transcript.proto can be compiled into other languages (although it's not the case here).

This is a tricky one...

It's Google policy to have go proto packages end in *_go_proto

When importing into Bazel, the *.pb.go files get dropped, and only the proto file remains

The import script also modifies every import/path/A -> package/import/path/A/A

By putting the file in this directory, I think everything should be consistent (for go) automatically.

Alternatively, I can put the transcript.proto file on directory up, and then special case it in the import script.

core/testdata/TestListHistory.json

core/crypto/vrf/p256/p256_test.go

pav-kv · 2019-07-11T13:18:47Z

core/testdata/TestMonitor.json

@@ -0,0 +1,31 @@
+{
+	"description": "TestMonitor",
+	"directory": {


This test, as well as TestListHistory and a couple of others, has no RPCs. Is this expected, and they are still different?

This is expected.

At the moment they are not generating RPCs because the individual tests are not generating them.
What I mean to say is that, at the moment, the RPCs are not being collected in a consistent way.
They are being synthetically synthesized rather than properly recorded with an interceptor.
This is because we are still injecting client state into the Action. When I remove that, I can properly capture all the RPCs and these files won't be empty.

core/client/verifier/verifier_test.go

core/crypto/vrf/p256/p256_test.go

gdbelvin · 2019-07-11T15:36:46Z

Updated, PTAL

pav-kv

Please take another look at err := WriteTranscript comment before submitting.

gdbelvin · 2019-07-11T15:42:16Z

Sharp eye. Thanks for that

* master: New test vector transcript format (google#1315)

* master: (106 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...

* master: (95 commits) Remove unused logVerifier (google#1324) Verify Revisions in StreamRevisions (google#1323) Pair verifier functions (google#1322) Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318) Make Previous hash check optional (google#1307) Remove VerifySignedMapRoot from VerifierInterface (google#1320) Remove trailing whitespace (google#1321) Encapsulate Client Verifier State in test vectors (google#1316) Pass along err message (google#1314) Remove unnessesary func() (google#1319) New test vector transcript format (google#1315) Track map revision inside mutation (google#1310) Move verifier to its own package (google#1312) go generate ./... (google#1306) Fix proto copying in revisions and paginator tests. (google#1309) Fix proto copying in server_test. (google#1308) go mod tidy (google#1305) Use new TrillianMapWrite API (google#1304) Configurable maximum queue depth for metric reporting. (google#1303) Proposal to refine docker deployment (google#1302) ...

gdbelvin added 11 commits July 11, 2019 07:52

Transcript protobuf

20dd2f9

proto: TrustNewLog

97e9ece

Integration tests produce transcripts

25586ec

SaveTestVectors with transcript proto

1d09c5d

New testdata

ab034d5

rm testdata/types.go

5926598

Use testdata local read and write functions

a435d1e

RunTranscriptTest

ab84fe1

Key fields

f466dac

packagePath comment

7cca934

Use transcripts in p256 test

b02a95a

gdbelvin requested review from a team and thaidn as code owners July 11, 2019 07:29

googlebot added the cla: yes label Jul 11, 2019

mv api/transcript to testdata

771ae77

gdbelvin requested a review from pav-kv July 11, 2019 09:09

gdbelvin assigned pav-kv Jul 11, 2019

This was referenced Jul 11, 2019

Encapsulate Client Verifier State in test vectors #1316

Merged

Transcript based verification test vectors #1313

Closed

pav-kv reviewed Jul 11, 2019

View reviewed changes

gdbelvin added 2 commits July 11, 2019 14:35

transcript message documentation

489eebb

KT no longer depends on tink/proto

95aaa7d

golangcibot reviewed Jul 11, 2019

View reviewed changes

gdbelvin added 4 commits July 11, 2019 15:36

s/Unary/Action/

b065bda

WriteTranscript

95d3716

Regenerate testvectors with action

089cd10

Unknown actions should fail

69e6cbc

gdbelvin force-pushed the transcript branch from 09e5874 to 69e6cbc Compare July 11, 2019 14:36

gdbelvin requested a review from pav-kv July 11, 2019 15:36

pav-kv approved these changes Jul 11, 2019

View reviewed changes

Capture err from WriteTranscript

18355a4

gdbelvin merged commit a9cb328 into google:master Jul 11, 2019

gdbelvin deleted the transcript branch July 11, 2019 15:50

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 15, 2019

Merge branch 'master' into errmsg

1cefafe

* master: New test vector transcript format (google#1315)

		@@ -0,0 +1,53 @@
		// Copyright 2019 Google Inc. All Rights Reserved.

Comments

Conversation

gdbelvin commented Jul 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pav-kv Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

gdbelvin Jul 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pav-kv Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

gdbelvin Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gdbelvin commented Jul 11, 2019

Uh oh!

pav-kv left a comment

Choose a reason for hiding this comment

Uh oh!

gdbelvin commented Jul 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gdbelvin commented Jul 11, 2019 •

edited

Loading

codecov bot commented Jul 11, 2019 •

edited

Loading

gdbelvin Jul 11, 2019 •

edited

Loading