Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Move the KT verifier to its own package#1312

Merged
gdbelvin merged 1 commit intogoogle:masterfrom
gdbelvin:verifier
Jul 8, 2019
Merged

Move the KT verifier to its own package#1312
gdbelvin merged 1 commit intogoogle:masterfrom
gdbelvin:verifier

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Jul 8, 2019

This helps separate responsibilities between:

  • Stateful log tracking
  • Statless request generation
  • Verifiation of requests & responses

@gdbelvin gdbelvin requested a review from a team as a code owner July 8, 2019 14:27
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #1312 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
- Coverage   30.43%   30.43%   -0.01%     
==========================================
  Files          45       45              
  Lines        3765     3766       +1     
==========================================
  Hits         1146     1146              
- Misses       2443     2444       +1     
  Partials      176      176
Impacted Files Coverage Δ
core/client/client.go 29.55% <0%> (-0.63%) ⬇️
core/client/verifier/verifier.go 54.05% <70.58%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9f089...1d8c680. Read the comment docs.

@gdbelvin gdbelvin merged commit 9f59005 into google:master Jul 8, 2019
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 9, 2019
* master:
  Move verifier to its own package (google#1312)
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2019
* master: (106 commits)
  Remove unused logVerifier (google#1324)
  Verify Revisions in StreamRevisions (google#1323)
  Pair verifier functions (google#1322)
  Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318)
  Make Previous hash check optional (google#1307)
  Remove VerifySignedMapRoot from VerifierInterface (google#1320)
  Remove trailing whitespace (google#1321)
  Encapsulate Client Verifier State in test vectors (google#1316)
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
  New test vector transcript format (google#1315)
  Track map revision inside mutation (google#1310)
  Move verifier to its own package (google#1312)
  go generate ./... (google#1306)
  Fix proto copying in revisions and paginator tests. (google#1309)
  Fix proto copying in server_test. (google#1308)
  go mod tidy (google#1305)
  Use new TrillianMapWrite API (google#1304)
  Configurable maximum queue depth for metric reporting. (google#1303)
  Proposal to refine docker deployment (google#1302)
  ...
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2019
* master: (95 commits)
  Remove unused logVerifier (google#1324)
  Verify Revisions in StreamRevisions (google#1323)
  Pair verifier functions (google#1322)
  Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318)
  Make Previous hash check optional (google#1307)
  Remove VerifySignedMapRoot from VerifierInterface (google#1320)
  Remove trailing whitespace (google#1321)
  Encapsulate Client Verifier State in test vectors (google#1316)
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
  New test vector transcript format (google#1315)
  Track map revision inside mutation (google#1310)
  Move verifier to its own package (google#1312)
  go generate ./... (google#1306)
  Fix proto copying in revisions and paginator tests. (google#1309)
  Fix proto copying in server_test. (google#1308)
  go mod tidy (google#1305)
  Use new TrillianMapWrite API (google#1304)
  Configurable maximum queue depth for metric reporting. (google#1303)
  Proposal to refine docker deployment (google#1302)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants