Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Pass along err message#1314

Merged
gdbelvin merged 4 commits intogoogle:masterfrom
gdbelvin:errmsg
Jul 15, 2019
Merged

Pass along err message#1314
gdbelvin merged 4 commits intogoogle:masterfrom
gdbelvin:errmsg

Conversation

@gdbelvin
Copy link
Contributor

This is useful when backends are overloaded.

@gdbelvin gdbelvin requested a review from a team as a code owner July 10, 2019 12:30
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #1314 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1314   +/-   ##
=======================================
  Coverage   30.09%   30.09%           
=======================================
  Files          46       46           
  Lines        3815     3815           
=======================================
  Hits         1148     1148           
  Misses       2491     2491           
  Partials      176      176
Impacted Files Coverage Δ
core/keyserver/keyserver.go 40.94% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ded871...0347495. Read the comment docs.

@gdbelvin gdbelvin requested a review from libinjG July 10, 2019 13:35
@gdbelvin gdbelvin requested a review from pav-kv July 15, 2019 10:32
@gdbelvin gdbelvin assigned pav-kv and unassigned libinjG Jul 15, 2019
@gdbelvin gdbelvin merged commit c96c8df into google:master Jul 15, 2019
@gdbelvin gdbelvin deleted the errmsg branch July 15, 2019 11:14
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 15, 2019
* master:
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2019
* master: (106 commits)
  Remove unused logVerifier (google#1324)
  Verify Revisions in StreamRevisions (google#1323)
  Pair verifier functions (google#1322)
  Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318)
  Make Previous hash check optional (google#1307)
  Remove VerifySignedMapRoot from VerifierInterface (google#1320)
  Remove trailing whitespace (google#1321)
  Encapsulate Client Verifier State in test vectors (google#1316)
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
  New test vector transcript format (google#1315)
  Track map revision inside mutation (google#1310)
  Move verifier to its own package (google#1312)
  go generate ./... (google#1306)
  Fix proto copying in revisions and paginator tests. (google#1309)
  Fix proto copying in server_test. (google#1308)
  go mod tidy (google#1305)
  Use new TrillianMapWrite API (google#1304)
  Configurable maximum queue depth for metric reporting. (google#1303)
  Proposal to refine docker deployment (google#1302)
  ...
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2019
* master: (95 commits)
  Remove unused logVerifier (google#1324)
  Verify Revisions in StreamRevisions (google#1323)
  Pair verifier functions (google#1322)
  Split VerifyRevision into Verify{LogRoot,MapRevision (google#1318)
  Make Previous hash check optional (google#1307)
  Remove VerifySignedMapRoot from VerifierInterface (google#1320)
  Remove trailing whitespace (google#1321)
  Encapsulate Client Verifier State in test vectors (google#1316)
  Pass along err message (google#1314)
  Remove unnessesary func() (google#1319)
  New test vector transcript format (google#1315)
  Track map revision inside mutation (google#1310)
  Move verifier to its own package (google#1312)
  go generate ./... (google#1306)
  Fix proto copying in revisions and paginator tests. (google#1309)
  Fix proto copying in server_test. (google#1308)
  go mod tidy (google#1305)
  Use new TrillianMapWrite API (google#1304)
  Configurable maximum queue depth for metric reporting. (google#1303)
  Proposal to refine docker deployment (google#1302)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants