Catch docgen feature up to main. #695

cgranade · 2020-10-21T01:19:11Z

No description provided.

Co-authored-by: Bettina Heim <beheim@microsoft.com>

* Enable nullable for CommandLineTool * Work around CommandLineParser nullable attribute bug

* Enable nullable errors in CompilationManager * Use nullable in AssemblyLoader.cs * Use nullable in CompilationUnit.cs * Use nullable in CompilationUnitManager.cs * Use nullable in ContextBuilder.cs * Use nullable in DataStructures.cs * Use nullable in Diagnostics.cs * Use nullable in DiagnosticTools.cs * Use nullable in FileContentManager.cs * Use nullable in ProcessingQueue.cs * Use nullable for ProjectManager.cs * Use nullable for ScopeTracking.cs * Use nullable for TypeChecking.cs * Use nullable for Utils.cs * Clean up more nullable handling * Update nullables in CodeActions.cs * Update nullables in CodeCompletion.cs * Update nullables in EditorCommands.cs * Update nullables in SymbolInformation.cs * Clean up * Fix missing compilation error * Remove unused using * Replace == null with is null * Add annotations to Verify/Raise * Revert exception to QsCompilerError.Verify

* Enable C# nullable reference types in DocumentationParser project * Avoid null in MergeYamlFile

* Enable nullable reference types in Transformations * Update nullables in Attributes.cs * Update nullables in BasicTransformations.cs * Add annotations to Verify/Raise * Update nullables in ClassicallyControlled.cs * Update nullables in CodeTransformations.cs and Conjugations.cs * Update nullables in ContentLifting.cs * Update nullables in FunctorGeneration.cs * Update nullables in Monomorphization.cs * Update nullables in QsharpCodeOutput.cs * Update nullables in SearchAndReplace.cs * Fix error in ClassicallyControlled.cs * Fix build errors * Update doc comments * Fix nullable errors * Use InternalsVisibleTo

* Enable nullable in LanguageServer.csproj * Update nullables in Communication.cs * Update nullables in EditorState.cs and ProjectLoader.cs * Update nullables in FileSystemWatcher.cs * Use SelectNotNull in FileSystemWatcher.cs * Update nullables in LanguageServer.cs and Utils.cs * Update nullables in Program.cs * Fix remaining nullable errors * Avoid extra null check * Add LanguageServer to InternalsVisibleTo * Fix signing

* Enable nullable in Compiler.csproj * Update nullables in CompilationLoader.cs * Update nullables in ExternalRewriteSteps.cs * Update nullables in FunctorGeneration.cs * Update nullables in Logging.cs * Fix more build errors * Fix last build error * Add QsCompiler to InternalsVisibleTo

* Enable C# nullable reference types in test projects * Remove ArgumentNullException * Remove unnecessary Assert.IsNotNull * Remove nullable from Q# projects

* Remove ArgumentNullExceptions from CommandLineTool * Remove ArgumentNullExceptions from CompilationManager * Remove ArgumentNullExceptions from Compiler * Remove ArgumentNullExceptions from LanguageServer * Remove ArgumentNullExceptions in Transformations * Fix null error * Revert API change

* Pin vsce as dev dependency * Update BUILDING.md

* Fix links in VSCodeExtension readme * Fix links in VisualStudioExtension readme

* pin .NET SDK to 3.1.401 * latest patch roll forward * Update init.yml * removed roll forward * 3.1.402 * Update build/init.yml Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * pin sdk to 3.1.300 and enable roll forward Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: Andres Paz <anpaz@microsoft.com>

* Upper case in "# See Also" doc block * Update src/QsCompiler/Tests.DocGenerator/DocParsingTests.cs Co-authored-by: Chris Granade <cgranade@gmail.com> Co-authored-by: Chris Granade <chgranad@microsoft.com> Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: Chris Granade <cgranade@gmail.com>

We're adding information to the description of the Visual Studio and Visual Studio Code extensions. - A link to the Quantum Computing Foundations learning module. - Links to the Stack Exchange and Stack Overflow resources for Q# where users of the extensions can find support if they run into issues.

Call Graphs, Call Graph Walkers, Cycle Validation, and Updated Monomorphization

Co-authored-by: Bettina Heim <beheim@microsoft.com>

#635)

* Move core transformations to new folder * Split SymbolTable.fs into multiple files Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>

* adding support for binary BigInt * refactored binary and added octal support for BigInt * not enumerating binary to hex * getting rid of enumeration using convert to Int32 for octal to hex * combining base 2 and 8 to hex helper functions Co-authored-by: Ziqi Ma <ziqma@microsoft.com> Co-authored-by: Andres Paz <anpaz@microsoft.com> Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>

) * Swap short/long summary for namespace item/full item * Update tests * Clean up deprecation warning * Clean up code in DocComment.cs Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>

cgranade · 2020-10-21T18:17:17Z

The test failures look to be happening only in IQ# and don't seem to be related to this PR. @bettinaheim, would you be good with merging this to the feature branch so that we can start e2e builds there and get that ready for merging to main?

rmshaffer · 2020-10-21T18:39:08Z

For more context, the IQ# failure appears to be related to the recent cross-repo change between qsharp-compiler and iqsharp, and this branch somehow leading to an inconsistent state across the two repos in the E2E build. I'd recommend we merge this as-is to get the feature branch up-to-date, and then rely on the E2E build when merging the feature branch back to main.

cgranade · 2020-10-21T19:04:59Z

Merging this PR with failing e2e builds as per @rmshaffer's diagnosis above and with @bettinaheim's signoff.

anpaz and others added 27 commits September 9, 2020 16:11

End-to-end (e2e) compiler pipeline (#606)

16f8ca3

renaming master -> main (#623)

f8066b5

Co-authored-by: Bettina Heim <beheim@microsoft.com>

Enable C# nullable reference types for CommandLineTool project (#628)

5db3bbc

* Enable nullable for CommandLineTool * Work around CommandLineParser nullable attribute bug

Enable C# nullable reference types in DocumentationParser project (#646)

cdddee8

* Enable C# nullable reference types in DocumentationParser project * Avoid null in MergeYamlFile

Enable C# nullable reference types in test projects (#656)

7b36d44

* Enable C# nullable reference types in test projects * Remove ArgumentNullException * Remove unnecessary Assert.IsNotNull * Remove nullable from Q# projects

Add vsce to devDependencies (#664)

0e6a240

* Pin vsce as dev dependency * Update BUILDING.md

Fix links in extension documentation (#666)

bcc8674

* Fix links in VSCodeExtension readme * Fix links in VisualStudioExtension readme

Fix some potential nullability issues (#668)

b19fe17

Added octal int parsing test cases. (#670)

f57b391

Call Graph to Main (#654)

a91f121

Call Graphs, Call Graph Walkers, Cycle Validation, and Updated Monomorphization

error for naming conflicts with namespace names (#647)

4d64ce2

Co-authored-by: Bettina Heim <beheim@microsoft.com>

Changing some errors to warnings and vice versa (#643)

9660457

Added support for rewrite steps as Types and as IRewriteStep instances (

18e0c7d

#635)

Fix null unboxing in LoadedStep (#685)

287eca1

Renamed Concretion to Concretization. (#682)

79503a2

Create folders and split out large files in Core (#686)

1aa42e4

* Move core transformations to new folder * Split SymbolTable.fs into multiple files Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>

Improve generated documentation for deprecated callables and types (#605

90fcb62

) * Swap short/long summary for namespace item/full item * Update tests * Clean up deprecation warning * Clean up code in DocComment.cs Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>

Merge branch 'main' into cgranade/main→docgen

38a5b3c

cgranade requested review from bamarsha and bettinaheim October 21, 2020 01:19

Fix nullability issues from merge.

302c469

Fix nullability merge again.

aee997c

bamarsha approved these changes Oct 21, 2020

View reviewed changes

rmshaffer approved these changes Oct 21, 2020

View reviewed changes

cgranade merged commit dda49d4 into feature/docgen Oct 21, 2020

cgranade deleted the cgranade/main→docgen branch October 21, 2020 19:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Catch docgen feature up to main. #695

Catch docgen feature up to main. #695

Uh oh!

cgranade commented Oct 21, 2020

Uh oh!

cgranade commented Oct 21, 2020

Uh oh!

rmshaffer commented Oct 21, 2020

Uh oh!

cgranade commented Oct 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Catch docgen feature up to main. #695

Catch docgen feature up to main. #695

Uh oh!

Conversation

cgranade commented Oct 21, 2020

Uh oh!

cgranade commented Oct 21, 2020

Uh oh!

rmshaffer commented Oct 21, 2020

Uh oh!

cgranade commented Oct 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants