[0.62] Cherry pick PR #5071 for CallJSFunction queuing #5189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added C# ReactContext for Module Initialize method * Change files * Fixed sample project compilation
* Update rex-win32 version to something more recent * Change files
* Remove rnpm-plugin-windows * Change files
…o vnext\ (#4731) * Use readme file from root of repo for react-native-windows * Change files
* Start forking namespace and includes for WUX->MUX move * move C++/WinRT code to use xaml instead of winrt::Windows::UI::Xaml * move to comp instead of winrt::Windows::UI::Composition * . * Change files * fix merge * Redirect IDL types too * format and fix jsvaluexaml * use XAML_NAMESPACE macro in IDL * PR feedback * format * convert include to forward slashes
* Update react version * Change files
…ackage (#4737) * Exclude test projects and proposals from being published in the npm package * Change files
* implement allowRTL, forceRTL, and use RTLness on root * namespace rename * cleanup
* Expose Debug macro for hresult_error. Start catching these... * Change files
* Update tscodegen to version based on 0.62 * Change files
Bumps [@types/react-native](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-native) from 0.62.4 to 0.62.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-native) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* Try uninstalling without elevation in case since it is not needed for layout installs (debug) * Change files
…erties (#4741) * Refactor TestHook out of ViewManagerBase and special case layout properties * Change files * PR and get playground win32 building * format and remove debug in the header
* .net projects need more work to build a package layout * Change files * make async
* Change files * don't need sstream yet * const noexcept
* Package Fixes 1. Use looser peer dependencies on React Native. 0.61 specified 0.61.5 explicitly, but based on recent discussion we want to allow patch releases of RN to work on any RNW version. Allow prerelease versions as well for any special forks, etc. 2. Fixup React Version everywhere. I missed upgraded React dependencies during the 0.62 upgrade. This was fixed in vnext and e2etest with #4734 but other packages were not updated. Update everything here. * Change files
* Stop publishing ReactHwp NuGet Package We no longer support ReactUwp in 0.62. Stop publishing a NuGet package with it. * Change files * Remove stale variable * Remove another stale var
…ication (#4755) * Removed the ref count work around from classes derived from ReactApplications * Change files
Bumps [@babel/core](https://github.com/babel/babel) from 7.9.0 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.9.0...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
…FromTag (#5034) * Add XamlUIService with ElementFromReactTag * formatting * Change files * XamlUIService shouldn't be part of desktop dll
* Use Microsoft.React root namespace in Desktop lib * Move MessageQueueShim to Microsoft::React * Moved NativeLogEventSource into Microsoft::React * Moved NativeTraceEventSource into Microsoft::React * Drop facebook::react usages for Microsoft::React * Set shared items name to Microsoft.React.Shared * Added Microsoft.React.Core * Added Microsoft.React.Core * Added ReactWindowsCore files * Added ReactWindowsCore files * Migrated sources from ReactWindowsCore to Shared * Removed /ReactWindowsCore/Microsoft.React.Core * Updated paths in ReactUWP imports * Delete ReactWindowsCore/ * clang format * Remove references to ReactWindowsCore projects * Change files * Updated stale namespace * Drop RNWCore from Layout-Headers.ps1 * Remove remaining RNWCore VCXPROJ references * Update NUSPEC paths * Update directory properties * ..\.ado\ * Remove AsyncStorageModuleWin32 * Add ReactNative.Hermes.Windows to Desktop. * clang format * Use latest stable test platform * Revert "Migrated sources from ReactWindowsCore to Shared" This reverts commit fa5fed8. * Removed RNWCore\Pch * Restored AsyncStorageManagerWin32 * Reverted renaming of facebook.react namespace * Removed ARM from Desktop solution * Reverted a couple of needlesly changed files * Reverted remaining Shared-referencing files * Added RNwCore README * Reverted Unit Tests project file * Upgrade doc references to RN v0.62.0 * Removed CI obsolete tasks
* Fixes CLI C# app not deploying * Change files
* Add test cases for (Dynamic|Jsi)(Reader|Writer) * Change files * Fix code review comments
* blacklist all ProjectImports.zip * Change files * add blacklist entry to playground
* docs CI
* Update projects to use shared props/targets * Change files
* More attempts at making E2E test more reliable * Try another e2e fix * Another fix for textinput test. * Another fix for the textinput test * revert wdio.conf change
* Allow Override Tooling to Use Nightly Builds Fixes #4857 Teach the tooling about the pattern and make sure we can validate against `0.0.0-56cf99a96` (the earliest nightly build). We cannot do a lazy fetch against a shortned commit hash, so we need to get a bit "creative" here. We make a couple other improvements here: 1. Change fetch depth to 1 to pull in less history. This reduces the scratch repo size from 174MB to 34MB when fetching just 0.62.2 (which is already much less than the 500MB for cloning entire remote) 2. Don't add remotes to the scratch git repo and instead fetch using the URL. We've seen transient errors where `simplegit` thinks we don't yet have a repo set up and adds a duplicate remote. This should hopefully fix that. * Change files * Reduce unneeded fetches
* Enable ReactNativeHost integration test * Change files * Format code * Fix Playground-Win32 compilation * Disable non-runable Desktop unit tests * Format code * Remove extra space in XML comments * Remove extra definitions from Desktop pch.h * Remove Application::Current() override * Format and add comments * Use xaml alias in sample app
Member
|
@vmoroz Just checking that it is expected to have 120 commits for changing 4 files.. Since the title has charry-pick I'd expect a single commit since we squash merge, even though the original pr had 11 commits. |
acoates-ms
changed the title
acoates-ms
approved these changes
Jun 12, 2020
dannyvv
approved these changes
Jun 12, 2020
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting to 0.62 part of the PR #5071 where we implement CallJSFunction calls queuing.
Native modules are initialized while the JS bundle is loaded.
They can start calling back to JS engine right after they are initialized.
Previously if calls are made before the JS is loaded, then they were discarded.
In this change we queue them up and send after the JS bundle finished to load.
Microsoft Reviewers: Open in CodeFlow