Vertamedia Adapter for 1.0 #1789
Merged
jaiminpanchal27 merged 21 commits intoprebid:masterfrom Nov 8, 2017
Merged
Conversation
* 'master' of https://github.com/prebid/Prebid.js: (414 commits) Make response headers available to the specs (prebid#1748) add option to run tests in a specific file (prebid#1727) Update JCM Adapter to 1.0 (prebid#1715) Finished an unfinished comment. (prebid#1749) Platform.io Bidder Adapter update. Prebid v1.0. (prebid#1705) Fix window.top.host cross origin issue when in nested iframes. (prebid#1730) fix log message not displaying when referencing missing bidder (prebid#1737) Allow more than one placement from one page (prebid#1692) Justpremium Adapter bugfix (prebid#1716) Updating license (prebid#1717) realvuBidAdapter (prebid#1571) Update JSDoc to call the module `pbjs` (prebid#1572) Update Beachfront adapter for v1.0 (prebid#1675) Update AdButler adapter for Prebid v1.0 (prebid#1664) Increment pre version Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) ...
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
* 'master' of https://github.com/prebid/Prebid.js: Increment pre version Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784)
jaiminpanchal27
requested changes
Nov 3, 2017
Collaborator
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
There was a problem hiding this comment.
@Millerrok Able to receive bids.
Left some minor comments. Thanks
modules/vertamediaBidAdapter.js
Outdated
| return bidRequests.map((bid) => { | ||
| return { | ||
| data: prepareRTBRequestParams(bid), | ||
| contentType: 'text/plain', |
Collaborator
There was a problem hiding this comment.
contentType is text/plain by default and withCrendentials is also set to true.
Both can be removed from here.
modules/vertamediaBidAdapter.js
Outdated
| */ | ||
| function createBid(bidResponse, bidRequest) { | ||
| return { | ||
| bidderCode: bidRequest.bidderCode, |
Collaborator
There was a problem hiding this comment.
bidderCode will be set by bidderFactory. Can be removed from here.
Also no need to add descriptionUrl
| params: { | ||
| aid: 332842 | ||
| } | ||
| }] |
Collaborator
There was a problem hiding this comment.
}] missing at the end.
Contributor
|
@jaiminpanchal27 thanx for review. I have updated the PR according to your comments. Please take a look. Regarding descriptionUrl, it can be found at line 108. Please confirm that this is what you were looking for. |
jaiminpanchal27
approved these changes
Nov 7, 2017
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update for vertamedia adapter to Prebid 1.0
Add vertamedia md file
Update tests for vertamedia adapter