Release v2.15.0 by dasanra · Pull Request #1597 · 5afe/safe-react

dasanra · 2020-11-12T15:41:11Z

Release v2.15.0

New features

Add support for GridPlus Lattice wallets ( Updates bnc-notify version and adds support for GridPlus Lattice #1527 )
Add Cryptokitties transfer as is special NFT case ( Sending collectibles Tx always fails in ethereum network #1550 )
Walletconnect safe app now is compatible with wc: link instead of QR snapshot where available

Fixes

Replace owners modal is not showing names from address book ( Replace owner modal is not showing the owners names properly #1558 )
Send collectibles using modal from address book view crashes the app ( Address book - Send > Send collectibles crashes de page #1554 )
Fix wrong transaction status in some edge cases ( Tx's show wrong status sometimes #1490 )
Fix not showing pending status for a transaction that is waiting to be executed ( "Pending" status missing when tx is being process #1501 )
Fix rounding issue when sending max ETH value ( Error when sending max ETH #1575 )
Fix wrong address in quick copy button and Etherscan link on "Edit owner" modal ( Any network: Safe address is used for owner address copy to clipboard/Open in .. on the Edit owner name pop-up #1542 )
Don't show ENS message in networks that are not compatible with ENS ( [xDai] Don't display "ENS" in the error message for the address field if the network is not support ENS #1557)
Fix NFTs transactions that were shown as "Custom transaction" instead token transfer ( [xDai] Outgoing NFTs TX is displayed as custom interaction till is executed and some time after execution #1561 )
Fix "Send again" option in transaction details ( "Send again" option in tx details not working / not properly placed #1244 )
Remove provider when app disconnect event is sent from owner wallet side ( Sentry error in provider caused by an empty address #1588 )

Chore

Add documentation for different networks configuration ( (Feature) - #1436 Network configuration documentation #1533 )
Dependencies update and cleanup

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Disable not working wallets for xDai

Backmerge v2.14.0 to development

* Types * Uses addressBook when displaying the replace owner modal Co-authored-by: nicolas <nicosampler@users.noreply.github.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Type TokenSelectField * Type collectibleSelectField Remove anys in SendCollectibleTxInfo Fix cast in SendModal * Replace cast to toString Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Adds networks.md * Updates readme.md * Add some rewording Co-authored-by: nicolas <nicosampler@users.noreply.github.com> Co-authored-by: Fernando <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

…ernal] (#1569) * Adds support for GridPlus Lattice and bumps `bnc-onboard` version. For more information on the GridPlus Lattice, see https://gridplus.io/lattice * Disable Lattice wallet from incompatible chains Co-authored-by: Alex Miller <asmiller1989@gmail.com> Co-authored-by: Fernando <fernando.greco@gmail.com>

* Upgrade web3 to v1.3.0 * Remove polished direct dependency * Upgrade types dependencies * Upgrade ledger and electron related dependencies * Update gnosis-safe-components to latest version * Upgrade sentry dependencies to latest version * Upgrade truffle-contract and axios * Upgrade electron dependencies * Use fade instead rgba with hex value Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

…nsfer (#1576)

* Fix CopyBtn content * Fix explorer url Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

…1567) * Refactor getTxData * Add SAFE_TRANSFER_FROM in SAFE_METHODS_NAMES * Adds check on isSendERC721Transaction for erc721 send * Adds TOKEN_TRANSFER_METHODS_NAMES types * Replace type SAFE_TRANSFER_FROM * Fix import * Adds nftAssetsListAddressSelector * Remove txCode and knownTokens from isSendERC721Transaction Now it directly checks agains the list of nftAssets on the store * Refactor ENS_TOKEN_CONTRACT usage check * Add TODO * Add return for ENS symbol Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: Fernando <fernando.greco@gmail.com>

Add extra information to Google Analytics (#1510 )

* Types * Adds tokenAddress to getTxData for tokenTransfer transactions * Adds sendModalOpenHandler to EllipsisTransactionDetails * Adds getRawTxAmount util * Add isTokenTransfer fix for ether in getTxData * Uses sendFund modal for retry outgoing transfer transactions * Adds ether address in getTxData result for outgoig transfers * Uses nativeCoin * Remove fragmnet * Fix decimals for native coin * Fix decimals usage in tx transfer amount Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* create `logic/collectibles/utils` file and move all the NFT-related helper functions into it `generateERC721TransferTxData` will decide whether the method to transfer an NFT will be `transfer` or `safeTransferFrom`, based on preset conditions where CryptoKitties tokens is taken as an exception. Also, `transfer` was used instead of `transferFrom` because `transferFrom` is not implemented in the rinkeby version, and was the method used as a fallback before. - moved `SAFE_TRANSFER_FROM_WITHOUT_DATA_HASH` const - moved `isSendERC721Transaction` function - moved `getERC721Symbol` function - moved `isERC721Contract` function - created `getTransferMethodByContractAddress` along with `CK_ADDRESS` const - created `generateERC721TransferTxData` function - refactored `ReviewCollectible` component to use `generateERC721TransferTxData` - updated tests * remove `ENS_ADDRESS` constant as it's not used * add unmock of collectibles/utils * add tests for `getTransferMethodByContractAddress`

github-actions · 2020-11-12T15:41:28Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-11-12T15:47:01Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	1	0
Ignored	9	N/A

Result: ✅ success
Annotations: 1 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/ConnectButton/index.tsx Line 68 - Argument 'props' should be typed.

^{Report generated by eslint-plus-action}

ghost · 2020-11-12T15:56:33Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-12T15:56:48Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-12T15:59:34Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-12T19:37:21Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-12T19:37:42Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-12T19:38:08Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/xdai/app

francovenica · 2020-11-13T04:31:19Z

Ticket 1575 is failing
https://pr1597--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xd4c5c335bb46E20EdB6aac288344b769C7977c98/transactions

The rest of the tickets are fine.
Still have to finish the regression

francovenica · 2020-11-13T17:58:50Z

I had the same issue I reported previously but this time with Collectibles.
I sent a CK from one safe to another. The tx was successful since the safe recipient got the CK, but in the origin safe the tx is labeled as "Cancelled" and it looks like only 1 owner signed when I signed with the 2 needed for the execution
https://pr1597--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/transactions
https://pr1597--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xa4B1D0f5EC4aE69Aa3d4B3a4225f057Ae66bfDa5/balances

The tx: https://rinkeby.etherscan.io/tx/0xc084c901e0145be5ec68699875a90e740506398587eb97b9bb1911951dbf60da

The origin safe

The recipient safe:
No incoming tx:

UPDATE: I send some eth to the safe, and that "kicked" the incoming tx's and now I can see the incoming tx for the CK

The CK is there anyways:

fernandomg · 2020-11-13T21:40:12Z

The issue that Franco had during the testing was due to a transaction-service re-indexation running at the same time. Due to this reason, transaction information was incomplete.

We've been checking with Franco, and every time a tx is submitted to the staging transaction-service (mainnet and rinkeby), we get a different list of transactions returned by the service (with missing transactions).

So we assume that all the issues that aroused during this regression are caused by the transaction-service re-indexation.

This issue does not happen with production services. Which we test too

francovenica · 2020-11-16T03:31:20Z

The issue was something that was affecting only the backend. Now the issue is fixed and everything reported in previous comments is working fine now

liliya-soroka · 2020-11-16T07:38:06Z

2.15 regression testing for Ethereum network defects report - https://gno.testrail.io/index.php?/reports/view/85

ghost · 2020-11-16T12:06:22Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-16T12:07:03Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-16T12:07:28Z

Travis automatic deployment:
https://pr1597--safereact.review.gnosisdev.com/volta/app

nicosampler and others added 20 commits October 30, 2020 20:40

Remove request app from rinkeby (#1545)

9fea501

Uses orderedNFTAssets (#1546)

cd8dc8d

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

xDai - Disable Wallets (#1563)

aa5be55

* Disable not working wallets for xDai

Merge branch 'development' into release/v2.14.0

c4ebb63

Merge pull request #1566 from gnosis/release/v2.14.0

8119285

Backmerge v2.14.0 to development

(Fix) Feature/1558 Replace owner modal names (#1562)

f69bffd

* Types * Uses addressBook when displaying the replace owner modal Co-authored-by: nicolas <nicosampler@users.noreply.github.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Fix) - #1554 Send collectible crash on addressBook (#1559)

c9fb7fc

* Type TokenSelectField * Type collectibleSelectField Remove anys in SendCollectibleTxInfo Fix cast in SendModal * Replace cast to toString Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Fix) Executed transactions status (#1552)

7a88153

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Fix development deployment to always use rinkeby network (#1573)

296cf30

(Fix) Error when using up to the max amount of decimals for token tra…

325adda

…nsfer (#1576)

(Fix) - #1542 CopyBtn content in addressbook (#1579)

2a01470

* Fix CopyBtn content * Fix explorer url Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Fix) Prevent ENS check when not supported (#1570)

325864c

Add tracking info to Google analytics (#1584)

19e6df7

Add extra information to Google Analytics (#1510 )

(Fix) Remove the provider when the site is disconnected (#1585)

da1e39c

Rollback web3 to v1.2.11 to avoid issues with walletconnect (#1599)

3c79546

Daniel Sanchez added 3 commits November 16, 2020 12:45

Set production Sablier and WalletConnect IPFS hash

033de25

Merge branch 'master' into release/v2.15.0

9d7fec5

Set v2.15.0

0fe29f1

dasanra requested review from fernandomg and mmv08 November 16, 2020 12:21

fernandomg approved these changes Nov 16, 2020

View reviewed changes

dasanra merged commit 8ff417e into master Nov 16, 2020

github-actions bot locked and limited conversation to collaborators Nov 16, 2020

Conversation

dasanra commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release v2.15.0

New features

Fixes

Chore

Uh oh!

github-actions bot commented Nov 12, 2020

Uh oh!

github-actions bot commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

francovenica commented Nov 13, 2020

Uh oh!

francovenica commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fernandomg commented Nov 13, 2020

Uh oh!

francovenica commented Nov 16, 2020

Uh oh!

liliya-soroka commented Nov 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Nov 16, 2020

Uh oh!

ghost commented Nov 16, 2020

Uh oh!

ghost commented Nov 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dasanra commented Nov 12, 2020 •

edited

Loading

github-actions bot commented Nov 12, 2020 •

edited

Loading

francovenica commented Nov 13, 2020 •

edited

Loading

liliya-soroka commented Nov 16, 2020 •

edited

Loading