V0.9.3 release - ETW streaming and refactoring of aync usage#223
Merged
Conversation
…vicePortalCommand model
…eestablish connection retry loop. Made rename more robust. Stronger check for duplicates using the cannonical IP address
…ventions (#188) And updating version number.
* Add usermode crash dump APIs * Additional fixes to DumpCollection * Add kernel, live, and app dump APIs. * StyleCop pass
merging the PR based on Jason's approval and hpsin's signoff
* Add an IsFolder method to FileOrFolderInformation class. * Updated per review feedback
* Add an IsFolder method to FileOrFolderInformation class. * Updated per review feedback * Adds PackageOrigin to PackageInfo class. * PackageOrigin details and helper method Quick helper method to determine if the app is sideloaded.
Merging per approval
… Close, Receive and Send actions. (Issue #31)
…property types. (Issue #31)
Issue #31: ETW APIs are unimplemented
* Refactored use of async. No tight while-loops but instead using await and continue on background threads. * Remove use of .Wait() to avoid potential deadlocks. increase use of ConfigureAwait, and remove await where not needed * Simplified async code. Instead of forwarding to tasks and have to switch to ui thread, it's easier to just await and continue on the same thread here.
* Change ETW datacontract to expose custom payload. Alters WebSocket parsing routine. * StyleCop pass
Contributor
|
You don't want to include #218? |
Contributor
|
#218 needs more validation still. We can do two back-to-back updates of the NuGet package for that. |
Contributor
Author
|
We were planning to do two releases, one now and one after testing and integrating #218. We definitely want to get that in and released ASAP, and are at this moment testing it. That said, looks like we'll roll it all into one release, since the team member with the binary signing privileges is out of the office. |
* Fix unit test build break. * WindowsErrorReporting is unimplemented (Issue #29) * Convenience accessor for SYSTEM reports I had to dig into behavior to figure this out and test across multiple devices to figure out how this API actually worked - hopefully this helps other developers not have to do the same thing
Contributor
Author
|
This is out of date - will wait on code signing |
CBaud
approved these changes
Feb 28, 2017
david-c-kline
approved these changes
Mar 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A big thank you to @CBaud and @dotMorten for adding ETW support and helping out with our use of async throughout the project.
In addition, some minor changes that help with discovering whether a file in the File Explorer is a folder, and a helper method to determine if an app is sideloaded or not. Thank you to @Holo-Krzysztof for finding these shortcomings in the project.
This includes one breaking change - ConnectAsync in the DevicePortal connection step now defaults to updateConnection:false, meaning that it will not attempt to move from a USB connection to a WiFi connection. This likely will not impact the behavior of your application.