Users/ngbu/xamldirect #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add flag to use chakra core in uwp * fix whitespace * add libs too * one more ifdef
* Try to verify that the steps to init a new rnw project work * Ensure the sdk is installed * Restore nugets as part of build * Try restoring nugets before building package (even though I set restoreNugetPackages: true) * Fix command format * Try using x86 msbuild
* Use package ReactWindows.OpenSSL.StdCall.Static. * Vars: Print DefaultPlatformToolset. * OpenSSL - create NuGet from Vcpkg. * Upgrade to OpenSSL 1.0.2-p.2.
…ker (microsoft#2648) * don't set layout props if they are all the same * move image download setup to background thread
* Added image sample and fixed a couple bugs * Use AvailableSize as desiredMaxSize when loading network images * Revert using AvailableSize for loading network images
* Update to version 0.0.0.36, built with v141 toolset.
…ps, microsoft#2573 (microsoft#2638) * Updated DynamicAutomationPeer to implement ISelectionProvider and ISelectionItemProvider * `disabled` overrides IsEnabled https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.automation.automationelementidentifiers.isenabledproperty * `selected` overrides IsSelected https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.automation.selectionitempatternidentifiers.isselectedproperty * Added buildcppwinrt.cmd script
…scripts as bytecdoes (microsoft#2653) * added basic script store * add basic prepared script store * added code for script store and tryGetPreparedScript * added ability to read and write buffer from/to local file * changed code style to match other files in Utils folder * made writing bytecode generate appropriately sized file, removed wrappers from bytecode manager * made reading and writing work, removed unneeded wrapper * set default bytecode caching to false * address comments * use modified date not created * excluded stores from OSS_RN, hide copy constructors/assignments, used source url in naming of bytecode file * excluded OSS_RN from uwpreactinstance * fix OSS_RN exclude placement for uwpreactinstance
…icrosoft#2654) * Delay setting ReactImageBrush source until image has actually loaded * Remove LoadedImageSurfaceHandler and move into lambda * actually remove LoadedImageSurfaceHandler (oops) * Use weak ref to his in LoadCompleted lambda
* Declare WebSocketServer. * Implement server and session read/write cycle. * Implemented WebSocketServer::Stop. * Join worker thread after closing acceptor. * Define WebSocketServiceCallbacks. * WebSocketSession extend PUBLIC std::enable_shared... * Create/Connect/Stop WS client before stopping server. * Don't instert newline in package.json. * Remove newline from package.json. * Make MessageFactory receive string&&. * Store outgoing message in a member variable. * Use std::promise<string> in SendReceiveInProcServer. * Store sessions in member vector. * Define WebSocketSession::Stop(). * Implement WebSocketServer::SetOnHandshake. * Refactor as BaseWebSocketSession. * Implemented SecureWebSocketSession and client test
* Add commit Id to nuget pacakges * Fix nuspec * commit id is only valid in nuget 4.6+ * Switch method of injecting version number * Fix syntax of template variables
* Fix Memory Leak in ViewViewManager * switch it up
* Add some files * Implements a native, off thread opacity animation. * Large check in.. * Fix the timing issue introduced by batching the UIManager operations. * Implement CR feedback and centerpoint animation * Add a StopAnimation method to AnimationDriver for when the manager needs to stop an animation prematurely. Fix an issue where a callback in the NativeUiManager's BatchCompleted event added another callback to the list would crash. Respond to some feedback * Responding to Keith's feedback. * Respond to Andy's feedback, primarily change the model to have the manager keep collections of unique pointers instead of shared pointers. * Move the collections of nodes to prive members which should be accessed with getters that return a reference to the underlying node. * Fix includes * Switch the Get node methods to return a pointer instead of a ref.
…rosoft#2690) * Adding support for setting a custom root path for bundle loading * Removing extra field in settings * Updating ImageSource to take the root bundle path instead of ReactImage * Switching to a ternary operator to clean up code * Removing unnecessary JSON parsing * Removing extra blank line
Fixes NuGet restore for playground app.
* Enable High Contrast Events * Add Theming test * Convert RGB to hex and rename RGB to Colors * PR draft response * Use interesting color in second View in AccessibilityExample * Responding to PR feedback * Making AccessibilityExample better showcase highcontrast colors * PR reponse and improve AccessibilityExample * Removing iomanip include
* add basic base64 image support * Fire onError event if GetImageInlineDataAsync fails
* manually revoke Completed notification * fix extra copy ctor
…ress ring, checkbox, and textview
…ng to addtocollection
stecrain
pushed a commit
that referenced
this pull request
Oct 25, 2019
* merge * Change files * always publish binlog, comment out targets * comment out targets * change to succeededOrFailed. Of course! * move condition outside inputs. Of course! * add more binlogs * tweak path * joy! reverse engineering pathToPublish is fun * sheesh. still trying to find the binlog * use Build.SourcesDirectory to locate binlog * typo * giving up on /bl. Trying another option * publish log * add timeout * log more build jobs * change publish path * try #2 at getting the right publish path * remove clean
stecrain
pushed a commit
that referenced
this pull request
Nov 20, 2020
* re-enable * comment out PlatformColor test, this was the failing test in the past as well * trying again, this time commenting out PanResponder Sample, which comes just before the failing test * trying to wait for home page to load before continuing * another take on waiting for item in FlatList to be loaded first * trying new approach, enter test name in edit box to filter first * made some progress, now timing out on edit control, add polling for that control * finally! success. Try #2 * try microsoft#3, fingers crossed! * try microsoft#4 * split test into groups * bumping up timeout * try #2 with longer timeout * go back to one testspec * try microsoft#4 with longer timeout * try microsoft#5 with longer timeout. really folks I think I got it this time :) * convert all the tests to use same mechanism * Change files * remove smoke test * stability pass after removing smoke test, try #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.