This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Enable/Disable wallets by configuration flag#1504
Merged
dasanra merged 44 commits intodevelopmentfrom Oct 23, 2020
Merged
Conversation
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com>
* Filter apps by network * add missing network
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Agustin Pane <agustin.pane@gmail.com>
* Add staging xDai deployment to travis * Add safe apps production url for xdai * Add travis rule to build xDai on master or integration branch
* Replace all harcoded values * fix `generateBatchRequest` calls * Fix some ETH harcoded values + Add tests * Fix null or undefinded value * Move nativeCoin outside component + fix toTokenInput function * Remove native coin from useEffect Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
) * Adds FEATURES enum Renames features to disabledFeatures * Uses FEATURES enum instead of hardcoded contract features * Refactor enabledFeatures function, now checks that there are not disabled features by config before return the enabledFeatures result * Adds SAFE_APPS and CONTRACT_INTERACTION to FEATURES enum * Remove SAFE_APPS from sidebar if disabled * Redirect user from /apps if safe apps are disabled * Disables contract interaction from config * Remove !remoteOwners * Move settings to a constant
* add equality function to prevent re-renders * fix typing - I left the inline equalityFn, as an ad-hoc solution. First, because we're going to remove this when #1479 is done Second, because this way it infers the types defined in the useSelector generics
Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>
matextrem
added
Major
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
dasanra
approved these changes
Oct 21, 2020
|
Travis automatic deployment: |
|
Travis automatic deployment: |
fernandomg
approved these changes
Oct 22, 2020
|
Travis automatic deployment: |
Contributor
|
Checked in the PR first which is in the rinkeby network. All wallets are available Looks good to me |
francovenica
approved these changes
Oct 22, 2020
|
Travis automatic deployment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1481