Release v2.14.0 by dasanra · Pull Request #1537 · 5afe/safe-react

dasanra · 2020-10-28T16:24:25Z

New features

Handle safe-apps transactions with custom txGas value ( Handle transactions with set safeTxGas from Safe Apps #1440 )
Make gasPriceOracle to be configurable for each network ( Make use of gasPriceOracleUrl | gasPrice to calculate the gas #1514 )
Add configuration to disable wallets that doesn't work in a specific network ( Enable/Disable wallets by configuration flag #1504 )
Add configuration for EWC and Volta networks compatibility ( EWC & Volta compatibility #1253 )

Fixes

Token balance not updated after sending out all the balance for a token ( Token balance not correctly updated after sending out tokens #1423 )
ERC721 Does not always appear ( ERC721 Does not always appear #1509 )
Send ERC721 that uses a proxy contract ( (Feature) - Send erc721 collectible with proxy contact #1508 )
Fix unexpected behaviour of collectibles list when safe has no collectibles ( Manage list when safe has no Collectibles #795 )
Collectibles groups aren't removed after sending last item ( xDai: Collectibles groups is not removed when the last item from it is sent #1503 )
Set network token in fiat value selector instead of hardcoded ETH ( xDai - Remove the ETH in the Fiat token selector #1498 )
Enabled modules aren't shown in advanced settings ( Enabled module not displayed in advanced settings #1494 )
Update Sablier app to avoid stream errors in edge cases ( Update Sablier Safe App v0.2.1 #1486 )
Update Aave app to latest version ( [Safe App] Aave v1.2 #1373 )
Fix safeTxGas estimation failing on non-Geth nodes ( safeTxGas estimation fails with non-Geth nodes #1515 )

Backmerge hotfix v2.13.1

…1442) * sdk version update * point sdk to a newer commit * Update iframe message handler * ConfirmTransactionModal tweaks to support params * handle sendTransactionsWithParams, display safeTxGas in app tx modal * new sdk version * yarn lock update * install libudev in travis * update sdk version * Estimating safeTxGas for Safe Apps Txs WIP * safetxgas estimation warning wip * gas estimation in confirm transaction modal * yarn lock update * review fixes * Change estimation loading msg, use imported vars to index payload type Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Add coin by network * Join tests in same file Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Add disableWallets key to config * Fix merge issues

* Update calculateGasPrice to fetch from config * Remove unused gas estimation function * Remove unused gasCost estimate function * Add gasParameter to gasPriceOracle

* sdk version update * point sdk to a newer commit * Update iframe message handler * ConfirmTransactionModal tweaks to support params * handle sendTransactionsWithParams, display safeTxGas in app tx modal * new sdk version * yarn lock update * install libudev in travis * update sdk version * Estimating safeTxGas for Safe Apps Txs WIP * safetxgas estimation warning wip * gas estimation in confirm transaction modal * yarn lock update * update sdk version * add handler for rpc calls * use send method * update sdk version * dep bump * wip * update sdk * remove unused interface and console.log * remove async, tweak check for send func Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

* Removed containsMethodByHash condition check, now we always expect that safeTransferFrom is defined on the erc721 contract * Types * More types * Add try catch on estimateGas * Add try catch on submit transaction * More types * More types * More types * ReviewTx modal props * Fix SendCollectible modal types * Add guard for safeAddress * Move some imports * Fix DispatchReturn types * Fix import of Dispatch * Remove console log * Adds logs * Fix import Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

…em from it is sent (#1511) * Remove default export with const * Filter collectibles group with user's available nftAsset * Improves filter * Fix duplicated assets

* Bump new onboard.js version * Remove component * Fix travis rollback bug * Fix Typos + Updated logic Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

* Upgrade Typescript to v4.0.3 * Upgrade dependencies with minor changes * Cleanup yarn.lock file * Upgrade types dependencies * Fix inconsistency with @typescript/eslint caused by react-scripts * Fix eslint issues Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

* Add config for EWC and Volta * Join tests in same file * change price oracle in volta * add travis config for volta and ewc * Update travis to build xDai only in master or version release * Add PR environment by network * simplify some constants assignments * Add PUBLIC_URL overwrite for PRs * Change PULL_REQUEST condition test * Use absolute path for PUBLIC_URL * Fix missing https:// * Adapt EWC/Volta config to use new gasPriceOracle format * disable openZeppeling in volta and EWC * Deploy EWC to staging * Fix Portis, Fortmatic and Blocknative key refactor * Set EWC deployment to release/2.14.0 Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Remove unnecesary await * Implement gas calculation for NON-GETH nodes * Add tests * Refactor estimateSafeTxGas: now getGasEstimationTxResponse calculates gas or throws errors based on the current node * Refactor getOpenEthereumErrorDataResult to make it works with Nethermind Updates tests Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

github-actions · 2020-10-28T16:24:43Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-10-28T16:30:23Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	14	0
Ignored	12	N/A

Result: ✅ success
Annotations: 14 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/ConnectButton/index.tsx Line 67 - Argument 'props' should be typed.
src/logic/wallets/ethTransactions.ts Line 9 - Missing return type on function.
src/logic/wallets/ethTransactions.ts Line 9 - Argument 'hash' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Object pattern argument should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Argument 'network' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 129 - Argument 'controls' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 129 - Object pattern argument should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'controls' should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'props' should be typed.
src/routes/open/container/Open.tsx Line 56 - Missing return type on function.
src/routes/open/container/Open.tsx Line 56 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 56 - Argument 'userAccount' should be typed.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Missing return type on function.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Object pattern argument should be typed.

^{Report generated by eslint-plus-action}

ghost · 2020-10-28T16:38:43Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/volta/app

ghost · 2020-10-28T16:48:48Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-10-28T17:02:38Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/volta/app

ghost · 2020-10-28T17:03:44Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-10-29T11:50:50Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/volta/app

ghost · 2020-10-29T11:51:31Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/rinkeby/app

* Disable wallets for Volta and EWC networks

* Replaces old EtherscanBtn with ExplorerButton from safe components * Remove default exports Fix typo un etherscanLink name import * Replaces EtherscanBtn with ExplorerButton * Remove etherscanButton component

ghost · 2020-11-02T08:39:39Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-02T08:40:51Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-02T08:57:46Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-02T08:59:49Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-02T09:06:06Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-02T16:57:47Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-02T16:59:40Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-02T17:00:19Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/xdai/app

francovenica · 2020-11-02T18:14:45Z

A regression was run in the rinkeby network of this pr
For the other networks we checked mostly the connection, and signing of tx. We know and has been reported that.

Most wallets won't work on non-ethereum networks and those will be disabled
ENS names won't work on non-ethereum networks for now
The CryptoKitty token has an issue that is exclusive to that token. The other NFT's we were able to check are working fine.

* Disable not working wallets for xDai

ghost · 2020-11-02T18:39:10Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-02T18:39:24Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-02T18:40:35Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/rinkeby/app

francovenica

The last thing to be done was to disable the wallets for the different networks, that was done and it looks good. The rest is in my previous comment
Regression went fine, just known or minor issues that don't have to do with this deployment

Looks good to me for deployment

ghost · 2020-11-03T08:11:57Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-03T08:12:08Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-03T08:12:29Z

Travis automatic deployment:
https://pr1537--safereact.review.gnosisdev.com/volta/app

Daniel Sanchez and others added 16 commits October 21, 2020 16:07

Merge pull request #1507 from gnosis/hotfix/v2.13.1

2e5df72

Backmerge hotfix v2.13.1

Add coin by network (#1505)

8aeb5a1

* Add coin by network * Join tests in same file Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Enable/Disable wallets by configuration flag (#1504)

c9e9fe8

* Add disableWallets key to config * Fix merge issues

Update calculateGasPrice to fetch from config (#1517)

5f3a9ef

* Update calculateGasPrice to fetch from config * Remove unused gas estimation function * Remove unused gasCost estimate function * Add gasParameter to gasPriceOracle

Fix show token balances after sending out all tokens (#1521)

95d102d

(Bug) - #1503 Fix collectibles groups is not removed when the last it…

4ce8917

…em from it is sent (#1511) * Remove default export with const * Filter collectibles group with user's available nftAsset * Improves filter * Fix duplicated assets

(Fix) Modules not shown in Advanced Settings (#1516)

aa181fb

Collectibles List - Manage list when no collectibles (#1419)

cb051b1

* Bump new onboard.js version * Remove component * Fix travis rollback bug * Fix Typos + Updated logic Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

Update Sablier app (#1525)

27fbb38

Deploy EWC staging from release branch

6c50f1a

dasanra self-assigned this Oct 28, 2020

Deploy Volta to staging

afb876c

Set production pin to Aave safe-app

ec96edb

matextrem and others added 3 commits October 30, 2020 20:22

EWC/Volta - Disable not working wallets (#1549)

c798f1e

* Disable wallets for Volta and EWC networks

Set v2.14.0

26dd60a

(Feature) - #1541 etherscan on ewc (#1544)

3fa0b74

* Replaces old EtherscanBtn with ExplorerButton from safe components * Remove default exports Fix typo un etherscanLink name import * Replaces EtherscanBtn with ExplorerButton * Remove etherscanButton component

Daniel Sanchez added 3 commits November 2, 2020 09:41

Update xDai regex

64aebf5

Update xDai regex

aef4268

Build xDai on master PR

ae99eac

dasanra requested a review from fernandomg November 2, 2020 16:21

Update EWC/Volta config to use own apps URL

d176301

dasanra requested review from francovenica and nicosampler November 2, 2020 17:54

xDai - Disable Wallets (#1563)

c246223

* Disable not working wallets for xDai

francovenica approved these changes Nov 2, 2020

View reviewed changes

fernandomg approved these changes Nov 2, 2020

View reviewed changes

nicosampler approved these changes Nov 2, 2020

View reviewed changes

Disable release build

8d9b229

dasanra merged commit 6d5164f into master Nov 3, 2020

github-actions bot locked and limited conversation to collaborators Nov 3, 2020

Conversation

dasanra commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New features

Fixes

Uh oh!

github-actions bot commented Oct 28, 2020

Uh oh!

github-actions bot commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Oct 28, 2020

Uh oh!

ghost commented Oct 28, 2020

Uh oh!

ghost commented Oct 28, 2020

Uh oh!

ghost commented Oct 28, 2020

Uh oh!

ghost commented Oct 29, 2020

Uh oh!

ghost commented Oct 29, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

francovenica commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

francovenica left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 3, 2020

Uh oh!

ghost commented Nov 3, 2020

Uh oh!

ghost commented Nov 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dasanra commented Oct 28, 2020 •

edited

Loading

github-actions bot commented Oct 28, 2020 •

edited

Loading