Release v2.17.0 by dasanra · Pull Request #1719 · 5afe/safe-react

dasanra · 2020-12-14T12:18:06Z

Added

New layout for Welcome screen and Safe load/creates selection ( [New Layout] Welcome screen #1648 )
Deploy Aave app v1.3.0 ( Update Aave app #1678 )

Fixed

Apps fail to load if IPFS takes too long to respond ( Apps fail to load if IPFS takes too long to respond #1303 )
Check when same address is set for two owners ( Safe creation - Duplicated owners addresses #1661 )
Fix issues when an owners is deleted from the middle of the list on safe creation ( Create safe: a mess in the safe's owners list if the owner from the middle of the list is deleted #1183 )
Fix transaction is sent to backend even if not signed ( [Bug] Transaction is sent to backend even if not signed. #1656 )
Fix data auto fill when trying to resend a transaction ( "Send again" feature is not autocompleting the token type and value #1664 )
Check duplicated entries in addressbook ( Validate duplicated addresses in the address book and settings #1673 )
Fix safe locking in read-only even when an owner is connected ( Safe in read-only mode even though correct owner is connected #1685 )
Expanded decoded data collapsed automatically ( Expanded decoded data collapses automatically #1693 )

Chore

Upgrade Safe Apps SDK ( Support Safe Apps SDK Promisified API #1593 )
Review and fix console errors and warnings ( Review console errors #1650 )

Backmerge Release v2.16.0

* Shows a timeout message on api timeout * Improves loading text * Improves clear timeout * Fix typo Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Upgrade dependencies without breaking changes * Upgrade react-scripts to v4 * Use import instead of require in icons * Update styles dependencies * Remove react-app-rewired as is deprecated and not needed anymore * Update prettier and testing-library/react dependencies * Upgrade @ledger for desktop app * Fix types in fetchSafeTokens test * Use rescripts to remove ESLint plugin from react-scripts webpack * Disable travis cache Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

* add form level validation for OwnersForm - also fixed `calculateValuesAfterRemoving` function that removed an owner's row by clicking on the trash icon * add tests for `calculateValuesAfterRemoving` function * reformat with prettier

* Fix black notification * Fix executing tx even if the user rejected it * Fix hidden metamask error code * Fix proccessTransaction notifications and metamask sign reject handling

* reactGA bump * remove address from GA * remove unneeded option * Disable travis cache * Set travis to use latest linux build image * Update to use python3 dependencies Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* use createStyles/makeStyles * simplify `addressBookQueryParamsSelector` * avoid using `createSelector` as memoization in this scenario is not working as expected and list is not refreshed * refactor `uniqueAddress` curried function and strategy to validate - `selectedEntry` being `null` made the code harder to follow * fix `uniqueAddress` validator tests * use arrow function

* use multiple versions of safe apps sdk * use multiple versions of safe apps sdk * Type fixes * wip error for multiple versions * fix multiple sdk versions * app communicator wip * communicator wip * getEnvInfo handler * update sdk * app communicator wip * sdk dep bump * promisified getSafeInfo * sendTransactions handler wip * don't send a response if a handler doesnt return anything * add handler for transaction sending * wip rpc call handler * rpc handler * rpc handler fix * V2 Communicator * remove tsbuildinfo * fix communicator * fix error handling for rpc requests * rpc call fixes * Update sdk * Adapting app to use formatters wip * use messafe formatter from sdk * Sdk update * update safe apps sdk version, remove ethBalance from response for safe apps sdk v1 * bump sdk to beta version * update yarn.lock * update yarn.lock * update yarn.lock * use beta version of the sdk * enhance validation check * update dependecies * Update to python3 dependencies * Revert "Update to python3 dependencies" This reverts commit 1332940. * fix transaction params type import Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Remove Warning: React.createFactory() is deprecated * make TS recognize Window definition by adding an empty export * Silent MM warning ethereum.autoRefreshOnNetworkChange * remove warning when requesting data from contract with null address.

* Add resolution for babel version Update @rescrips/cli to be compatible with react-scripts 4 * Upgrade packages to avoid install warnings

* add cards and styles on texts * add styles and content * align card content * fix text about Safe Multisig * add new components from SRC * update SRC * changes to welcome page * fix margins * update SRC * fix icon size * update SRC hash * Dot: replace number by check when wallet is connected * fix card width * add url to help to connect wallet. * remove underline on button as a link (Load Safe). * Fix buttons * disable connect wallet button when there is a connected wallet * fix padding in New Transaction button Co-authored-by: nicosampler <nf.dominguez.87@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Makes getGasEstimationTxResponse exportable * Removes the race condition between useLoadSafe and useSafeScheduledUpdates * Reword safeLoaded * Improve check for setIsSafeLoaded

)

github-actions · 2020-12-14T12:18:21Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-12-14T13:00:12Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	14	0
Ignored	8	N/A

Result: ✅ success
Annotations: 14 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/ConnectButton/index.tsx Line 66 - Missing return type on function.
src/components/ConnectButton/index.tsx Line 75 - Argument 'props' should be typed.
src/logic/safe/transactions/offchainSigner/index.ts Line 22 - Argument 'txArgs' should be typed.
src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'store' should be typed.
src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'next' should be typed.
src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Missing return type on function.
src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'action' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 279 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 279 - Argument 'controls' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 279 - Object pattern argument should be typed.
src/routes/open/container/Open.tsx Line 57 - Missing return type on function.
src/routes/open/container/Open.tsx Line 57 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 57 - Argument 'userAccount' should be typed.
src/routes/opening/index.tsx Line 107 - Object pattern argument should be typed.

^{Report generated by eslint-plus-action}

ghost · 2020-12-14T13:23:47Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-14T13:38:56Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-12-14T13:53:54Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-14T15:20:51Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-14T15:35:17Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-12-14T15:49:53Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/volta/app

francovenica · 2020-12-15T21:26:09Z

So I've checked every ticket individually. check some apps in Rinkeby (had troubles with Sablier early this morning, but they solved themselves during the afternoon) and run the regression for Rinkeby. Didn't find anything critical to report

Liliya followed the smoke test plan in testRail for xdai and did not found any critical issues

There is a ticket that we are trying to put in the release but is taking time: #1731
I reviewed it individually and it worked fine, and I know devs did some code review in it as well. We need to include it in the release branch now.
@dasanra is working to make this happen.

I think we are good to go for the deployment on Wednesday

* Adds shouldSafeBeUpdated to avoid updating unnecessary the safe * Fix css typing * Moves equalArrays to utils function Improves how updateSafe is dispatched within checkAndUpdateSafe to avoid unnecessary re renders * Revert some default cases fixes * Adds equalArrays tests * Add test to arrays.test.ts * Improves shouldSafeStoreBeUpdated order and renames it * Adds shouldSafeStoreBeUpdated.test.ts * Uses shouldSafeStoreBeUpdated within safe reducer * Replaces equalArrays with isEqual from lodash * Simplify shouldSafeStoreBeUpdated using isEqual from lodash * Remove lodash to compare Immutable objects correctly Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

ghost · 2020-12-15T22:05:42Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-15T22:18:56Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-12-15T22:33:46Z

Travis automatic deployment:
https://pr1719--safereact.review.gnosisdev.com/volta/app

Daniel Sanchez and others added 15 commits December 1, 2020 17:40

Merge pull request #1681 from gnosis/release/v2.16.0

40e0a7b

Backmerge Release v2.16.0

(Fix) - Shows a timeout message on app timeout (#1654)

c0a8d24

* Shows a timeout message on api timeout * Improves loading text * Improves clear timeout * Fix typo Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Backmerge hotfix v2.16.2 (#1702)

258790d

(Feature) - #1656 Tx is sent to backend even if not signed (#1672)

9175552

* Fix black notification * Fix executing tx even if the user rejected it * Fix hidden metamask error code * Fix proccessTransaction notifications and metamask sign reject handling

Remove safe address tracking for GA (#1683)

2fe1fb2

* reactGA bump * remove address from GA * remove unneeded option * Disable travis cache * Set travis to use latest linux build image * Update to use python3 dependencies Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

add missing parameters to TransferDescription (#1686)

4079ff9

Handle console erros and warnings (#1709)

c9a06ec

* Remove Warning: React.createFactory() is deprecated * make TS recognize Window definition by adding an empty export * Silent MM warning ethereum.autoRefreshOnNetworkChange * remove warning when requesting data from contract with null address.

Clean dependencies warnings (#1716)

f782c35

* Add resolution for babel version Update @rescrips/cli to be compatible with react-scripts 4 * Upgrade packages to avoid install warnings

(Feature) Safe owners not loaded (#1710)

0f59211

* Makes getGasEstimationTxResponse exportable * Removes the race condition between useLoadSafe and useSafeScheduledUpdates * Reword safeLoaded * Improve check for setIsSafeLoaded

Show ETH value input for payable methods (fix for solidity v0.6x) (#1717

89c7482

)

dasanra self-assigned this Dec 14, 2020

Daniel Sanchez added 3 commits December 14, 2020 13:53

Use latest safe-react-components version

e34b9e7

Merge branch 'master' into release/v2.17.0

1357801

Set v2.17.0

afa8903

Update tx-builder and Aave app hashes

cca6854

dasanra requested a review from francovenica December 14, 2020 16:25

fernandomg approved these changes Dec 15, 2020

View reviewed changes

dasanra merged commit b354170 into master Dec 16, 2020

github-actions bot locked and limited conversation to collaborators Dec 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v2.17.0#1719

Release v2.17.0#1719
dasanra merged 20 commits intomasterfrom
release/v2.17.0

dasanra commented Dec 14, 2020 •

edited

Loading

Uh oh!

github-actions bot commented Dec 14, 2020

Uh oh!

github-actions bot commented Dec 14, 2020 •

edited

Loading

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

francovenica commented Dec 15, 2020

Uh oh!

ghost commented Dec 15, 2020

Uh oh!

ghost commented Dec 15, 2020

Uh oh!

ghost commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

dasanra commented Dec 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Added

Fixed

Chore

Uh oh!

github-actions bot commented Dec 14, 2020

Uh oh!

github-actions bot commented Dec 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

ghost commented Dec 14, 2020

Uh oh!

francovenica commented Dec 15, 2020

Uh oh!

ghost commented Dec 15, 2020

Uh oh!

ghost commented Dec 15, 2020

Uh oh!

ghost commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dasanra commented Dec 14, 2020 •

edited

Loading

github-actions bot commented Dec 14, 2020 •

edited

Loading