fix(cli): clean up slash command IDE listeners

[jasonmatthewsuhari]

Summary

• make the async IDE status listener setup in useSlashCommandProcessor cleanup-safe
• avoid adding a listener after unmount by guarding on a local active flag
• add a regression test covering unmount after async initialization

Fixes #24337.

Testing

• npm run build --workspace @google/gemini-cli-core
• npm test --workspace @google/gemini-cli -- slashCommandProcessor.test.tsx

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the stability of the slash command processor by ensuring that IDE status listeners are managed safely during component lifecycle transitions. By tracking the active state and the client instance, it prevents potential memory leaks and race conditions that could occur when asynchronous initialization completes after a component has already been unmounted.

Highlights

• Async Listener Cleanup: Introduced an 'isActive' flag to prevent adding IDE status listeners after the component has unmounted.
• Synchronous Cleanup: Refactored the cleanup logic to remove the IDE status listener synchronously using a tracked 'activeIdeClient' reference instead of an async call.
• Regression Testing: Added a new test case to verify that the IDE status listener is correctly removed upon unmount even if the initialization is asynchronous.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a race condition in the useSlashCommandProcessor hook where an IDE status listener could be registered after the hook had already unmounted. It introduces an isActive flag and tracks the activeIdeClient to ensure proper cleanup. Feedback suggests simplifying the activeIdeClient type definition by using the IdeClient class directly. Additionally, recommendations were made to improve test organization, add a test case for unmounting before initialization completes, and ensure the unmount function is called in tests for proper resource cleanup.

[scidomino]

Address the gemini comments and I will most likely approve.

[jasonmatthewsuhari]

@scidomino Thanks for assigning! Addressed the Gemini review comments in this branch.

Summary of changes:

• Simplified the IDE listener tracking in useSlashCommandProcessor by using IdeClient directly for activeIdeClient instead of a manual structural type
• Kept the async initialization guard and cleanup flow so the listener is only registered while the hook is active and is removed synchronously upon unmount
• Reworked the lifecycle tests by moving the IDE listener cleanup coverage into the lifecycle block, adding a regression test for unmounting before IdeClient.getInstance() resolves, and making the relevant tests explicitly unmount to avoid leaks

All tests (35/35) pass.

[scidomino]

@jasonmatthewsuhari I think you forgot to push your changes because I still see all the issues. Also, please mark the comments as resolved when you are done with them. thanks!

[jasonmatthewsuhari]

@scidomino Oh my, my bad 😭 I've committed the changes. Thanks for the notif!

[jasonmatthewsuhari]

@scidomino Removed the unrelated change via new commit 043d274.

[jasonmatthewsuhari]

@scidomino Removed the unrelated gitService test changes in 91a333e. The PR diff is back to just the slash-command listener fix and its tests. My bad on this 🙏

[jasonmatthewsuhari]

The E2E fail seems unrelated... the failing test is integration-tests/file-system-interactive.test.ts.

I checked other runs and found the same failure on unrelated PRs, and also found that the same main SHA has both passing and failing chained E2E runs (including one of my other PRs, which faced the same issue).

Some other failed runs on the main branch:
https://github.com/google-gemini/gemini-cli/actions/runs/24464992417
https://github.com/google-gemini/gemini-cli/actions/runs/24464223074
https://github.com/google-gemini/gemini-cli/actions/runs/24464166372

I could be missing some context, so I’m not claiming a confirmed root cause here, but I wanted to flag that I wasn’t able to find a clear path from this PR's changes to the failing test.

[scidomino]

Looks like a flakey test. I will investigate.