fix(cli): ensure theme dialog labels are rendered for all themes

[JayadityaGit]

Summary

This PR fixes a UI rendering bug in the theme selection dialog where the `(Incompatible)` and `(Matches terminal)` labels were missing for certain themes.

Details

The bug occurred because the rendering logic in `ThemeDialog.tsx` only attempted to display these labels if the theme's type (e.g., "Light") was separate from its name. Themes like "GitHub Light" or "Ayu Dark", where the type is part of the name, were skipping this entire layout block, causing the labels to be dropped.

I've updated the logic to:

• Check only for the presence of `themeNameDisplay`.
• Conditionally render the `themeTypeDisplay` text within the layout.
• Ensure `themeWarning` and `themeMatch` are always rendered if they exist.

Related Issues

Fixes #24597

How to Validate

1. Open the theme selection dialog (`gemini --settings` -> UI -> Theme).
2. Ensure you are using a dark terminal background.
3. Observe that all light themes (e.g., GitHub Light, Solarized Light) now correctly display the `(Incompatible)` label.
4. Highlight a theme that matches your terminal background and verify the `(Matches terminal)` label appears correctly.
5. Run tests: `npm test -w @google/gemini-cli -- src/ui/components/ThemeDialog.test.tsx`

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
  • Windows
  • Linux
    • npm run

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI rendering issue in the theme selection dialog where specific status labels were missing for certain themes. By decoupling the dependency between theme names and types in the rendering logic, the fix ensures that compatibility and matching status indicators are consistently displayed across all theme options.

Highlights

• Rendering Logic Fix: Updated the theme selection dialog rendering logic to rely on 'themeNameDisplay' instead of requiring both name and type fields, ensuring labels like '(Incompatible)' and '(Matches terminal)' appear for all themes.
• Conditional Label Display: Refactored the component to conditionally render 'themeTypeDisplay' and ensure warning or match labels are always displayed if present.
• Test Updates: Updated test snapshots and test parameters to reflect the improved label visibility in the UI.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the ThemeDialog component to improve the display of theme names and their associated metadata, such as compatibility or terminal match status. The rendering logic was refactored to conditionally display these labels, and the unit tests and snapshots were updated to reflect the new UI output. I have no feedback to provide.

[gemini-cli]

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383).

We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'.

This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community!