Fix/allow for session persistence

[ahsanfarooq210]

Summary for #18727

Fixes a bug where "Allow for this session" for edit tools (write_file, edit) wasn't persisting the permission, causing repeated prompts. The issue occurred because the code was returning early after setting AUTO_EDIT mode, skipping the session rule creation.

Details

• Root Cause: In updatePolicy(), when handling edit tools with "Allow for this session", the code was setting AUTO_EDIT mode but then returning early, preventing the session rule from being created.
• Fix: Removed the early return after setting AUTO_EDIT mode, allowing the policy update to proceed and create the session rule.
• Impact: Users will no longer see repeated prompts for the same edit tool after selecting "Allow for this session".

Related Issues

Fixes #18727

How to Validate

1. Use an edit tool (e.g., write_file, edit) in the CLI
2. When prompted for permission, select "Allow for this session"
3. Use the same tool again in the same session
4. Expected: No permission prompt should appear for subsequent uses in the same session
5. Edge Case: Verify that AUTO_EDIT mode is still properly set for edit tools

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
  • Updated test case to verify both AUTO_EDIT mode and policy update
• Noted breaking changes (if any) - N/A (bug fix only)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug that prevented session-based permissions for interactive edit tools from persisting, which previously caused users to encounter repetitive prompts. By refining the policy update mechanism, the system now correctly registers and remembers user choices for the duration of a session, significantly improving the user experience for interactive editing workflows.

Highlights

• Bug Fix for Session Persistence: Resolved an issue where selecting "Allow for this session" for edit tools (e.g., write_file, edit) did not correctly persist the permission, leading to repeated prompts for the user.
• Policy Update Logic Refinement: Modified the updatePolicy() function to ensure that after setting AUTO_EDIT mode, the process continues to create the necessary session rule by removing an erroneous early return statement.
• Enhanced Test Coverage: Updated an existing test case in policy.test.ts to explicitly verify that both AUTO_EDIT mode is set and a policy update message is published to the message bus, ensuring the fix behaves as expected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the updatePolicy function to ensure that policy updates are published to the message bus during AUTO_EDIT transitions, and updates the test suite to verify this behavior. A review comment identifies a high-severity issue where setting the approval mode before capturing the current mode will corrupt session persistence, as the resulting policy rules will incorrectly include the new mode instead of the user's original setting.