Backport of Replace codemirror 6 code editor with HDS CodeEditor component into release/1.20.x#31417
Closed
hc-github-team-secure-vault-core wants to merge 236 commits into
Conversation
* change namespace to namespace_path * VAULT-36846 link jira * update login settings tests * fix details param * update namespace param * add comment
Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com>
* Update vault-plugin-auth-gcp to v0.21.0 * Add changelog --------- Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com>
Co-authored-by: Eric Jones <cirej2013@gmail.com>
Co-authored-by: Eric Jones <cirej2013@gmail.com>
* Update vault-plugin-auth-azure to v0.21.0 * Add changelog --------- Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com>
* pull in 1.19 doc updates for backport to 1.20 * add 1.20 to hsm entry
* Add missing protocol path table to CMPv2 API documentation * Update CODEOWNERS for PKI api-docs
* add h1 page title and update styling
* most important scep docs * oops. forgot to commit everything. * Add docs around SCEP auth * More SCEP api doc updates * Add return_full_ca_chain parameter to SCEP config docs * Remove duplicated EST sections * Update missing SCEP reference within pki/index.mdx * PR feedback * PR feedback 2 * Rename return_full_ca_chain to restrict_ca_chain_to_issuer * Apply suggestions from code review Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> * Apply suggestions from code review Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Tweaks to review suggestions from Sarah * Apply suggestions from code review Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Fix typo * Fix typo --------- Co-authored-by: Kit Haines <khaines@mit.edu> Co-authored-by: Yoko Hyakuna <yoko@hashicorp.com> Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
…page (#30865) * move helper text above code editor * move above header
* remove 1.19 from the versioned redirect * one more fix
* re-enable 1.19.x as ce_active * add 1.17.x back * set 1.17.x ce_active to false --------- Co-authored-by: davidadeleon <ddeleon@hashicorp.com>
* Update vault-plugin-secrets-alicloud to v0.20.0 * Add changelog * Update go.mod spacing --------- Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com> Co-authored-by: Michael Blaum <96261585+hashiblaum@users.noreply.github.com>
* Update vault-plugin-auth-jwt to v0.24.1 * Add changelog --------- Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com>
* Update vault-plugin-secrets-terraform to v0.12.0 * Add changelog --------- Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com>
* Update table layout * fix weird headers
Co-authored-by: Eric Jones <cirej2013@gmail.com>
* Update vault-plugin-auth-kubernetes to v0.22.1 * Add changelog --------- Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com>
…_group_ids parameters are required (#30913)
* remove omitempty to ensure valid is always returned * add changelog * add test
* add link to empty state * add "UI"
* ce changes for https://github.com/hashicorp/vault-enterprise/pull/8193 * lower case enterprise only errors --------- Co-authored-by: Ben Ash <bash@hashicorp.com>
* Dependency updates for main * go mod tidy
…duct usage reporting (#31261) * apply oss patch * add changelog entree * remove changelog from oss
* add necessary consts * add other db plugins * correct ES * Fix consts in test
…31323) * fixing overflow issue on secondaries lists * add checks in tests
…#31326) * add test * add changelog
* updates api client vars to snake_case for custom messages * updates api client vars to snake_case for tools * updates api client vars to snake_case for sync * updates api client vars to snake_case for secrets engine * updates api client vars to snake_case for auth * updates api client vars to snake_case for usage * updates api client dep to point to gh repo * fixes custom-messages service unit tests * fixes configure-ssh test * fixes configure-ssh test...again
* removes api client in favor of dependency * removes api-client path from ignore files and configs * removes normalize keys method from api service * removes normalize keys test for api service
* Update README Let contributors know that docs will now be located in UDR * Add comments to each mdx doc Comment has been added to all mdx docs that are not partials * chore: added changelog changelog check failure * wip: removed changelog * Fix content errors * Doc spacing * Update website/content/docs/deploy/kubernetes/vso/helm.mdx Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com> --------- Co-authored-by: jonathanfrappier <92055993+jonathanfrappier@users.noreply.github.com> Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
…s CE changes (#31301) * moving clientcountutil changes from ent * adding random usage time for repeated clients * replace math.rand with crypto.rand
* userpass is not case sensitive * ldap is case sensitive when it is configured that way --------- Co-authored-by: Ben Ash <bash@hashicorp.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
Bot
added
the
hashicorp-contributed-pr
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 24 out of 25 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
CI Results: |
lane-wetmore
deleted the
backport/zamoore/hds-4340/code-editor/singularly-profound-adder
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #30188 to be assessed for backporting due to the inclusion of the label backport/1.20.x.
🚨
The person who merged in the original PR is:
@lane-wetmore
This person should resolve the merge-conflict(s) by either:
The below text is copied from the body of the original PR.
Description
This PR will update the use of the Code Mirror 5 code editor to the new Hds::CodeEditor
component.
This changes the internals of the
JsonEditorcomponent to use theHds::CodeBlockcomponent for readonly views and the newHds::CodeEditorcomponent for editing code.Screenshots
Create/Edit Policy - ACL (also applies to RGP and EDL)
Before:Create/Edit Secret - Cubbyhole
Before:Wrap Data
Before:Sign Key - SSH
Before:Web REPL
Before:Control Group Success
Before:After:
OIDC - Create Scope
Before:Form field - KV - Create New Version (also applies to Patching)
Before:TODO
Add changelog
Screenshots for each instance and smoke test them.
Enterprise tests run on -server and on headless
(Current to latest test updates on 07/16)
Then get the version of this PR to a point where we can "easily" backport to 1.19.x. Only 1.19.x as that is LTS.
Once we backport, then do clean up PR that does not need to be backported. Specifically test clean up using selectors and newer patterns.
Overview of commits