[DO NOT MERGE] Change that doesn't do anything #1251

texasaggie97-zz · 2020-02-06T15:43:14Z

This contribution adheres to CONTRIBUTING.md.
~~I've updated CHANGELOG.md if applicable.~~
~~I've added tests applicable for this pull request~~

What does this Pull Request accomplish?

List issues fixed by this Pull Request below, if any.

What testing has been done?

fix 'pythone' typo (#907)

codecov · 2020-02-06T16:19:57Z

Codecov Report

Merging #1251 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1251   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          20       20           
  Lines        3655     3655           
=======================================
  Hits         3360     3360           
  Misses        295      295

Flag	Coverage Δ
#codegenunittests	`88.24% <0.00%> (ø)`
#nifakeunittests	`96.40% <0.00%> (ø)`
#nimodinstunittests	`95.37% <0.00%> (ø)`
#nitclkunittests	`95.45% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3511c86...3511c86. Read the comment docs.

Left to do: - Test returning list of time values.

Renamed the function parameter from timestamps to delays Renamed the unit tests

* Fix if condition * Update generated files

Remove pypy3 from .travis.yml

Run flake8 on examples and system_tests

#1427) - Change "list" to "basic sequence types" - Fix info related to types and "represented objects" in some parameter docstrings. The format used in nimi-python is `param_name (type): Info about the object that this parameter represents`. In certain places, the type and represented object was flipped.

… sequence types. (#1416)

- Adds nidigital system test test_clock_generator_abort - Adds nidigital system test test_clock_generator_generate_clock - Adds nidigital system test test_frequency_counter_measure_frequency

* Adds nidigital system test `test_create_get_delete_time_sets` - Covers `create_time_set`, `get_time_set_name`, `delete_all_time_sets` * Adds nidigital system test `test_configure_get_time_set_period` - Covers `configure_time_set_period`, `get_time_set_period` * Adds nidigital system test `test_configure_get_time_set_drive_format` - Covers `configure_time_set_drive_format`, `get_time_set_drive_format` * Adds nidigital system test `test_configure_get_time_set_edge` - Covers `configure_time_set_edge`, `get_time_set_edge` * Adds nidigital system test `test_configure_time_set_drive_edges` * Adds nidigital system test `test_configure_time_set_compare_edges_strobe` * Adds nidigital system test `test_configure_get_time_set_edge_multiplier` - Covers `configure_time_set_edge_multiplier`, `get_time_set_edge_multiplier` * Adds nidigital system test `test_configure_time_set_drive_edges2x` * Adds nidigital system test `test_configure_time_set_compare_edges_strobe2x`

* `load_pin_map` - Already covered by `test_get_pin_results_pin_information` * `disable_sites` - New test `test_disable_sites` * `enable_sites` - New test `test_enable_sites` * `is_site_enabled` - See `test_enable_sites` - See `test_disable_sites`

#1415)

* Adds line to `test_get_pattern_pin_names` documenting coverage of `load_pattern` * Adds test `test_load_get_unload_patterns` - Covers `load_pattern` slightly differently from the other test - Covers `get_pattern_name` - Covers `unload_all_patterns` * Adds test `test_configure_pattern_burst_sites`

* Updates all nidigital tests except for one to use nidigital.<enum_name> to access enums. - Update of the other test was blocked by #1426. A TODO was created to update it, when possible.

…1428) Improves nidigital system test documentation of what methods are tested.

* Documents coverage of `initiate` in `test_configure_pattern_burst_sites` and corrects api usage * Adds test `test_commit` * Adds test `test_initiate_context_manager_and_wait_until_done` - Covers context manager for `initiate` - Covers `wait_until_done` - Covers `is_done` * Adds test `test_abort` * Adds test `test_abort_keep_alive`

A new metadata key called `uses_hightime` will be added for #1368. This change will make the key names consistent.

…_qualname__` (#1435) * Update HistoryRAMCycleInformation.__repr__ to use `__module__` and `__qualname__` Best practice for implementing `__repr__` for custom types is to use `__module__` and `__qualname__`. By including `__module__` in `__repr__`, `eval(repr(HistoryRAMCycleInformation()))` can be called by importing nidigital as `import nidigital`; which is consistent with recommended import style of nimi-python. If this change is accepted, `__repr__` for private and internal types (including nifake) will be changed in a separate PR. `__repr__` for public types in other modules will be done in 2.0 Source Breakers milestone. * Update CHANGELOG

…1431) * Adds test `test_create_source_waveform_serial` * Adds test `test_create_source_waveform_from_file_tdms` * Adds test `test_write_source_waveform_data_from_file_tdms` * Adds test `test_create_capture_waveform_serial` * Adds test `test_create_capture_waveform_from_file_digicapture`

…o `datetime.timedelta` (#1437)

`hightime` library will be used to fix #1368.

* Adds nidigital system test `test_close` * Adds nidigital system test `test_get_fail_count` * Adds nidigital system test `test_send_software_edge_trigger`

…es (#1439) * Add nidigital system tests for channels and sites repeated capabilities - Add test for channels repeated capability - Add test for sites repeated capability - Add test for sites/pins chained repeated capability * In test_sites_rep_cap(), assert sites are enabled before disabling them

…ers repeated capabilities (#1442)

flake8 on TravisCI got updated recently from 3.7.9 to 3.8.1. On the new version, checks for `'...'.format(...)` has become stricter.

`datetime` will be replaced by `hightime` across all nimi-python modules in a separate PR.

…overage-fixes

sbethur · 2020-05-29T00:21:24Z

The new version of this PR is #1251.

AlexHearnNI and others added 6 commits July 18, 2018 10:59

fix 'pythone' typo

492b3ec

update NI-SCOPE library name for Linux

a53057f

update NI-SCOPE library name for Linux

468017b

Merge pull request #1 from ni/master

203c096

fix 'pythone' typo (#907)

Change that doesn't do anything

b8fd403

Another useless change

93e1fc1

texasaggie97-zz and others added 8 commits February 6, 2020 10:33

Yet another change that doesn't do anything

878be40

Another change because TravisCI let us down

72ad54e

Once more, just because

a8cf1bd

Merge branch 'master' into more-coverage-fixes

f60fa2e

Add support for list of time values.

55be56b

Left to do: - Test returning list of time values.

Add support for returning list of timedeltas

be65c2e

Remove extra blank line

c4e7c54

Merge conflicts

82e3549

texasaggie97-zz mentioned this pull request Feb 14, 2020

Inconsistent results from codecov #1275

Open

sbethur and others added 14 commits February 14, 2020 12:16

Merging from master

7ffceb2

Simplified the function in nifake

f8707c7

Renamed the function parameter from timestamps to delays Renamed the unit tests

Merge branch 'master' into more-coverage-fixes

d8ba5a0

Fix merge error (#1282)

8be3f9e

* Fix if condition * Update generated files

Add missing assert in unit test

3d1ae92

Merging from master

e9d2336

Add flake8 tests for all system tests and examples

d1387c3

Fix issues found by flake8

cd00444

Combine lines

9061402

Remove pypy3 from .travis.yml

4b03a30

Merge pull request #1285 from ni/remove-pypy3-travis-yml

4b4cfce

Remove pypy3 from .travis.yml

Merge branch 'master' into flake8-examples-system-tests

162d6e8

Merge pull request #1283 from ni/flake8-examples-system-tests

1279584

Run flake8 on examples and system_tests

Minor wording improvements.

31903ac

sbethur and others added 28 commits April 22, 2020 16:27

Fix copy-paste error in CHANGELOG

81e3230

Change initial_state parameters in apply_levels_and_timing to basic…

8868997

… sequence types. (#1416)

Add nidigital clock generator and frequency counter system tests (#1412)

efeaf9d

- Adds nidigital system test test_clock_generator_abort - Adds nidigital system test test_clock_generator_generate_clock - Adds nidigital system test test_frequency_counter_measure_frequency

Fix a typo in convert_repeated_capabilities_without_prefix() docstring (

05fee0c

#1415)

Make enum usage more consistent in nidigital tests (#1429)

397d605

* Updates all nidigital tests except for one to use nidigital.<enum_name> to access enums. - Update of the other test was blocked by #1426. A TODO was created to update it, when possible.

Add docstrings to nidigital system tests that cover multiple methods (#…

896c33b

…1428) Improves nidigital system test documentation of what methods are tested.

Change metadata key supports_nitclk to uses_nitclk (#1436)

1d3ce42

A new metadata key called `uses_hightime` will be added for #1368. This change will make the key names consistent.

Add a converter for converting seconds in float to timedelta (#1434)

0571cd8

Change return type of get_time_set_period and get_time_set_edge t…

ce6e5e9

…o `datetime.timedelta` (#1437)

Add hightime as a dependency to nidigital installer (#1438)

a9600a2

`hightime` library will be used to fix #1368.

Add remaining system tests (#1441)

7c4b836

* Adds nidigital system test `test_close` * Adds nidigital system test `test_get_fail_count` * Adds nidigital system test `test_send_software_edge_trigger`

Add system tests for pattern_opcode_events and conditional_jump_trigg…

b32cba1

…ers repeated capabilities (#1442)

Fix flake8 violations (#1450)

45393c7

flake8 on TravisCI got updated recently from 3.7.9 to 3.8.1. On the new version, checks for `'...'.format(...)` has become stricter.

Undo changes for adding hightime to nidigital installer (#1448)

7ad5d73

`datetime` will be replaced by `hightime` across all nimi-python modules in a separate PR.

Change that doesn't do anything

c649d09

Another useless change

20735f0

Yet another change that doesn't do anything

3ed9177

Another change because TravisCI let us down

0e6cfaf

Once more, just because

179d45b

Merge remote-tracking branch 'origin/more-coverage-fixes' into more-c…

3511c86

…overage-fixes

sbethur closed this May 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DO NOT MERGE] Change that doesn't do anything #1251

[DO NOT MERGE] Change that doesn't do anything #1251

Uh oh!

texasaggie97-zz commented Feb 6, 2020

Uh oh!

codecov bot commented Feb 6, 2020 •

edited

Loading

Uh oh!

sbethur commented May 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[DO NOT MERGE] Change that doesn't do anything #1251

[DO NOT MERGE] Change that doesn't do anything #1251

Uh oh!

Conversation

texasaggie97-zz commented Feb 6, 2020

What does this Pull Request accomplish?

List issues fixed by this Pull Request below, if any.

What testing has been done?

Uh oh!

codecov bot commented Feb 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sbethur commented May 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Feb 6, 2020 •

edited

Loading