Release v2.16.0 by dasanra · Pull Request #1657 · 5afe/safe-react

dasanra · 2020-11-26T17:43:19Z

Added

Spending limits feature ( Spending Limits #413 )
Support Circles account in Safe Multisig frontend ( Support Circles Safes in frontend on xDai #1578 )
New safe apps list and layout ( New layout: Safe apps overview page and app page. #1294)
Deploy Sablier Safe app v0.2.3

Fixed

Fix ENS tokens being labeled as ETH ( ENS collectibles tokens being mislabeled as ETH #1587 )
Fix to add more than 10 owners during safe creation ( Not possible to add >10 Owners during safe creation #1154 )
Enable ENS resolve for EWC and Volta networks ( [EWC/Volta]Can't use ENS name for the safe creation as an owner address #1540 )
Fix contract interaction shown as transfer ( Delegate call that calls transfer is marked as token transfer #1063 )
Use create2 to generate new Safes ( Use proxy creation with create2 #1577 )
Fix static files and fonts in WalletConnect Safe App
Show app info when connecting through WalletConnect safe app
Fix QR not working in input address ( Contract Interaction - QR won't input the contract address in the recipient field #1605 )
Use addressbook names when removing an owner ( (Fix) - Uses addressbook names in the review remove owner #1631 )
Fix safe module removal ( Remove module tx is always failed in the safe = 0x1230B3d59858296A31053C1b8562Ecf89A2f888b #1367 )
Fix missing ETH field in Transaction Builder app when using payable function ( Transaction builder: no ETH field for payable functions #1607 )

Chore

Update legal texts ( Adapt legal disclaimer text in Safe app footer #1571 )
Bump dependencies ( Bump dependencies without breaking changes #1632 )
Fixes in app structure

* Fix fetch symbol for incoming txs * Fix getting symbol promise from erc721 * Adda ens contract addresses for different networks

* Add types in getAddressValidator Remove unused props * Absolute import * Adds safeOwnersAddressesSelector * Fix uniqueAddress function * Replaces getAddressesListFromAddressBook with addressBookAddressesListSelector * Remove comment * Types * Fix tests * Improves safeOwnersAddressesSelector * Remove memoize from uniqueAddress * Improves uniqueAddress validation * Improves uniqueAddress function to check checksum values Add tests * Removes toArray from safeOwnersAddressesSelector Allows uniqueAddress to use both string[] and List<string> * Renames safeOwnersAddressesSelector to safeOwnersAddressesListSelector * Update src/components/forms/validator.ts Improves uniqueAddress Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com> * Fix tests * Fix uniqueAddress * Fix types extensions Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: Fernando <fernando.greco@gmail.com>

* refactor layout using flexfox * comments * fix sidebar css * remove overflow y Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>

Backmerge release v2.15.0

* Adds patch-package and postinstall * Creates a patch to add EWC and Volta in web3-eth and web3-eth-ens * Adds support for ewc in isValidEnsName * Update web3 ewc patch * Enables ens lookup for ewc and volta * Fix eslint * Update patch Fix patch-package script in package.json Co-authored-by: Fernando <fernando.greco@gmail.com> Co-authored-by: nicolas <nicosampler@users.noreply.github.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Adds operation call check on isTokenTransfer * Add comment in unclear if Co-authored-by: Fernando <fernando.greco@gmail.com> Co-authored-by: nicolas <nicosampler@users.noreply.github.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

…safe creation (#1630) * Replaces createProxy with createProxyWithNonce method no safe creation * Updates estimationGas method * Moves safeCreationSalt as a parameter * Fix default export Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

* Add types * Fix missing address in input field * Fix reopening file upload modal once closed * Error first callback onFileUploadHandlerClose * Adds error text for qrs that can't be read Fixes popping up again for wrong qr codes * Fix opening modal Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

* Replaces getNonGETHErrorDataResult with getDataFromNodeErrorMessage Updates the extraction of data from the error message to include new GETH nodes version * Add tests for new GETH nodes

Backmerge Hotfix v2.15.1

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

* fix web3 issue * update settings * get masterCopy Address from backend * fix prettier errors * Fix Circles typo * Change Circles detect logic * Use sameAddress to compare mastercopy addresses Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* speed-up load time for safe-apps * show loading status until all the apps are loaded * Add App route * Add cards for each safe-app * move logic to AppFrame * add basic skeleton styles * css fixes * fix image sizes * add transition animation to skeleton * remove duplicated code * Modals * refactor skeleton * refactor layout using flexbox * make content clickable in cards * cards container as css-grid * remove fixed width for cards * replace auto by 1fr * remove margin for cards * add card component and remove some css * rename buttons * add margin to app list * refactor useAppList * fix disclaimer always flashing * fix pointer cursor for Add app icon * add styled component keyframe * update safe-react-components * fix margin and card height, icon size * fix margin in iconImg and app name * fix margins on apps container (breadcrumb area) * remove style comment * fix margin on HelpCenter / remove overflow in sidebar * Improve featuresEnabled for sidebar and apps page. Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com> Co-authored-by: Fernando <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

github-actions · 2020-11-26T17:43:33Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-11-26T17:48:37Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	36	0
Ignored	19	N/A

Result: ✅ success
Annotations: 36 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/ConnectButton/index.tsx Line 66 - Argument 'props' should be typed.
src/logic/safe/utils/upgradeSafe.ts Line 52 - Argument 'createTransaction' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 49 - Argument 'values' should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 147 - Argument 'controls' should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 147 - Argument 'props' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'index' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'notRemovedOwners' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'values' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Argument 'controls' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Object pattern argument should be typed.
src/routes/open/components/fields.ts Line 7 - Missing return type on function.
src/routes/open/components/fields.ts Line 7 - Argument 'index' should be typed.
src/routes/open/components/fields.ts Line 8 - Missing return type on function.
src/routes/open/components/fields.ts Line 8 - Argument 'index' should be typed.
src/routes/open/components/fields.ts Line 10 - Missing return type on function.
src/routes/open/components/fields.ts Line 10 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 57 - Missing return type on function.
src/routes/open/container/Open.tsx Line 57 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 57 - Argument 'userAccount' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 6 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 6 - Argument 'values' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 14 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 14 - Argument 'values' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 22 - Argument 'names' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 22 - Argument 'addresses' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 28 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 28 - Argument 'values' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 30 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 30 - Argument 'values' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 32 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 32 - Argument 'values' should be typed.
src/routes/opening/index.tsx Line 107 - Object pattern argument should be typed.

[warning] @typescript-eslint/no-non-null-assertion

Disallows non-null assertions using the ! postfix operator

src/routes/safe/components/Transactions/TxsTable/TxType/index.tsx Line 78 - Forbidden non-null assertion.
src/routes/safe/components/Transactions/TxsTable/TxType/index.tsx Line 78 - Forbidden non-null assertion.

^{Report generated by eslint-plus-action}

ghost · 2020-11-26T17:58:52Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-26T18:00:22Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-26T18:01:05Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-27T12:33:01Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-27T12:33:35Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-27T14:17:46Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-27T14:19:16Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-27T14:19:35Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-30T09:05:42Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-30T09:06:32Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-30T09:21:52Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-30T15:52:28Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-30T15:54:12Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-30T16:06:37Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/volta/app

* allow to display native coin transfers in the expanded view * fix issue with fragment being passed to material-ui menu

ghost · 2020-11-30T16:23:25Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-30T16:23:50Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-30T16:37:56Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-30T18:40:49Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/xdai/app

ghost · 2020-11-30T18:42:30Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-30T18:54:46Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-30T19:22:58Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-30T19:23:39Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/xdai/app

francovenica · 2020-11-30T19:25:11Z

The rollback to the onboard version makes trezor work again properly.
I can't still use the ledger because I use Win10, but Tobi mentioned it worked for him.

We still have this 2 issues:
#1674
#1673

We decided to leave #1674 for 2.17
Regarding #1673 I don't know how popular is the custom transactions with custom data and how urgent this issue is

Issues still needed to be merged:
#1670
This is working fine and I'd prefer for it to make it to 2.16

for xdai and volta did a small smoke test (load a safe, send funds, send a collectible back and forth, editing an owner) and it worked fine.

Is OK for me to go to to prod with the 2.16 if we can make #1670 enter into it and it will also depend in how critical is the #1673

ghost · 2020-11-30T19:37:43Z

Travis automatic deployment:
https://pr1657--safereact.review.gnosisdev.com/volta/app

Agupane and others added 21 commits November 16, 2020 11:20

(Fix) #1587 - Ens mislabeled as eth (#1601)

9f1dc37

* Fix fetch symbol for incoming txs * Fix getting symbol promise from erc721 * Adda ens contract addresses for different networks

Layout refactor (#1604)

996d339

* refactor layout using flexfox * comments * fix sidebar css * remove overflow y Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com>

Merge branch 'development' into release/v2.15.0

1d3d61d

Update legal text (#1624)

0913f25

Merge branch 'development' into release/v2.15.0

37877d7

Merge pull request #1628 from gnosis/release/v2.15.0

a4cdf3d

Backmerge release v2.15.0

Uses addressbook names in the review remove owner (#1631)

592999d

Bump dependencies without breaking changes (#1632)

9fdf4e2

(Fix) Geth nodes gas estimation errors (#1635)

6ed1e2e

* Replaces getNonGETHErrorDataResult with getDataFromNodeErrorMessage Updates the extraction of data from the error message to include new GETH nodes version * Add tests for new GETH nodes

Merge branch 'development' into hotfix/v2.15.1

9ef6d36

Merge pull request #1644 from gnosis/hotfix/v2.15.1

53a1dcf

Backmerge Hotfix v2.15.1

(Fix) remove module feature (#1646)

dca9f19

(Feature) Spending Limit (#1637)

fc1250d

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Remove dappId from OnboardJS connection (#1627)

e3a8b9f

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

dasanra requested review from fernandomg, francovenica and nicosampler November 26, 2020 17:44

dasanra self-assigned this Nov 26, 2020

update safe-apps legend

5f15090

Rollback bnc-onboard dependency

a7cf0ff

Lower sentry sample rate to avoid threshold overflow

8d73ebd

(Fix) Native Coin transfer not shown (#1670)

76ef99f

* allow to display native coin transfers in the expanded view * fix issue with fragment being passed to material-ui menu

Update WalletConnect app to show correct logo

d5abbd7

Disable Ledger and Trezor in Volta network

265f43e

francovenica approved these changes Nov 30, 2020

View reviewed changes

dasanra merged commit 08bd742 into master Dec 1, 2020

github-actions bot locked and limited conversation to collaborators Dec 1, 2020

Conversation

dasanra commented Nov 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Added

Fixed

Chore

Uh oh!

github-actions bot commented Nov 26, 2020

Uh oh!

github-actions bot commented Nov 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

[warning] @typescript-eslint/no-non-null-assertion

Uh oh!

ghost commented Nov 26, 2020

Uh oh!

ghost commented Nov 26, 2020

Uh oh!

ghost commented Nov 26, 2020

Uh oh!

ghost commented Nov 27, 2020

Uh oh!

ghost commented Nov 27, 2020

Uh oh!

ghost commented Nov 27, 2020

Uh oh!

ghost commented Nov 27, 2020

Uh oh!

ghost commented Nov 27, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

francovenica commented Nov 30, 2020

Uh oh!

ghost commented Nov 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dasanra commented Nov 26, 2020 •

edited

Loading

github-actions bot commented Nov 26, 2020 •

edited

Loading