Skip to content

[WIP] Merge main into azurestoragev12 and Resolve Conflicts#1092

Closed
nytian wants to merge 41 commits intoazure-storage-v12from
nytian/mock-azt2
Closed

[WIP] Merge main into azurestoragev12 and Resolve Conflicts#1092
nytian wants to merge 41 commits intoazure-storage-v12from
nytian/mock-azt2

Conversation

@nytian
Copy link
Collaborator

@nytian nytian commented May 15, 2024

This PR will not be merged. This is for a better review of PR #1077

Check commit solve conflicts for the changes I did when merging with main changes.

jviau and others added 30 commits September 19, 2023 10:02
This PR adds a setter for TraceParent to allow it to get serialized. Without this addition, we weren't able to run Netherite apps with the distributed tracing changes because we were seeing this exception: InvalidDataContractException: No set method for property 'TraceParent' in type 'DurableTask.Core.Tracing.DistributedTraceContext'.

It also updates the TraceState setter to include this condition - traceState?.Length <= 513 ? traceState : null instead of adding it in the constructor.
DT.Core 2.15.0 --> 2.15.1
DT.ApplicationInsights 0.1.1 --> 0.1.2
* remove STJ with Newtonsoft

* increase DTFx.AS version
* Bring entity logic into DurableTask.Core (first milestone) (#887)

* implementaton of entity mechanics, compatible with existing DF SDK, but without a user-facing entity SDK for DTFx

* address PR feedback.

* fix usings and namespaces

* address PR feedback

* address PR feedback (remove NameObjectManager), fix breaking change in TaskHubWorker, fix some comments

* address PR feedback (fix CustomExceptionsTest, remove public property)

* add #nullable enable to most new classes

* address PR feedback

* try to fix compiler errors

* add a configuration setting that disables separate dispatch by default

* address PR feedback

* address PR feedback

* fix semantic merge conflict.

* Revise entity state and status format and access (#955)

* update scheduler state and entity status format and helpers

* fix mess-up caused by merge conflict

* Revise entity message format and external access (#956)

* revise how event messages are represented and used

* fix merge anomaly.

* make current critical section id publicly visible (#958)

* remove orchestration tags from entity action (#952)

* Rename OperationBatchRequest and OperationBatchResponse (#953)

* rename OperationBatch to EntityBatch

* fix accidentally commited change from another PR

* Revise how entity batches are executed and handle failures (#954)

* revise task entity definition

* commit change that had been accidentally committed to a different PR.

* Apply suggestions from code review

Co-authored-by: David Justo <david.justo.1996@gmail.com>

* Apply suggestions from code review

Co-authored-by: Jacob Viau <javia@microsoft.com>

---------

Co-authored-by: David Justo <david.justo.1996@gmail.com>
Co-authored-by: Jacob Viau <javia@microsoft.com>

* revise operation result encoding and add more comments. (#965)

* revise entity backend properties and implement entity backend queries (#957)

* revise entity backend properties and implement entity backend queries.

* Minor revisions to querries and properties, and improved comments.

* fix validation of which LockNext methods are being called.

* improve comments

* fix useage of IEntityOrchestrationService.

* revise how to exclude entity results from queries.

* address PR feedback

* Update versions for ADO feed (#973)

* Add no-warn for NU5104 (#974)

* revise propagation path for entity parameters (#971)

* fix propagation path for entity parameters that need to reach the orchestration executor.

* address PR feedback.

* Revise entity queries (#981)

* rename includeDeletedEntities to includeStatelessEntities and add comment explaining the meaning

* add backlogQueueSize and lockedBy to entity metadata

* fix bugs in tracking store implementation (#979)

* add scheduled start time parameter to the start-new-orchestration operation action. (#980)

* Revise serialization of entitymessages (#972)

* revise how entity messages are serialized when sent by orchestrators.

* address PR feedback (use RawInput)

* Rename includeStateless to includeTransient in entity queries (#985)

* rename includeStateless to includeTransient

* rename variable also

* Rev to entities-preview.2 (#986)

* fix null reference exception when running on older backends (#989)

* Prepare for public preview (#994)

---------

Co-authored-by: David Justo <david.justo.1996@gmail.com>
Co-authored-by: Jacob Viau <javia@microsoft.com>
* fix bugs in logging code

* fix bug in CleanEntityStorage (not reading continuation token)
…ion to override previous execution completed events (#949)
* Add small getting started for distributed tracing

* Add distinction to getting started
…pecifying name/version/instanceId & startAt (#978)
* Update DurableTask.AzureStorage.csproj

* Update DurableTask.ApplicationInsights.csproj
)

Add links to https://github.com/kaushiksk/durabletask-samples which has detailed samples for various kinds of scenarios with capabilities to see disaster recovery scenarios in action, as well as suspend and resume executing orchestrations.

---------

Co-authored-by: Chris Gillum <cgillum@microsoft.com>
"Refactored Exception Handling in Retry Logic for RemoteOrchestrationServiceClient

The DurableTask.AzureServiceFabric NuGet package was previously using HttpWebRequest (.NET 4) and has since been updated to use HttpClient. However, the associated exception handling in the retry logic was not updated accordingly.

Originally, the catch block was designed to handle WebException, a legacy exception type associated with HttpWebRequest. HttpClient, however, throws HttpRequestException for request-related issues, not WebException.

This oversight led to the retry logic failing to function as intended, as it was not catching the correct exception type. This is particularly critical for the RemoteOrchestrationServiceClient, which relies on this retry mechanism to detect changes in the SF partition leader.

This commit updates the catch block to handle HttpRequestException, aligning with the HttpClient usage and restoring the intended functionality of the retry logic."
Co-authored-by: Leonardo Quijano Vincenzi <leonardoq@microsoft.com>
Hide link to unmonitored Gitter in main README.md file.
davidmrdavid and others added 11 commits March 27, 2024 13:21
…to throw OrchestrationAlreadyExistsException (#1060)
…rviceBus to Azure.Messaging.ServiceBus (#1014)

Co-authored-by: Nate Lehman <nalehman@microsoft.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Also bumped DurableTask.Core package version to 2.17.0
…tity Dispatcher (#1080)

* Update TaskEntityDispatcher.cs

* update by comment

* remove brackets

* remove white space

* add unit test

* update error msg

* update unit test

* entity tags patch (#1086)

* update test

---------

Co-authored-by: David Justo <david.justo.1996@gmail.com>
@nytian nytian closed this May 20, 2024
@nytian nytian deleted the nytian/mock-azt2 branch May 20, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.