(Feature) - xDai Compatibility by fernandomg · Pull Request #1476 · 5afe/safe-react

fernandomg · 2020-10-14T16:40:36Z

This PR closes #1353, by:

defining network-specific config files
implementing generic config to consume config files
removing all the hardcoded values related to native coins
making safe-apps support different networks

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com>

* Filter apps by network * add missing network

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Agustin Pane <agustin.pane@gmail.com>

* Add staging xDai deployment to travis * Add safe apps production url for xdai * Add travis rule to build xDai on master or integration branch

* fix min-height app containter and margin to info text at bottom * change css unit from % to vh Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>

* Replace all harcoded values * fix `generateBatchRequest` calls * Fix some ETH harcoded values + Add tests * Fix null or undefinded value * Move nativeCoin outside component + fix toTokenInput function * Remove native coin from useEffect Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

) * Adds FEATURES enum Renames features to disabledFeatures * Uses FEATURES enum instead of hardcoded contract features * Refactor enabledFeatures function, now checks that there are not disabled features by config before return the enabledFeatures result * Adds SAFE_APPS and CONTRACT_INTERACTION to FEATURES enum * Remove SAFE_APPS from sidebar if disabled * Redirect user from /apps if safe apps are disabled * Disables contract interaction from config * Remove !remoteOwners * Move settings to a constant

# Conflicts: # src/routes/safe/components/Apps/utils.ts

…' into feature/#1353-xDai-compatibility

github-actions · 2020-10-14T16:40:55Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-10-14T16:46:00Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	34	0
Ignored	15	N/A

Result: ✅ success
Annotations: 34 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/ConnectButton/index.tsx Line 69 - Argument 'props' should be typed.
src/logic/cookies/utils/index.ts Line 7 - Missing return type on function.
src/logic/cookies/utils/index.ts Line 7 - Argument 'key' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Missing return type on function.
src/logic/cookies/utils/index.ts Line 21 - Argument 'key' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Argument 'value' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Argument 'expirationDays' should be typed.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Argument 'safeAddress' should be typed.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Missing return type on function.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Argument 'dispatch' should be typed.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Missing return type on function.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Argument 'dispatch' should be typed.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Argument 'provider' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 51 - Argument 'values' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 127 - Object pattern argument should be typed.
src/routes/load/components/OwnerList/index.tsx Line 127 - Argument 'network' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Argument 'controls' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Object pattern argument should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'controls' should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'props' should be typed.
src/routes/open/container/Open.tsx Line 56 - Missing return type on function.
src/routes/open/container/Open.tsx Line 56 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 56 - Argument 'userAccount' should be typed.
src/routes/opening/components/Footer.tsx Line 16 - Missing return type on function.
src/routes/opening/components/Footer.tsx Line 42 - Missing return type on function.
src/routes/opening/components/Footer.tsx Line 60 - Missing return type on function.
src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Object pattern argument should be typed.
src/routes/safe/components/Balances/Tokens/screens/AssetsList/index.tsx Line 39 - Missing return type on function.
src/routes/safe/components/Balances/Tokens/screens/AssetsList/index.tsx Line 39 - Argument 'props' should be typed.
src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Missing return type on function.
src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Object pattern argument should be typed.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Missing return type on function.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Object pattern argument should be typed.
src/utils/intercom.ts Line 4 - Missing return type on function.

^{Report generated by eslint-plus-action}

ghost · 2020-10-14T16:52:39Z

Travis automatic deployment:
https://pr1476--safereact.review.gnosisdev.com/app

* add equality function to prevent re-renders * fix typing - I left the inline equalityFn, as an ad-hoc solution. First, because we're going to remove this when #1479 is done Second, because this way it infers the types defined in the useSelector generics

ghost · 2020-10-15T18:18:34Z

Travis automatic deployment:
https://pr1476--safereact.review.gnosisdev.com/app

Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>

ghost · 2020-10-16T00:14:32Z

Travis automatic deployment:
https://pr1476--safereact.review.gnosisdev.com/app

ghost · 2020-10-16T11:35:50Z

Travis automatic deployment:
https://pr1476--safereact.review.gnosisdev.com/app

* Add options to httpProvider * Add log when generateatchRequest fails * add types to generateBarchRequest * fix types in `generateBatchRequests` * add `.d` for imports of definition files * add `undefined` alternative value for `generateBatchRequests` ReturnValues - also, fixed typing errors in related functions * fix return values for `generateBatchRequests` in tests Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

ghost · 2020-10-16T16:15:36Z

Travis automatic deployment:
https://pr1476--safereact.review.gnosisdev.com/app

ghost · 2020-10-16T16:45:14Z

Travis automatic deployment:
https://pr1476--safereact.review.gnosisdev.com/app

* Replace old ETH values with native coin * Replace old ETH values with native coin * Replace old ETH values with native coin * Replace old ETH values with native coin * Remove networkInfo from the components * Replaces humanReadableValue to fromTokenUnit * Remove typo

ghost · 2020-10-16T19:19:13Z

Travis automatic deployment:
https://pr1476--safereact.review.gnosisdev.com/app

josipbagaric and others added 30 commits September 29, 2020 11:23

feat: Support for Volta and EWC

4d699b7

chore: Store network ID in the ETHEREUM_NETWORK enum itself

dbf0b96

chore: forward tx and address to non-etherscan explorers

a2491fe

fixes after rebase

cbd4e77

Merge branch 'development' into feature/#1353-xDai-compatibility

a211dcf

fix test, avoid assingning enum to const

580c7e9

fix typing errors

cfe727e

(Feature) [xDai] - Create network-based configurations (#1420)

6a4e353

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com>

(Feature) [xDai] Use generic config (#1422)

ab2d1cf

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com>

Merge branch 'development' into feature/#1353-xDai-compatibility

76fe441

fix function name after merge development

c86a0ea

(Feature) [xDai] - Contract interaction abi lookup (#1429)

5278527

Filter Apps by network (#1433)

74cb6cf

* Filter apps by network * add missing network

(Feature) [xDai] - Parametrize ethscan values (#1424)

8c16bce

(Feature) [xDai] - Use parametrized network values (#1437)

7d28efd

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Feature) [xDai] - Use tx service for loading token info (#1435)

8f85a2f

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Feature) [xDai] - Visually differentiate networks (#1431)

dc77aeb

Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Agustin Pane <agustin.pane@gmail.com>

Merge branch 'development' into feature/#1353-xDai-compatibility

7d85c5f

(Feature) [xDai] - Cosmetic fixes (#1449)

e941f1f

Add staging configuration for deployment using xDai (#1459)

8fe31d3

* Add staging xDai deployment to travis * Add safe apps production url for xdai * Add travis rule to build xDai on master or integration branch

(Bugfix) Set min height to ListContentLayout wrapper #1447 (#1451)

4d1cecf

* fix min-height app containter and margin to info text at bottom * change css unit from % to vh Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>

disable OpenZepplin in xDai (#1465)

525491a

remove any in config/index.ts (#1462)

058e23b

Deploy from xDai integration branch only to xDai staging

05f6bb7

Fix .travis.yml warnings

f5864d5

Update branch and condition for staging deployment

fc23728

Update xDai depoy condition

46d0496

(Feature) [xDai] - Fetch collectibles from Gnosis services (#1460)

bdcffa7

Daniel Sanchez and others added 4 commits October 14, 2020 16:05

Add https to safe-xdai apps link

b29cd24

make getExplorerInfo return values per network (#1470)

b033938

Merge branch 'development' into feature/#1353-xDai-compatibility

de76b20

# Conflicts: # src/routes/safe/components/Apps/utils.ts

Merge remote-tracking branch 'origin/feature/#1353-xDai-compatibility…

0f4ac62

…' into feature/#1353-xDai-compatibility

fernandomg added the do-not-merge label Oct 14, 2020

fernandomg self-assigned this Oct 14, 2020

fernandomg and others added 2 commits October 15, 2020 14:19

Merge branch 'development' into feature/#1353-xDai-compatibility

44045c5

(Fix) xDai feature issues (#1484)

13e0cb9

Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>

Merge branch 'development' into feature/#1353-xDai-compatibility

80c7f3c

(Feature) xDai configs (#1489)

80b088a

dasanra removed the do-not-merge label Oct 18, 2020

dasanra marked this pull request as ready for review October 18, 2020 19:45

dasanra approved these changes Oct 18, 2020

View reviewed changes

dasanra merged commit 9ca9007 into development Oct 18, 2020

github-actions bot locked and limited conversation to collaborators Oct 18, 2020

dasanra deleted the feature/#1353-xDai-compatibility branch October 18, 2020 19:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Feature) - xDai Compatibility#1476

(Feature) - xDai Compatibility#1476
dasanra merged 41 commits intodevelopmentfrom
feature/#1353-xDai-compatibility

fernandomg commented Oct 14, 2020 •

edited by dasanra

Loading

Uh oh!

github-actions bot commented Oct 14, 2020

Uh oh!

github-actions bot commented Oct 14, 2020 •

edited

Loading

Uh oh!

ghost commented Oct 14, 2020

Uh oh!

ghost commented Oct 15, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

fernandomg commented Oct 14, 2020 • edited by dasanra Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2020

Uh oh!

github-actions bot commented Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Oct 14, 2020

Uh oh!

ghost commented Oct 15, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

ghost commented Oct 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fernandomg commented Oct 14, 2020 •

edited by dasanra

Loading

github-actions bot commented Oct 14, 2020 •

edited

Loading