Skip to content

Fast-forward master-next #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 33 commits into from
Apr 7, 2019
Merged

Fast-forward master-next #1394

openshift-merge-robot merged 33 commits into from
Apr 7, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 7, 2019

No description provided.

spadgett and others added 30 commits March 26, 2019 15:13
@spadgett
Auth test updates
386e353 
* `login` and `challenge` are no longer in the API
* Prefix test env vars with `BRIDGE`
* Update README for recent changes
@TheRealJon
Move overview group and filter state to redux
b057484
@spadgett
Bug 1694542 - Hide View CSV action when no installed CSV
6742fae 
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1694542
@openshift-merge-robot
Merge pull request openshift#1336 from TheRealJon/issue-1296
8ca5146 
Move overview group and filter state to redux
@TheRealJon
Show "Evicted" instead of "Failed" for evicted pod status
931cd92
@nicolethoen
Enable tab into Create button
c2b1222
@spadgett
Deploy Image: default env value should be an empty array, not an empt…
86035f4 
…y object
@openshift-merge-robot
Merge pull request openshift#1375 from spadgett/deploy-image-default-env
c34a435 
Deploy Image: default env value should be an empty array, not an empty object
@openshift-merge-robot
Merge pull request openshift#1370 from spadgett/view-csv-hidden
eb2ac84 
Bug 1694542 - Hide View CSV action when no installed CSV
@rebeccaalpert
frontend: Remove placeholder style from Events dropdown filter
0523f54 
Fixes https://jira.coreos.com/browse/CONSOLE-1347
@openshift-merge-robot
Merge pull request openshift#1373 from TheRealJon/bug-1694788
87cf25b 
Show "Evicted" instead of "Failed" for evicted pod status
@jhadvig
Bug 1660785 - fix resource-requirements modal title and description
d511337
@spadgett
Bug 1696172: Fix runtime error adding first node taint
871e874 
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696172
@rhamilto
Work around Safari 12.1 bug where scroll position is not maintained w…
8ebae04 
…hen hovering over link
@spadgett
Upgrade chromedriver to 2.46.0
ab9f997
@spadgett
Correctly handle batch calls to setState when creating secrets
c4d2af5
@spadgett
Upgrade builder image to latest stable Chrome
eeba90a
@openshift-merge-robot
Merge pull request openshift#1382 from spadgett/runtime-error-taints-…
dae79aa 
…dialog

Bug 1696172: Fix runtime error adding first node taint
@spadgett
Temporarily disable broken e2e secrets scenario
da97d31
@openshift-merge-robot
Merge pull request openshift#1384 from rhamilto/safari-12.1-scroll-bug-2
668c310 
Bugzilla 1695446: Work around Safari 12.1 bug where scroll position is not maintained...
@rhamilto
Cleanup up branding so there is consistency among the product name
bf6f643 
* standardize product names to include "Red Hat" and reduce the number of places product name is declared
* remove product name from the about modal as it is redundant with the logo above
* remove orphaned props from about modal
@rhamilto
Add missing <noscript>, remove product name from tokener.html
9828dd8 
If JavaScript is not enabled, a blank white page is seen in the browser.  Adding the missing <noscript> puts a message on the page indicating JavaScript is required.
@openshift-merge-robot
Merge pull request openshift#1383 from spadgett/upgrade-chromedriver
e6c12a8 
Upgrade Chrome and Chromedriver
@openshift-merge-robot
Merge pull request openshift#1386 from spadgett/disable-image-secret-…
65b6285 
…test

Temporarily disable broken secret scenario tests
@openshift-merge-robot
Merge pull request openshift#1385 from spadgett/create-secret-set-state
89d52b4 
Correctly handle batch calls to setState when creating secrets
@openshift-merge-robot
Merge pull request openshift#1389 from rhamilto/branding-cleanup
7a28d42 
Cleanup up branding so there is consistency among the product name
@openshift-merge-robot
Merge pull request openshift#1378 from rebeccaalpert/event-dropdown
a3f8d61 
Remove placeholder style from Events dropdown filter
@openshift-merge-robot
Merge pull request openshift#1381 from jhadvig/BZ1660785_2
5ff4f1d 
Bug 1660785 - fix resource-requirements modal title and description
@openshift-merge-robot
Merge pull request openshift#1390 from rhamilto/noscript
9fc1af9 
Add missing <noscript>, remove product name from tokener.html
@openshift-merge-robot
Merge pull request openshift#1372 from nicolethoen/tab_into_create_bu…
24654a4 
…tton

Enable tab into Create button
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 7, 2019
@spadgett spadgett mentioned this pull request Apr 7, 2019
Merged
2 tasks
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 7, 2019

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm dca6af2 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member Author

spadgett commented Apr 7, 2019

/skip

@spadgett
Copy link
Member Author

spadgett commented Apr 7, 2019

Tagging since this a fast-forward of the branch.

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2019
@openshift-merge-robot openshift-merge-robot merged commit 24dedad into openshift:master-next Apr 7, 2019
@spadgett spadgett deleted the rebase-master-next branch April 7, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@spadgett @openshift-ci-robot @openshift-merge-robot @TheRealJon @nicolethoen @rebeccaalpert @jhadvig @rhamilto