Add display support for Vertamedia Adapter by Millerrok · Pull Request #1945 · prebid/Prebid.js

Millerrok · 2017-12-08T16:15:32Z

Type of change

Description of change

Add display support for VertamediaBidAdapter

test parameters for validating bids

      // Video instream adUnit
      {
        code: 'div-test-div',
        sizes: [[640, 480]],
        mediaTypes: {
          video: {
            context: 'instream'
          }
        },
        bids: [{
          bidder: 'vertamedia',
          params: {
            aid: 332842
          }
        }]
      }

      // Video outstream adUnit
      {
        code: 'outstream-test-div',
        sizes: [[640, 480]],
        mediaTypes: {
          video: {
            context: 'outstream'
          }
        },
        bids: [{
          bidder: 'vertamedia',
          params: {
            aid: 332842
          }
        }]
      }

      // Banner adUnit
      {
        code: 'div-test-div',
        sizes: [[300, 250]],
        bids: [{
          bidder: 'vertamedia',
          params: {
            aid: 324758
          }
        }]
      }

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

Other information

* 'master' of https://github.com/prebid/Prebid.js: (414 commits) Make response headers available to the specs (prebid#1748) add option to run tests in a specific file (prebid#1727) Update JCM Adapter to 1.0 (prebid#1715) Finished an unfinished comment. (prebid#1749) Platform.io Bidder Adapter update. Prebid v1.0. (prebid#1705) Fix window.top.host cross origin issue when in nested iframes. (prebid#1730) fix log message not displaying when referencing missing bidder (prebid#1737) Allow more than one placement from one page (prebid#1692) Justpremium Adapter bugfix (prebid#1716) Updating license (prebid#1717) realvuBidAdapter (prebid#1571) Update JSDoc to call the module `pbjs` (prebid#1572) Update Beachfront adapter for v1.0 (prebid#1675) Update AdButler adapter for Prebid v1.0 (prebid#1664) Increment pre version Fix for prebid#1628 (allowing standard bidCpmAdjustment) (prebid#1645) Prebid 0.31.0 Release Support native click tracking (prebid#1691) Initial commit for video support for pbs (prebid#1706) Fixes: Immediate adapter response may end auction (prebid#1690) ...

* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...

* 'master' of https://github.com/prebid/Prebid.js: Increment pre version Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784)

* unstream/master: (36 commits) + Add Optimatic Bid Adapter (prebid#1837) Add Bridgewell adapter (prebid#1825) Kumma adapter updated for Prebid 1.0 (prebid#1766) Touchup add bid response (prebid#1822) Fix skipped test (prebid#1836) Added new size in Rubicon pbjs Adapter (prebid#1842) HuddledMasses header bidding adapter (prebid#1806) Increment pre version Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) ...

* 'master' of https://github.com/prebid/Prebid.js: (43 commits) Merge Prebid 1.0 to Master (prebid#1936) Prebid.js 0.34.1 release Vertamedia adapter outstream support (prebid#1860) Expose native image-type asset dimensions on bid response object (prebid#1919) Remove for of (prebid#1932) Unit-test fix (prebid#1927) Remove description_url (prebid#1922) Trion Interactive Adapter Bugfix (prebid#1925) Remove config setting from Optimatic adapter (prebid#1909) IE bug fix (prebid#1930) Clarify ad unit media filtering warning (prebid#1903) Add ReadPeak Bid Adapter (prebid#1838) Change clone function to make deep copies (prebid#1910) Serverbid 1.0 (prebid#1802) sekindoUM for prebid1.0 (prebid#1777) update auctionId to be requestId (prebid#1896) bug fixed to populate userSync default values (prebid#1897) Increment pre version AdkernelAdn analytics adapter (prebid#1868) Justpremium Adapter: use `filter` instead of `...new Set` (prebid#1895) ...

Millerrok · 2017-12-13T15:25:26Z

@mkendall07 yes, by changing parameter aid to 324758
http://hb2.vertamedia.com/auction/?domain=ap.localhost&callbackId=299cffa7d44a55&aid=324758&ad_type=display&h=250&w=300&

mkendall07 · 2018-01-02T20:58:23Z

@Millerrok
Sorry for the delay. Can you please combine the video and display adapter? You can support multiple times in the adapter. Take a look here for example: https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L10

* 'master' of https://github.com/prebid/Prebid.js: Add note about docs needed before merge (prebid#1959) Prebid 1.1.1 Release Fixes unit tests in browsers other than chrome (prebid#1987) remove hardcoded localhost port for tests (prebid#1988) S2s defaults fix in serverbidServerBidAdapter (prebid#1986) Increment pre version Prebid 1.1.0 Release added hb_source to default keys (prebid#1969) ServerBid Server BidAdapter (prebid#1819) [Add BidAdapter] rxrtb adapter for Perbid.js 1.0 (prebid#1950) Remove duplicate request id and fix empty response from getHighesCpmBids, getAdserverTargeting (prebid#1970) Remove stray console.log (prebid#1975) Added iQM Bid Adapter for Prebid.js 1.0 (prebid#1880) + fixed endpoint request data property names - width to w and height to h (prebid#1955) Add freewheel ssp bidder adapter for prebid 1.0 (prebid#1793) use auctionId instead of requestId (prebid#1968) Serverbid bid adapter: update alias config (prebid#1963) Typo correction of YIELDONE md file (prebid#1954) allow non-mappable sizes to be passed and used in rubicon adapter (prebid#1893) Add user-facing docs reminder to PR template (prebid#1956)

Millerrok · 2018-01-03T17:05:13Z

@mkendall07 thanx for review. I have updated the PR and description according to your comments. Please take a look.

* 'master' of https://github.com/prebid/Prebid.js: (23 commits) Update Atomx adapter for Prebid v1.0 (prebid#2026) Add vi bid adapter (prebid#2020) Add eplanningBidAdapter (prebid#2003) OpenX Adapter: Update to support mediaTypes field, instead of the deprecated mediaType field (prebid#1974) Separate bids & won calls (prebid#2015) 1.0 adapter support for mantis (prebid#1840) Media.net adapter added (prebid#2038) GumGum Adapter for Prebid.js 1.0 (prebid#1966) Serverbid Bid Adapter: updated docs and ad sizes (prebid#2023) Adding districtm as an alias (prebid#2018) Use sudo to workaround Travis regression (prebid#2041) Fix uncached video bids triggering callback early (prebid#2017) Re-implemented RhythmOne audit beacon in prebid 1.0 interface (prebid#1953) Add NasmediaAdmixer adapter for Perbid.js 1.0 (prebid#1937) Update Adform adapter to Prebid v1.0 (prebid#1947) Upgrade Admixer adapter for Prebid 1.0 (prebid#1755) multiformat size validation checks (prebid#1964) Gjirafa Bidder Adapter (prebid#1944) pin gulp-connect at non-broken version (prebid#2008) Added dynamic ttl property for One Display and One Mobile. (prebid#2004) ...

Millerrok · 2018-01-23T14:04:02Z

@mkendall07
Hi! We have added support for multi mediatypes for creating our bids
Please take a look.

mkendall07 · 2018-01-23T20:08:15Z

@Millerrok
can you please open a PR for your docs update?
https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/vertamedia.md

Thanks

matthewlane · 2018-01-23T20:27:09Z

test/spec/modules/vertamediaBidAdapter_spec.js

-
-      expect(result).to.deep.equal(eq);
+      console.log(result);
+      console.log(eqResponse);


Please drop the above two console.log statements

@matthewlane
Code has been updated
Please take a look.

* 'master' of https://github.com/prebid/Prebid.js: Prebid 1.2.0 Release Use polyfilled includes method (prebid#2061) RockYou Adapter: Added RockYou Adapter supporting Prebid 1.0 (prebid#1977) Optimera Adapter for 1.0. (prebid#1961) Use cross-browser integer check (prebid#2058) Fix skipped test (prebid#2059) Support multiple media formats within a single ad unit (prebid#1991) pre1api module that allows use of deprecated pre1.0 API in Prebid 1.0 (prebid#1976) Colossus SSP header bidding adapter 1.0.0 (prebid#2029) InSkin Bidder Adapter (prebid#2016) Update adapter to prebid v1.0 (prebid#1908) PubMatic 1.0 adapter (prebid#2011)

Millerrok · 2018-01-24T13:29:54Z

@mkendall07
Yes, we Update Vertamedia Adapter description, and add examples
prebid/prebid.github.io#567

Please take a look.

Gorokhov and others added 28 commits January 30, 2017 14:16

Vertamedia prebid.js adapter initial

16b9617

sync

267f04c

remove https

99a311f

add http

f861ad2

remove let

8295748

fix typo

9738c9a

fix spaces

ec830c3

add descriptionUrl; remove log

ec77d6d

fix getSize

d346ac8

Merge branch 'master' into master

9f73124

add usege parseSizesInput

edc9745

Merge branch 'master' of https://github.com/Vertamedia/Prebid.js

eefc347

Add support for vastTag

82b2830

Add moulty bid request; set vastUrl for bider;

afcc529

update for vertamedia adapter to Prebid 1.0

f3e6eaa

Add vertamedia md file

e4c30e8

Add required fields

78b4827

Remove defaults; fix md file;

0945af1

add outstream mediaType support

59735e4

add outstream mediaType support

aece210

Resolve conflicts

42127de

fix test

f878902

Add Vertamedia display adapter

cee6390

harpere assigned mkendall07 Dec 8, 2017

harpere requested a review from mkendall07 December 8, 2017 19:10

mkendall07 added needs docs needs update labels Jan 2, 2018

m.sorochuk added 4 commits January 3, 2018 15:15

add display support for Vertamedia adapter; documentation update

ce5954d

update tests for VertamediaBidAdapter

95dca95

add supportedMediaTypes

11f20fa

Add comments

5d427d4

Millerrok changed the title ~~New Vertamedia display Adapter~~ Add display support for Vertamedia Adapter Jan 4, 2018

m.sorochuk added 2 commits January 23, 2018 15:40

Add moulty mediatypes support

95fe42d

mkendall07 approved these changes Jan 23, 2018

View reviewed changes

mkendall07 requested a review from matthewlane January 23, 2018 20:08

mkendall07 assigned matthewlane Jan 23, 2018

matthewlane reviewed Jan 23, 2018

View reviewed changes

m.sorochuk added 2 commits January 24, 2018 12:06

cleanup logs

2ae5513

Add sending multiple sizes

580f670

mkendall07 added this to the Prebid 1.3 release milestone Jan 24, 2018

matthewlane approved these changes Jan 24, 2018

View reviewed changes

matthewlane added LGTM and removed needs docs needs update labels Jan 24, 2018

matthewlane merged commit aa0bee7 into prebid:master Jan 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add display support for Vertamedia Adapter#1945

Add display support for Vertamedia Adapter#1945
matthewlane merged 41 commits intoprebid:masterfrom
Vertamedia:master

Millerrok commented Dec 8, 2017 •

edited

Loading

Uh oh!

Millerrok commented Dec 13, 2017

Uh oh!

mkendall07 commented Jan 2, 2018

Uh oh!

Millerrok commented Jan 3, 2018

Uh oh!

Millerrok commented Jan 23, 2018

Uh oh!

mkendall07 commented Jan 23, 2018

Uh oh!

matthewlane Jan 23, 2018

Uh oh!

Millerrok Jan 24, 2018

Uh oh!

Millerrok commented Jan 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

Millerrok commented Dec 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

Millerrok commented Dec 13, 2017

Uh oh!

mkendall07 commented Jan 2, 2018

Uh oh!

Millerrok commented Jan 3, 2018

Uh oh!

Millerrok commented Jan 23, 2018

Uh oh!

mkendall07 commented Jan 23, 2018

Uh oh!

matthewlane Jan 23, 2018

Choose a reason for hiding this comment

Uh oh!

Millerrok Jan 24, 2018

Choose a reason for hiding this comment

Uh oh!

Millerrok commented Jan 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Millerrok commented Dec 8, 2017 •

edited

Loading