Release v2.13.0 by dasanra · Pull Request #1493 · 5afe/safe-react

dasanra · 2020-10-19T11:29:08Z

Features

Add compatibility with xDai chain

Fixes

Fix issue not showing transactions correctly when more than one transaction pending with the same nonce
Minor fixes and internal improvements
Bump dependencies

Remember not to Squash this PR

* Update mastercopy error

Backmerge 2.12.0 to development

Backmerge v2.12.1 with travis fix

* Bump new onboard.js version * Detect if port is used and change it if needed before starting the server * Fix icon creation * Fix formatting Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Remove the auto adding owners when the safe loads * Let the user add "invalid names" in the addressbook and also shows them on the addressbook * Fix update name of safe if addressbook updated * Removes unused addSafe action, replaces it with addOrUpdateSafe Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Bumps [electron](https://github.com/electron/electron) from 9.3.0 to 9.3.1. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md) - [Commits](electron/electron@v9.3.0...v9.3.1) Signed-off-by: dependabot[bot] <support@github.com>

…-9.3.1 Bump electron from 9.3.0 to 9.3.1

Backmerge v2.12.2 to development

* Upgrade dependencies without breaking changes * Update electron and gnosis dependencies with minor changes * Upgrade dependencies with minor changes and remove unnecessary electron dependency * Upgrade truffle-contract to latest @truffle/contract

* Replaces old balanceUsd with fiatBalance and fiatCode on BalanceEndpoint API * Update balance endpoint tests Co-authored-by: Fernando <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* don't use nonce in tx reducer * remove displaying of pending status if tx has no confirmations * Fix test for transactions pending status Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* feat: Support for Volta and EWC * chore: Store network ID in the ETHEREUM_NETWORK enum itself * chore: forward tx and address to non-etherscan explorers * fix test, avoid assigning enum to const * (Feature) [xDai] - Create network-based configurations (#1420) Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com> * (Feature) [xDai] Use generic config (#1422) Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com> * fix function name after merge development * (Feature) [xDai] - Contract interaction abi lookup (#1429) * Filter Apps by network (#1433) * Filter apps by network * (Feature) [xDai] - Parametrize ethscan values (#1424) * (Feature) [xDai] - Use parametrized network values (#1437) Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> * (Feature) [xDai] - Use tx service for loading token info (#1435) Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> * (Feature) [xDai] - Visually differentiate networks (#1431) Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Agustin Pane <agustin.pane@gmail.com> * (Feature) [xDai] - Cosmetic fixes (#1449) * Add staging configuration for deployment using xDai (#1459) * Add staging xDai deployment to travis * Add safe apps production url for xdai * Add travis rule to build xDai on master or integration branch * (Bugfix) Set min height to ListContentLayout wrapper #1447 (#1451) * fix min-height app container and margin to info text at bottom * change css unit from % to vh Co-authored-by: nicosampler <nf.dominguez.87@gmail.com> * disable OpenZepplin in xDai (#1465) * remove any in config/index.ts (#1462) * [xDai] Parametrize Native Coin (#1444) * fix `generateBatchRequest` calls * Fix some ETH harcoded values + Add tests * Fix null or undefined value * Move nativeCoin outside component + fix toTokenInput function * Remove native coin from useEffect Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> * (Feature) [xDai] - Disable safe sections based on network config (#1468) * Adds FEATURES enum Renames features to disabledFeatures * Uses FEATURES enum instead of hard-coded contract features * Refactor enabledFeatures function, now checks that there are not disabled features by config before return the enabledFeatures result * Adds SAFE_APPS and CONTRACT_INTERACTION to FEATURES enum * Remove SAFE_APPS from sidebar if disabled * Redirect user from /apps if safe apps are disabled * Disables contract interaction from config * Remove !remoteOwners * Move settings to a constant * Deploy from xDai integration branch only to xDai staging * Fix .travis.yml warnings * Update branch and condition for staging deployment * Update xDai depoy condition * (Feature) [xDai] - Fetch collectibles from Gnosis services (#1460) * Add https to safe-xdai apps link * make getExplorerInfo return values per network (#1470) * (Fix) "Approve transaction" modal closes (#1477) * add equality function to prevent re-renders - I left the inline equalityFn, as an ad-hoc solution. First, because we're going to remove this when #1479 is done Second, because this way it infers the types defined in the useSelector generics * (Fix) xDai feature issues (#1484) Co-authored-by: nicosampler <nf.dominguez.87@gmail.com> * RPC interactions errors (#1475) * Add options to httpProvider * Add log when generateatchRequest fails * add types to generateBarchRequest * fix types in `generateBatchRequests` * add `.d` for imports of definition files * add `undefined` alternative value for `generateBatchRequests` ReturnValues - also, fixed typing errors in related functions * fix return values for `generateBatchRequests` in tests Co-authored-by: fernandomg <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> * (Feature) xDai configs (#1489) * (Feature) - Replaces ETH with network native coin (#1491) * Remove networkInfo from the components * Replaces humanReadableValue to fromTokenUnit Co-authored-by: JosephBagaric <bagaricjos@gmail.com> Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com> Co-authored-by: Mati Dastugue <mdastugu@amazon.com> Co-authored-by: Agustin Pane <agustin.pane@gmail.com> Co-authored-by: nicolas <nicosampler@users.noreply.github.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: Agustín Longoni <agustin.longoni@altoros.com> Co-authored-by: nicosampler <nf.dominguez.87@gmail.com> Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

github-actions · 2020-10-19T11:29:24Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-10-19T11:34:18Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	46	0
Ignored	16	N/A

Result: ✅ success
Annotations: 46 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/ConnectButton/index.tsx Line 69 - Argument 'props' should be typed.
src/logic/addressBook/store/middleware/addressBookMiddleware.ts Line 16 - Argument 'store' should be typed.
src/logic/addressBook/store/middleware/addressBookMiddleware.ts Line 16 - Argument 'next' should be typed.
src/logic/addressBook/store/middleware/addressBookMiddleware.ts Line 16 - Missing return type on function.
src/logic/addressBook/store/middleware/addressBookMiddleware.ts Line 16 - Argument 'action' should be typed.
src/logic/cookies/utils/index.ts Line 7 - Missing return type on function.
src/logic/cookies/utils/index.ts Line 7 - Argument 'key' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Missing return type on function.
src/logic/cookies/utils/index.ts Line 21 - Argument 'key' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Argument 'value' should be typed.
src/logic/cookies/utils/index.ts Line 21 - Argument 'expirationDays' should be typed.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Argument 'safeAddress' should be typed.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Missing return type on function.
src/logic/safe/store/actions/fetchSafeCreationTx.ts Line 20 - Argument 'dispatch' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'store' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'next' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Missing return type on function.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'action' should be typed.
src/logic/safe/store/middleware/safeStorage.ts Line 50 - Argument 'store' should be typed.
src/logic/safe/store/middleware/safeStorage.ts Line 50 - Argument 'next' should be typed.
src/logic/safe/store/middleware/safeStorage.ts Line 50 - Missing return type on function.
src/logic/safe/store/middleware/safeStorage.ts Line 50 - Argument 'action' should be typed.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Missing return type on function.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Argument 'dispatch' should be typed.
src/logic/wallets/store/actions/fetchProvider.ts Line 13 - Argument 'provider' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 51 - Argument 'values' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 127 - Object pattern argument should be typed.
src/routes/load/components/OwnerList/index.tsx Line 127 - Argument 'network' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Argument 'controls' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Object pattern argument should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'controls' should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'props' should be typed.
src/routes/open/container/Open.tsx Line 56 - Missing return type on function.
src/routes/open/container/Open.tsx Line 56 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 56 - Argument 'userAccount' should be typed.
src/routes/opening/components/Footer.tsx Line 16 - Missing return type on function.
src/routes/opening/components/Footer.tsx Line 42 - Missing return type on function.
src/routes/opening/components/Footer.tsx Line 60 - Missing return type on function.
src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Object pattern argument should be typed.
src/routes/safe/components/Balances/Tokens/screens/AssetsList/index.tsx Line 39 - Missing return type on function.
src/routes/safe/components/Balances/Tokens/screens/AssetsList/index.tsx Line 39 - Argument 'props' should be typed.
src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Missing return type on function.
src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Object pattern argument should be typed.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Missing return type on function.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Object pattern argument should be typed.
src/utils/intercom.ts Line 4 - Missing return type on function.

^{Report generated by eslint-plus-action}

ghost · 2020-10-19T11:44:54Z

Travis automatic deployment:
https://pr1493--safereact.review.gnosisdev.com/app

ghost · 2020-10-19T11:56:41Z

Travis automatic deployment:
https://pr1493--safereact.review.gnosisdev.com/app

ghost · 2020-10-19T12:01:44Z

Travis automatic deployment:
https://pr1493--safereact.review.gnosisdev.com/app

ghost · 2020-10-19T12:09:30Z

Travis automatic deployment:
https://pr1493--safereact.review.gnosisdev.com/app

matextrem and others added 18 commits September 28, 2020 20:35

Change wording when trying to add an incompatible Safe address (#1405)

ab1775e

* Update mastercopy error

Merge branch 'development' into release/v2.12.0

daf8421

Merge pull request #1411 from gnosis/release/v2.12.0

24f2828

Backmerge 2.12.0 to development

Merge branch 'development' into tweak-production-travis-build

5649369

Merge pull request #1413 from gnosis/tweak-production-travis-build

296a6f6

Backmerge v2.12.1 with travis fix

Checksum the address on addressInput (#1410)

f4f90ac

(Fix) Contract interaction ABI resets (#1394)

5a41c38

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Merge pull request #1438 from gnosis/dependabot/npm_and_yarn/electron…

1ee9dc3

…-9.3.1 Bump electron from 9.3.0 to 9.3.1

Merge pull request #1467 from gnosis/update-sablier-app

14e94ad

Backmerge v2.12.2 to development

Bump dependencies (#1478)

eab0e73

* Upgrade dependencies without breaking changes * Update electron and gnosis dependencies with minor changes * Upgrade dependencies with minor changes and remove unnecessary electron dependency * Upgrade truffle-contract to latest @truffle/contract

(Feature) - Update balance endpoint parameter usage (#1482)

b04ec43

* Replaces old balanceUsd with fiatBalance and fiatCode on BalanceEndpoint API * Update balance endpoint tests Co-authored-by: Fernando <fernando.greco@gmail.com> Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Bug #1384: Deadlock with pending older transactions (#1455)

396f6dd

* don't use nonce in tx reducer * remove displaying of pending status if tx has no confirmations * Fix test for transactions pending status Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Update xDai staging based on release/v2.13.0

037235a

Merge remote-tracking branch 'origin/master' into release/v2.13.0

d3d9fdc

dasanra self-assigned this Oct 19, 2020

Daniel Sanchez added 2 commits October 19, 2020 13:38

Add Google Analytics parameters

c00ece4

Set version v2.13.0

ca376c9

Fix getGoogleAnalyticsTrackingID

79cdc1e

dasanra requested review from fernandomg, mmv08 and nicosampler October 19, 2020 11:50

nicosampler approved these changes Oct 19, 2020

View reviewed changes

dasanra merged commit 319ad75 into master Oct 19, 2020

github-actions bot locked and limited conversation to collaborators Oct 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v2.13.0#1493

Release v2.13.0#1493
dasanra merged 21 commits intomasterfrom
release/v2.13.0

dasanra commented Oct 19, 2020 •

edited

Loading

Uh oh!

github-actions bot commented Oct 19, 2020

Uh oh!

github-actions bot commented Oct 19, 2020 •

edited

Loading

Uh oh!

ghost commented Oct 19, 2020

Uh oh!

ghost commented Oct 19, 2020

Uh oh!

ghost commented Oct 19, 2020

Uh oh!

ghost commented Oct 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

dasanra commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Features

Fixes

Remember not to Squash this PR

Uh oh!

github-actions bot commented Oct 19, 2020

Uh oh!

github-actions bot commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Oct 19, 2020

Uh oh!

ghost commented Oct 19, 2020

Uh oh!

ghost commented Oct 19, 2020

Uh oh!

ghost commented Oct 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dasanra commented Oct 19, 2020 •

edited

Loading

github-actions bot commented Oct 19, 2020 •

edited

Loading