Release v2.12.0 by dasanra · Pull Request #1397 · 5afe/safe-react

dasanra · 2020-09-24T14:09:14Z

Gnosis Safe Multisig - Public Release v2.12.0

Changes

Connect the Safe to any service through "Safe WalletConnect" safe-app (WalletConnect #1239, Add WalletConnect safe-app #1364)
Support for struct and array-like types in Transaction Details ((Bugfix) - #1233 Fix method values length in TXs #1314)
Added onUserReject event handler, to support user transaction rejection for safe-apps (Apps/Feature #37: add onUserReject event handler #1354)
SPAM tokens banned from the Safes (Remove "spam" tokens #1324)
Updated "Contract Data" modal for Ledger users (Ledger Contract Data Modal #1284)

Bugfix

Fix public methods not shown in Transaction Builder (Transaction builder Safe app doesn't show public methods #1258)
Fix Address Book entries removed on page refresh (Address book - New entries are erased when reloading the page #1246)
Fix long string in transaction details overflowing ((Bugfix) - #1233 Fix method values length in TXs #1314)
Fix list of Coin Assets disappear on Safe loading ((Bugfix) - #1312 Assets disappear when loading a safe #1333)
Fix tokens deactivated being active after refreshing (Deactivate tokens activate again after refresh #1329)
Fix pending transactions displaying wrong amount (0 instead of correct amount in transactions list for some time ( during confirmation and some time after execution) #1305)
Fix pending transactions not displaying "pending" status (Transaction doesn't show pending status when performing an action on an existing tx #1308)
Fix fees not showing in Transaction Details (Fix fees not showing in transaction details #1313)
Fix Incoming Transactions fail to load if transaction gas cannot be requested (Bug: incoming transactions do not load if it fails to fetch gas for a transaction #1321)

Chore

Updated onboard.js version, with improvement for Ledger devices ([Onboard] Bump to new version 1.12 that includes improvements for Ledger devices #1272)
Track GoogleAnalytics for Safe Actions (Track GA for safe actions #1302)
Enable strictNullChecks in TS compiler (Enable strictNullChecks option for typescript configuration #1265)

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* Track GA for safe actions * Add tracking for safeListSidebar * review changes * review changes v2

…rge/2.11.0

Backmerge: Release 2.11.0 to development

* Bump new onboard.js version * bump new version * Clean unnecessary dependencies from yarn.lock file * Bump dependencies without breaking changes Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* dep bump, enable strictNullChecks ts compiler option * working on errors wip * remove unused imports * nullchecks errors wip * fixing errors * fixing errors * fixing errors * fix clipboard func type errors * error fixes * error fixes * error fixes * error fixes * error fixes * error fixes * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * error fixing * Finally made it * eslint fixes * eslint fixes 2 * fix send funds validation * Update style load in ThresholdSettings * Fix isValidAddress default state for SendCollectible * fix OwnersColumn return type * fix extractUsefulMethods typing Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

… transaction (#1321) * check if gas returned values are valid when loading token info for incoming tx * Fix generateBatchRequests Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Bump new onboard.js version * Update contract data modal

* Add outgoing transaction fees in transaction details * Convert fee from wei only when showing extended transaction * Fix incoming transactions fee value to display correct value * Add ETH symbol to fee on details

…1301)" (#1335) This reverts commit bfed967.

* Add tooltip info * Update icon and types * Hide tooltip when value and balance are equal to 0 * Remove onClick + Improve perfomance issues Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* fix Sidebar position * fix padding * fix padding and margin Help Center and Not connected Icon * add scroll to Sidebar List menu Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

* fix: prevent runtime error when prev is `undefined` * fix: prevent runtime error when prev is `undefined` * fix: prevent runtime error when 'safes' is `undefined` * fix: add `dataDecoded` to the mocked tx so information is properly displayed for known methods * fix: set 'pending' status for tx being processed - given that the confirmations key is no longer an empty array, tx status must be explicitly set this way * fix: properly update mockedTx * fix: hide buttons when tx is pending * fix: type error * Rollback patches trying to fix bug Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* Test for balances store * Types for addressBook.ts * Adds addressBookUtils.test.ts * Remove duplicated type * Tests for addressBookUtils * Adds fetchSafeTokens.test.ts * Adds getMockedSafeInstance and getMockedTxServiceModel in safeHelper.ts * Adds shouldExecuteTransaction tests * Fix types for TransactionProps And getNewTxNonce * Adds tests for getNewTxNonce and getLastTx * Moves utils.test.tsx to /actions folder * Placeholder for transactionHelpers tests * isInnerTransaction tests * calculateTransactionStatus tests * Adds calculateTransactionType tests * Adds buildTx test Adds generateSafeTxHash test * Absolute imports * Adds types for getRefundParams * Adds getRefundParams tests * Add mock example for isInnerTransaction * Adds isCancelTransaction tests Adds isModifySettingsTransaction tests Adds isMultiSendTransaction tests Adds isUpgradeTransaction tests Adds isOutgoingTransaction tests Adds isCustomTransaction tests * Adds types in mockNonPayableTransactionObject * Add TODOS * Fix shortVersionOf function * Add ethAddresses.test.ts Adds sameAddress test Adds shortVersionOf test Adds isUserAnOwner test * Adds isUserAnOwnerOfAnySafe Adds isValidEnsName * Fix isERC721Contract * Adds tokenHelpers.test.ts: - getEthAsToken - isTokenTransfer - getERC20DecimalsAndSymbol - isERC721Contract * Fix eslint errors * Remove unused files * Use selectors in safeBalance tests * Move file near his implementation * Replaces resultExpected with expectedResult * Update comment * Reword tests * Adds utility function description * Merge with dev Fix types * Fix types * Fix build types * Mock contract Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

…g a safe (#1357)

* Set desktop app build on workflow_dispatch * Update workflow_dispatch * Add yarn cache to build desktop app Upgrade electron to latest compatible version Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* dep bump, enable strictNullChecks ts compiler option * remove unused imports * nullchecks errors wip * fix clipboard func type errors * fix send funds validation * Update style load in ThresholdSettings * Fix isValidAddress default state for SendCollectible * fix OwnersColumn return type * fix extractUsefulMethods typing * Bug: incoming transactions do not load if it fails to fetch gas for a transaction (#1321) * check if gas returned values are valid when loading token info for incoming tx * Fix generateBatchRequests Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> (cherry picked from commit 372d27f) * Revert "Revert "Tech debt 1265: Enable strictNullChecks TS compiler option (#1301)" (#1335)" This reverts commit 43bc498. * Fix safe clean load Fix transaction nonce get * Fix issue adding owners again after reloading the page * Add viewedSafes correctly to current session * Add typing and reduce dependency with immutable * Rename SerializedSessionState to CurrentSessionState * Remove immutable from currentSession * Use Dispatch type defined using ThunkDispatch * Remove if as parameter should always be defined * Fix test typo issues Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

* Fix load current session * Fixs useMemo usage in filteredData * Type fetchTokens * Type useFetchTokens * Type setCurrencyBalances * Fixs ADD_SAFE reducer for existing safe, uses mergeDeep instead of merge, now the active tokens for the safe are not overwritten * Fix save selected currency * Adds excludeSpamTokens param in fetchTokenCurrenciesBalances * Adds onlyTrustedTokens param in fetchTokenCurrenciesBalances * Merge with development * Remove onlyTrustedTokens param * Fix unnecesary changes * Replace Dispatch with ThunkDispatch * Fix import consistency * Type containsMethodByHash * Fix blacklisted addresses calculation * Adds types on updateActiveTokens Adds types on updateBlacklistedTokens * Refactor Tokens to TokenList, makes it functional component also fix blacklisted addresses calculation * Refactor Tokens to TokenList, makes it functional component also fix blacklisted addresses calculation * Refactor AddCustomToken, add types Removes actions from Tokens * Fix warning on useEffect Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* fix currency middleware, actinos, cleanup & bugfix * mergeDeep in reducer * dont modify state in add_safe if same already exists Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* add onUserReject event handler * fix invoking possibly undefined func * update sdk version * yarn lock update * fix network passing

Backmerge v2.11.1 to development

(Bugfix) - #925 [Contract Interaction] UI Glitch

* Bump new onboard.js version * Fix opera touch

* Fix ENS names * Fix types * Add typo to AddressBookInput component * Remove ensToAddress field * Fix error message variable name Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Fix method values length in TXs * arrays Improvment * Make use of EthHashInfo * review change

* Fix addressbook types Restructure addressbook store type * Add more safe types * Fix imports * Removes .toJS() usage * Fix condition for saving addressBook * Types & remove send button from addressbook if user not an owner * Add types for addressBook actions Remove unused saveAndUpdateAddressBook action * Refactor addressBook: make it global and removes immutableJS Add types Removes unused addAddressBook action * Remove todo * Fix edit and remove entries style when user is not owner * Adds and updates safe name in addressBook * Adds checkIfOwnerWasDeletedFromAddressBook Let the user remove owners users without adding them again each time the safe loads * Simplify loadAddressBookFromStorage * Fix compilation errors included in pr #1301 * Uses sameAddress function * Add migration function for old stored address books * Update tests * Replaces shouldAvoidUpdatesNotifications with addAddressBookEntryOptions on addAddressBookEntry * Update tests * Unify return on getOwnersWithNameFromAddressBook * Reword shouldAvoidUpdatesNotifications * Replaces adbk with addressBook * Fix condition * Fix typos * Fix typo Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* fix address being used as name * Restore ENS name when sending transaction * use `addressName` as default value if it happens that the name in the addressBook is not defined * use resolvedAddress to filter by address in the address book Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>

* use `safeFeaturesEnabled` selector also organized a bit the code (styles) and added Types for the `ChooseTxType` component * fix `getGnosisSafeInstanceAt` return type * add types to `safeStorage` refactor `getSafeName` * use redux selector to obtain master contract version * fix return type Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* use `updateSafe` instead of `addSafe` * fix SAFE_UPDATE reducer - treat every key individually * allow to load owners on the first request * Set UPDATE_SAFE to individually handling all props * Handle List special case * Add comment to list check Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Add Yearn Finance app

* Fix addressbook types Restructure addressbook store type * Add more safe types * Fix imports * Removes .toJS() usage * Fix condition for saving addressBook * Types & remove send button from addressbook if user not an owner * Add types for addressBook actions Remove unused saveAndUpdateAddressBook action * Refactor addressBook: make it global and removes immutableJS Removes unused addAddressBook action * Fix edit and remove entries style when user is not owner * Adds and updates safe name in addressBook * Adds checkIfOwnerWasDeletedFromAddressBook Let the user remove owners users without adding them again each time the safe loads * Simplify loadAddressBookFromStorage * Fix compilation errors included in pr #1301 * Uses sameAddress function * Add migration function for old stored address books * Replaces shouldAvoidUpdatesNotifications with addAddressBookEntryOptions on addAddressBookEntry * Unify return on getOwnersWithNameFromAddressBook * Adds the addressbook names in safe load * Reword shouldAvoidUpdatesNotifications * Replaces adbk with addressBook * Renames adbk to AddressBook * Types on Open and Layout * Remove unused actions and selectors * Replaces initialValuesFrom to a hook and retrieves the ownerName * Uses addressBook names in safe creation * Fix owner name on creating safe * Renames getNameFromAddressBook to getNameFromAddressBookSelector * Fixs addOrUpdateAddressBookEntry action * Updates addressbook on safe load * Revert load update addressbook behaviour * Renames checkIfOwnerWasDeletedFromAddressBook to checkIfEntryWasDeletedFromAddressBook * Feedback * Type review informaiton * Adds ADD_OR_UPDATE_SAFE action * Replaces addSafe with addOrUpdateSafe on addSafeHandler * Exports isValidAddressBookName util function * Adds isValidAddressBookName test * Add tests for checkIfEntryWasDeletedFromAddressBook * Fix saveAddressBook test * Fix fetchSafeTokens.test.ts * Add update individually safe props in addOrUpdate * Fix updating addressbook entries on safe load/create * Fix always loading safe as LOADED SAFE instead of safe name * Fix adding owner as UNKNOWN on addressBook when adding new owner Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Add safe-connect safe-app * rename safe-connect to walletConnect Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

* Update travis script to execute tests * Update ReviewInformation components to remove type error * Fix tests and import types without .d * Upgrade dependencies with minor changes

github-actions · 2020-09-24T14:09:32Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-09-24T14:14:51Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	83	0
Ignored	16	N/A

Result: ✅ success
Annotations: 83 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/App/ReceiveModal.tsx Line 82 - Missing return type on function.
src/components/Table/TableHead.tsx Line 22 - Argument 'property' should be typed.
src/components/Table/TableHead.tsx Line 22 - Argument 'orderAttr' should be typed.
src/components/Table/TableHead.tsx Line 22 - Missing return type on function.
src/components/Table/TableHead.tsx Line 28 - Missing return type on function.
src/logic/addressBook/store/middleware/addressBookMiddleware.ts Line 13 - Argument 'store' should be typed.
src/logic/addressBook/store/middleware/addressBookMiddleware.ts Line 13 - Argument 'next' should be typed.
src/logic/addressBook/store/middleware/addressBookMiddleware.ts Line 13 - Missing return type on function.
src/logic/addressBook/store/middleware/addressBookMiddleware.ts Line 13 - Argument 'action' should be typed.
src/logic/currencyValues/store/middleware/index.ts Line 6 - Argument 'next' should be typed.
src/logic/currencyValues/store/middleware/index.ts Line 6 - Missing return type on function.
src/logic/currencyValues/store/middleware/index.ts Line 6 - Argument 'action' should be typed.
src/logic/currentSession/utils/index.ts Line 9 - Missing return type on function.
src/logic/currentSession/utils/index.ts Line 9 - Argument 'currentSession' should be typed.
src/logic/safe/store/actions/processTransaction.ts Line 26 - Object pattern argument should be typed.
src/logic/safe/store/actions/processTransaction.ts Line 26 - Missing return type on function.
src/logic/safe/store/actions/processTransaction.ts Line 27 - Argument 'dispatch' should be typed.
src/logic/safe/store/actions/processTransaction.ts Line 28 - Argument 'getState' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'store' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'next' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Missing return type on function.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'action' should be typed.
src/logic/safe/store/middleware/safeStorage.ts Line 56 - Argument 'store' should be typed.
src/logic/safe/store/middleware/safeStorage.ts Line 56 - Argument 'next' should be typed.
src/logic/safe/store/middleware/safeStorage.ts Line 56 - Missing return type on function.
src/logic/safe/store/middleware/safeStorage.ts Line 56 - Argument 'action' should be typed.
src/logic/safe/transactions/awaitingTransactions.ts Line 8 - Argument 'cancellationTxs' should be typed.
src/logic/safe/transactions/offchainSigner/EIP712Signer.ts Line 62 - Missing return type on function.
src/logic/safe/transactions/offchainSigner/EIP712Signer.ts Line 62 - Argument 'txArgs' should be typed.
src/logic/safe/transactions/offchainSigner/index.ts Line 21 - Argument 'txArgs' should be typed.
src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'store' should be typed.
src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'next' should be typed.
src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Missing return type on function.
src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'action' should be typed.
src/routes/load/components/DetailsForm/index.tsx Line 51 - Argument 'values' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 127 - Object pattern argument should be typed.
src/routes/load/components/OwnerList/index.tsx Line 127 - Argument 'network' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Argument 'controls' should be typed.
src/routes/load/components/OwnerList/index.tsx Line 128 - Object pattern argument should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'controls' should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'props' should be typed.
src/routes/open/components/SafeNameForm/index.tsx Line 74 - Argument 'controls' should be typed.
src/routes/open/components/SafeNameForm/index.tsx Line 74 - Object pattern argument should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'index' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'notRemovedOwners' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'values' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 239 - Object pattern argument should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Argument 'controls' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Object pattern argument should be typed.
src/routes/open/container/Open.tsx Line 55 - Missing return type on function.
src/routes/open/container/Open.tsx Line 55 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 55 - Argument 'userAccount' should be typed.
src/routes/opening/index.tsx Line 107 - Object pattern argument should be typed.
src/routes/safe/components/Balances/SendModal/SafeInfo/index.tsx Line 7 - Missing return type on function.
src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Object pattern argument should be typed.
src/routes/safe/components/Balances/Tokens/screens/AssetsList/index.tsx Line 41 - Missing return type on function.
src/routes/safe/components/Balances/Tokens/screens/AssetsList/index.tsx Line 41 - Argument 'props' should be typed.
src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx Line 29 - Missing return type on function.
src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx Line 29 - Argument 'values' should be typed.
src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx Line 29 - Argument 'safeAddress' should be typed.
src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx Line 29 - Argument 'ownersOld' should be typed.
src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx Line 29 - Argument 'enqueueSnackbar' should be typed.
src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx Line 29 - Argument 'closeSnackbar' should be typed.
src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx Line 29 - Argument 'dispatch' should be typed.
src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/ThresholdForm/index.tsx Line 26 - Missing return type on function.
src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/ThresholdForm/index.tsx Line 26 - Object pattern argument should be typed.
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx Line 27 - Missing return type on function.
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx Line 28 - Argument 'values' should be typed.
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx Line 29 - Argument 'safeAddress' should be typed.
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx Line 30 - Argument 'ownerAddressToRemove' should be typed.
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx Line 31 - Argument 'enqueueSnackbar' should be typed.
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx Line 32 - Argument 'closeSnackbar' should be typed.
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx Line 33 - Argument 'threshold' should be typed.
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx Line 34 - Argument 'dispatch' should be typed.
src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Missing return type on function.
src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Object pattern argument should be typed.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Missing return type on function.
src/routes/safe/components/Transactions/TxsTable/ExpandedTx/IncomingTxDescription/index.tsx Line 36 - Object pattern argument should be typed.
src/utils/intercom.ts Line 4 - Missing return type on function.

[warning] @typescript-eslint/no-non-null-assertion

Disallows non-null assertions using the ! postfix operator

src/routes/safe/components/Transactions/TxsTable/TxType/index.tsx Line 74 - Forbidden non-null assertion.
src/routes/safe/components/Transactions/TxsTable/TxType/index.tsx Line 74 - Forbidden non-null assertion.

^{Report generated by eslint-plus-action}

ghost · 2020-09-24T14:23:52Z

Travis automatic deployment:
https://pr1397--safereact.review.gnosisdev.com/app

francovenica · 2020-09-24T22:18:42Z

Changes

Added onUserReject event handler, to support user transaction rejection for safe-apps (Apps/Feature #37: add onUserReject event handler #1354)
Tested by Mikha, doesn't have steps to test.
SPAM tokens banned from the Safes (Remove "spam" tokens #1324)
Can't be done in rinkeby.
Connect the Safe to any service through "Safe WalletConnect" safe-app (WalletConnect #1239, Add WalletConnect safe-app #1364)
Done
Support for struct and array-like types in Transaction Details ((Bugfix) - #1233 Fix method values length in TXs #1314)
Created tx with array type inputs, with a ABI given by one of the devs. Tested with the new tx builder URL: https://safe-apps.dev.gnosisdev.com/tx-builder
Updated "Contract Data" modal for Ledger users (Ledger Contract Data Modal #1284)
Modal shows fine.

Bugfix

Fix public methods not shown in Transaction Builder (Transaction builder Safe app doesn't show public methods #1258)
This was tested in prod already with the new tx builder address: https://safe-apps.dev.gnosisdev.com/tx-builder
Fix Address Book entries removed on page refresh (Address book - New entries are erased when reloading the page #1246)
Create safe /load safe names suggested from address book
Edit name in the safe/load creation edits the address book
Edit the name in the settings changes the name in the address book and viceversa
Fix long string in transaction details overflowing ((Bugfix) - #1233 Fix method values length in TXs #1314)
Tested with Fernando, pointing his local env to mainnet and checking the safe and tx where the issue was found in the first place. It looks good
Fix list of Coin Assets disappear on Safe loading ((Bugfix) - #1312 Assets disappear when loading a safe #1333)
Assets load fine
Fix tokens deactivated being active after refreshing (Deactivate tokens activate again after refresh #1329)
BUG Tokens cannot be disabled in the Manage list modal #1399
Fix pending transactions displaying wrong amount (0 instead of correct amount in transactions list for some time ( during confirmation and some time after execution) #1305)
Tx showing the right amount
Fix pending transactions not displaying "pending" status (Transaction doesn't show pending status when performing an action on an existing tx #1308)
Works fine
Fix fees not showing in Transaction Details (Fix fees not showing in transaction details #1313)
Fees are being shown properly with 9 decimals and the ETH at the end.
Fix Incoming Transactions fail to load if transaction gas cannot be requested (Bug: incoming transactions do not load if it fails to fetch gas for a transaction #1321)
Tried different incoming tx and all showed fine in the table

Chore

Updated onboard.js version, with improvement for Ledger devices ([Onboard] Bump to new version 1.12 that includes improvements for Ledger devices #1272)
Done
Track GoogleAnalytics for Safe Actions (Track GA for safe actions #1302)
Not functional test to be done
Enable strictNullChecks in TS compiler (Enable strictNullChecks option for typescript configuration #1265)
Not functional test to be done

* Fix adding owners * Lint

ghost · 2020-09-25T15:59:44Z

Travis automatic deployment:
https://pr1397--safereact.review.gnosisdev.com/app

* Fix activate / blacklist token or asset * Fix asset add test * Add new actions to storage middleware to save on change

ghost · 2020-09-25T16:53:16Z

Travis automatic deployment:
https://pr1397--safereact.review.gnosisdev.com/app

francovenica · 2020-09-28T02:58:03Z

@dasanra
Issues:
1 - I still have the issue that Uxio was solving for the backend, the issue with the tokens. I assume that issue is only for PR and dev env, so Idk if those would stop a deployment.
2 - Tokens are not showing balance in the assets tab except for ETH. I assume is related to issue1. The tokens where I have funds should show up by default, but they are not, only the ETH balance is being shown. This is a snapshot of the safe in dev, so you can see all the assets I should have listed by default when I load the safe:

3 - When I lock tokens in apps that do that I should get the tokens minted from them. In the next snapshot you will a WalletConnect Tx where I minted tokens from https://mintr.synthetix.io/. When I tested that one in Nico's PR I remember I got tokens to minted tokens to the safe, something that's not happening here.
I assume that with idleV4 and Yearn Vault the same should happen, but is not.
Here's a link to the safe: https://pr1397--safereact.review.gnosisdev.com/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/transactions

dasanra · 2020-09-28T09:44:40Z

@francovenica I'm not sure about the 3rd one, but other two are related to the transaction service issue that was deployed on staging. Shouldn't have problems in production.

I suspect that the 3rd is also related but will check with you for the specific scenario

francovenica · 2020-09-28T16:02:40Z

All the issues seems to be tied to the same problem. With a backend re indexation they now look fine in the PR. We are good to go to stg and do some test there in mainnet.

@dasanra

francovenica · 2020-09-28T20:15:02Z

For the stg mainnet deployment. I don't have a ticket for that so I'll write them here for now.

Tested here:
https://safe-team-mainnet.staging.gnosisdev.com/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/apps

Issues:
1 - I'm getting the "no funds but ETH" issue we had earlier in the dev env
stg:

A snapshot from prod from the same safe:

2 - The IdleV4 app is not loading. This only happens here in the stg env:

francovenica · 2020-09-28T20:57:57Z

3 - I got the same problem of minted tokens not arriving as "incoming tx". I think it derives from the same issue I commented before, the tokens not showing funds
https://safe-team-mainnet.staging.gnosisdev.com/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/transactions

Daniel Sanchez and others added 30 commits August 31, 2020 14:22

Update idle safe app (#1290)

e9f7acf

Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

Track GA for safe actions (#1302)

f7d4cfe

* Track GA for safe actions * Add tracking for safeListSidebar * review changes * review changes v2

Merge branch 'master' of github.com:gnosis/safe-react into dev-backme…

0fbc5f6

…rge/2.11.0

Merge pull request #1310 from gnosis/dev-backmerge/2.11.0

6f036f9

Backmerge: Release 2.11.0 to development

Bump new onboard.js version (#1307)

c5bafa6

* Bump new onboard.js version * bump new version * Clean unnecessary dependencies from yarn.lock file * Bump dependencies without breaking changes Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Bug: incoming transactions do not load if it fails to fetch gas for a…

372d27f

… transaction (#1321) * check if gas returned values are valid when loading token info for incoming tx * Fix generateBatchRequests Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Update Contract Data Modal (#1322)

7821da0

* Bump new onboard.js version * Update contract data modal

Fix fees not showing in transaction details (#1313)

b7afc5c

* Add outgoing transaction fees in transaction details * Convert fee from wei only when showing extended transaction * Fix incoming transactions fee value to display correct value * Add ETH symbol to fee on details

Revert "Tech debt 1265: Enable strictNullChecks TS compiler option (#…

43bc498

…1301)" (#1335) This reverts commit bfed967.

(Feature) Tooltip equivalent balance may be zero (#1337)

9ead8ef

* Add tooltip info * Update icon and types * Hide tooltip when value and balance are equal to 0 * Remove onClick + Improve perfomance issues Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Bugfix) - #1286 Fix Sidebar position (#1340)

5b99cea

* fix Sidebar position * fix padding * fix padding and margin Help Center and Not connected Icon * add scroll to Sidebar List menu Co-authored-by: nicolas <nicosampler@users.noreply.github.com>

Add lenght requirements for safe/owner naming when creating or loadin…

0d7fc80

…g a safe (#1357)

Add manual trigger to desktop app build (#1356)

141b646

* Set desktop app build on workflow_dispatch * Update workflow_dispatch * Add yarn cache to build desktop app Upgrade electron to latest compatible version Co-authored-by: Mikhail Mikheev <mmvsha73@gmail.com>

(Bugfix) - #1312 Assets disappear when loading a safe (#1333)

e000958

* fix currency middleware, actinos, cleanup & bugfix * mergeDeep in reducer * dont modify state in add_safe if same already exists Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Apps/Feature #37: add onUserReject event handler (#1354)

8a6633d

* add onUserReject event handler * fix invoking possibly undefined func * update sdk version * yarn lock update * fix network passing

add word-break property

6636fdf

apply the word break property to the container

a86c919

add styles to class formContainer

835e647

Merge branch 'development' into release/v2.11.1

e546870

Merge pull request #1370 from gnosis/release/v2.11.1

e81f2ec

Backmerge v2.11.1 to development

Merge branch 'development' into issue-925

f20152a

Merge pull request #1365 from gnosis/issue-925

f3b2d69

(Bugfix) - #925 [Contract Interaction] UI Glitch

Not able to connect with Opera Touch (#1378)

dc632be

* Bump new onboard.js version * Fix opera touch

ENS names not working properly (#1372)

46c5946

* Fix ENS names * Fix types * Add typo to AddressBookInput component * Remove ensToAddress field * Fix error message variable name Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

(Bugfix) - #1233 Fix method values length in TXs (#1314)

fffabf0

* Fix method values length in TXs * arrays Improvment * Make use of EthHashInfo * review change

Agupane and others added 10 commits September 22, 2020 09:31

Feature: Send env info message on safe apps sdk initialization (#1349)

eebe972

Add Yearn Finance app (#1390)

d134871

* Add Yearn Finance app

Add WalletConnect safe-app (#1364)

32547a8

* Add safe-connect safe-app * rename safe-connect to walletConnect Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>

Update travis script to execute tests (#1382)

171b6d9

* Update travis script to execute tests * Update ReviewInformation components to remove type error * Fix tests and import types without .d * Upgrade dependencies with minor changes

Set v2.12.0

dc806dc

dasanra requested a review from francovenica September 24, 2020 14:09

dasanra self-assigned this Sep 24, 2020

(Bugfix) Owners duplicated (#1402)

c1bc366

* Fix adding owners * Lint

v2.12.0 Bugfix - Fix Activate/Blacklist tokens (#1401)

aeda4f6

* Fix activate / blacklist token or asset * Fix asset add test * Add new actions to storage middleware to save on change

francovenica approved these changes Sep 28, 2020

View reviewed changes

dasanra merged commit 21bd4a2 into master Sep 28, 2020

github-actions bot locked and limited conversation to collaborators Sep 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v2.12.0#1397

Release v2.12.0#1397
dasanra merged 42 commits intomasterfrom
release/v2.12.0

dasanra commented Sep 24, 2020 •

edited by fernandomg

Loading

Uh oh!

github-actions bot commented Sep 24, 2020

Uh oh!

github-actions bot commented Sep 24, 2020 •

edited

Loading

Uh oh!

ghost commented Sep 24, 2020

Uh oh!

francovenica commented Sep 24, 2020 •

edited

Loading

Uh oh!

ghost commented Sep 25, 2020

Uh oh!

ghost commented Sep 25, 2020

Uh oh!

francovenica commented Sep 28, 2020 •

edited

Loading

Uh oh!

dasanra commented Sep 28, 2020

Uh oh!

francovenica commented Sep 28, 2020

Uh oh!

francovenica commented Sep 28, 2020 •

edited

Loading

Uh oh!

francovenica commented Sep 28, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

dasanra commented Sep 24, 2020 • edited by fernandomg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gnosis Safe Multisig - Public Release v2.12.0

Changes

Bugfix

Chore

Uh oh!

github-actions bot commented Sep 24, 2020

Uh oh!

github-actions bot commented Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

[warning] @typescript-eslint/no-non-null-assertion

Uh oh!

ghost commented Sep 24, 2020

Uh oh!

francovenica commented Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 25, 2020

Uh oh!

ghost commented Sep 25, 2020

Uh oh!

francovenica commented Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dasanra commented Sep 28, 2020

Uh oh!

francovenica commented Sep 28, 2020

Uh oh!

francovenica commented Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francovenica commented Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dasanra commented Sep 24, 2020 •

edited by fernandomg

Loading

github-actions bot commented Sep 24, 2020 •

edited

Loading

francovenica commented Sep 24, 2020 •

edited

Loading

francovenica commented Sep 28, 2020 •

edited

Loading

francovenica commented Sep 28, 2020 •

edited

Loading

francovenica commented Sep 28, 2020 •

edited

Loading